[Qemu-commits] [qemu/qemu] 88428b: vnc: fix qemu crash when not configure vnc option

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 88428b7a93347efc51be015cc12cb71fab3976a3
      
https://github.com/qemu/qemu/commit/88428b7a93347efc51be015cc12cb71fab3976a3
  Author: Gonglei <address@hidden>
  Date:   2015-02-16 (Mon, 16 Feb 2015)

  Changed paths:
    M ui/vnc.c

  Log Message:
  -----------
  vnc: fix qemu crash when not configure vnc option

Add missing vnc options: to, ipv4, ipv6 and fix
qemu crash.

Reproducer:
$ x86_64-softmmu/qemu-system-x86_64
qemu-system-x86_64: Invalid parameter 'to'
Segmentation fault (core dumped)

BTW the patch fix the below bug:
https://bugs.launchpad.net/qemu/+bug/1414222

Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Don Slutz <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: e2a11d9d5a7d8b8450cd644e73b829dcf4686528
      
https://github.com/qemu/qemu/commit/e2a11d9d5a7d8b8450cd644e73b829dcf4686528
  Author: Gonglei <address@hidden>
  Date:   2015-02-16 (Mon, 16 Feb 2015)

  Changed paths:
    M ui/vnc.c

  Log Message:
  -----------
  vnc: correct missing property about vnc_display

Missing three property for vnc socket connection,
revalue display variable with correct way.

Signed-off-by: Gonglei <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: a2c72de09619ed4d2f4498a65027114f9c035f7f
      
https://github.com/qemu/qemu/commit/a2c72de09619ed4d2f4498a65027114f9c035f7f
  Author: Gonglei <address@hidden>
  Date:   2015-02-16 (Mon, 16 Feb 2015)

  Changed paths:
    M ui/vnc.c

  Log Message:
  -----------
  vnc: using bool type instead of int for QEMU_OPT_BOOL

Signed-off-by: Gonglei <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 2779672fa3f0680e63ecfd3ee2d6ff360ce948a2
      
https://github.com/qemu/qemu/commit/2779672fa3f0680e63ecfd3ee2d6ff360ce948a2
  Author: Gonglei <address@hidden>
  Date:   2015-02-16 (Mon, 16 Feb 2015)

  Changed paths:
    M include/ui/console.h
    M ui/vnc.c

  Log Message:
  -----------
  vnc: introduce an wrapper for auto assign vnc id

Signed-off-by: Gonglei <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: f7801c5ce42250bf1e84d21bceb1802cfe4485e8
      
https://github.com/qemu/qemu/commit/f7801c5ce42250bf1e84d21bceb1802cfe4485e8
  Author: Gonglei <address@hidden>
  Date:   2015-02-16 (Mon, 16 Feb 2015)

  Changed paths:
    M qmp.c

  Log Message:
  -----------
  vnc: auto assian an id when calling change vnc qmp interface

Only in this way, change vnc qmp interface can take effect,
because qemu_opts_find(&qemu_vnc_opts, id) will return NULL
in vnc_display_open(), It can't connect successfully vnc
server forever.

Signed-off-by: Gonglei <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 0e7d6f608339029404efd025ae9b8965ffe60087
      
https://github.com/qemu/qemu/commit/0e7d6f608339029404efd025ae9b8965ffe60087
  Author: Peter Lieven <address@hidden>
  Date:   2015-02-16 (Mon, 16 Feb 2015)

  Changed paths:
    M ui/vnc.c

  Log Message:
  -----------
  ui/vnc: optimize full scanline updates

in case we send and update for a complete scanline increment
the y offset to avoid running to find_next_bit for that lines
twice.

Signed-off-by: Peter Lieven <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 9e0ff75e5158c7dbb65ee447382bbdf4cafbef8b
      
https://github.com/qemu/qemu/commit/9e0ff75e5158c7dbb65ee447382bbdf4cafbef8b
  Author: Gerd Hoffmann <address@hidden>
  Date:   2015-02-16 (Mon, 16 Feb 2015)

  Changed paths:
    M ui/vnc.c

  Log Message:
  -----------
  vnc: fix coverity warning

vnc_display_local_addr will not be called with an invalid display id.
Add assert() to silence coverity warning about a null pointer dereference.

Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 3dd2d1a33976a7ec4aa3a6a29e5183af53949237
      
https://github.com/qemu/qemu/commit/3dd2d1a33976a7ec4aa3a6a29e5183af53949237
  Author: Peter Maydell <address@hidden>
  Date:   2015-02-24 (Tue, 24 Feb 2015)

  Changed paths:
    M include/ui/console.h
    M qmp.c
    M ui/vnc.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/pull-vnc-20150216-1' into 
staging

vnc: fixup some QemuOpts conversion fallout.

# gpg: Signature made Mon Feb 16 08:13:32 2015 GMT using RSA key ID D3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"

* remotes/kraxel/tags/pull-vnc-20150216-1:
  vnc: fix coverity warning
  ui/vnc: optimize full scanline updates
  vnc: auto assian an id when calling change vnc qmp interface
  vnc: introduce an wrapper for auto assign vnc id
  vnc: using bool type instead of int for QEMU_OPT_BOOL
  vnc: correct missing property about vnc_display
  vnc: fix qemu crash when not configure vnc option

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/bf2fd13af392...3dd2d1a33976