qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 39cb51: vfio: fix wrong initialize vfio_group


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 39cb51: vfio: fix wrong initialize vfio_group_list
Date: Thu, 05 Feb 2015 03:30:10 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 39cb514f02c7daf6378117e28be7a659a69e48b7
      
https://github.com/qemu/qemu/commit/39cb514f02c7daf6378117e28be7a659a69e48b7
  Author: Chen Fan <address@hidden>
  Date:   2015-02-04 (Wed, 04 Feb 2015)

  Changed paths:
    M hw/vfio/common.c

  Log Message:
  -----------
  vfio: fix wrong initialize vfio_group_list

Signed-off-by: Chen Fan <address@hidden>
Signed-off-by: Alex Williamson <address@hidden>


  Commit: 3a4dbe6aa934370a92372528c1255ee1504965ee
      
https://github.com/qemu/qemu/commit/3a4dbe6aa934370a92372528c1255ee1504965ee
  Author: Alex Williamson <address@hidden>
  Date:   2015-02-04 (Wed, 04 Feb 2015)

  Changed paths:
    M hw/vfio/pci.c

  Log Message:
  -----------
  vfio-pci: Fix missing unparent of dynamically allocated MemoryRegion

Commit d8d95814609e added explicit object_unparent() calls for
dynamically allocated MemoryRegions.  The VFIOMSIXInfo structure also
contains such a MemoryRegion, covering the mmap'd region of a PCI BAR
above the MSI-X table.  This structure is freed as part of the class
exit function and therefore also needs an explicit object_unparent().
Failing to do this results in random segfaults due to fields within
the structure, often the class pointer, being reclaimed and corrupted
by the time object_finalize_child_property() is called for the object.

Signed-off-by: Alex Williamson <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Cc: address@hidden # 2.2


  Commit: 32193cb421cecb98b48715e0740b2d948cda0779
      
https://github.com/qemu/qemu/commit/32193cb421cecb98b48715e0740b2d948cda0779
  Author: Peter Maydell <address@hidden>
  Date:   2015-02-05 (Thu, 05 Feb 2015)

  Changed paths:
    M hw/vfio/common.c
    M hw/vfio/pci.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/awilliam/tags/vfio-update-20150204.0' 
into staging

VFIO fixes:
- Fix wrong initializer (Chen Fan)
- Add missing object_unparent (Alex Williamson)

# gpg: Signature made Wed 04 Feb 2015 18:49:24 GMT using RSA key ID 3BB08B22
# gpg: Good signature from "Alex Williamson <address@hidden>"
# gpg:                 aka "Alex Williamson <address@hidden>"
# gpg:                 aka "Alex Williamson <address@hidden>"
# gpg:                 aka "Alex Williamson <address@hidden>"

* remotes/awilliam/tags/vfio-update-20150204.0:
  vfio-pci: Fix missing unparent of dynamically allocated MemoryRegion
  vfio: fix wrong initialize vfio_group_list

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/ec6f25e788ef...32193cb421ce

reply via email to

[Prev in Thread] Current Thread [Next in Thread]