[Qemu-commits] [qemu/qemu] b6e2c9: linux-user/signal.c: Remove current_exec_domain_si...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: b6e2c9353a5bd8649ee71a52c35344ce3fb1c7d2
      
https://github.com/qemu/qemu/commit/b6e2c9353a5bd8649ee71a52c35344ce3fb1c7d2
  Author: Peter Maydell <address@hidden>
  Date:   2015-01-27 (Tue, 27 Jan 2015)

  Changed paths:
    M linux-user/signal.c

  Log Message:
  -----------
  linux-user/signal.c: Remove current_exec_domain_sig()

Remove the function current_exec_domain_sig(), which always returns
its argument. This was intended as a stub for supporting the kernel's
exec_domain handling, but:
 * we don't have any of the other code for execution domains
 * in the kernel this handling is architecture-specific, not generic
 * we only call this function in the x86, ppc and sh4 signal code paths,
   and the PPC one is wrong anyway because the PPC kernel doesn't
   have this signal-remapping code

So it's best to simply delete the function; any future attempt to
implement exec domains will be better served by adding the correct
code from scratch based on the kernel sources at that time.

This change also fixes some clang warnings about the function being
defined but not used for some target architectures.

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Riku Voipio <address@hidden>


  Commit: ea2b5fb19d50c1cbdea9a40504e31e54d37b8bab
      
https://github.com/qemu/qemu/commit/ea2b5fb19d50c1cbdea9a40504e31e54d37b8bab
  Author: Peter Maydell <address@hidden>
  Date:   2015-01-27 (Tue, 27 Jan 2015)

  Changed paths:
    M linux-user/alpha/syscall_nr.h

  Log Message:
  -----------
  linux-user/alpha: Add define for NR_shmat to enable shmat syscall

For historical reasons, the define for the shmat() syscall on Alpha is
NR_osf_shmat; however it has the same semantics as this syscall does
on all other architectures, so define TARGET_NR_shmat as well so that
QEMU's code for the syscall is enabled.

This patch brings our behaviour on the LTP shmat tests into line
with that for ARM (still not a perfect pass rate but not "this syscall
is completely broken" as we had before).

(Problem detected via a clang warning that the do_shmat() function
was unused on Alpha.)

Cc: Richard Henderson <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Riku Voipio <address@hidden>


  Commit: 1af2ee08f9b2f70d31676be14b26026223c9f660
      
https://github.com/qemu/qemu/commit/1af2ee08f9b2f70d31676be14b26026223c9f660
  Author: Peter Maydell <address@hidden>
  Date:   2015-01-27 (Tue, 27 Jan 2015)

  Changed paths:
    M linux-user/arm/nwfpe/fpopcode.c

  Log Message:
  -----------
  linux-user/arm/nwfpe: Delete unused aCC array

The aCC array in fpopcode.c is completely unused in QEMU; delete
it (silencing a clang warning).

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Riku Voipio <address@hidden>


  Commit: b040bc9c0360106fab57bb1abe2d242bd17c4c32
      
https://github.com/qemu/qemu/commit/b040bc9c0360106fab57bb1abe2d242bd17c4c32
  Author: Peter Maydell <address@hidden>
  Date:   2015-01-27 (Tue, 27 Jan 2015)

  Changed paths:
    M linux-user/main.c

  Log Message:
  -----------
  linux-user/main.c: Call cpu_exec_start/end on all target archs

The start_exclusive() infrastructure is used on all target
architectures, even if only to do the "stop all CPUs before
dumping core" in force_sig(), so be consistent and call
cpu_exec_start/end in the main loop of every target.

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Riku Voipio <address@hidden>


  Commit: f7e61b222b2796ee43c976ec44c61a15d55ff662
      
https://github.com/qemu/qemu/commit/f7e61b222b2796ee43c976ec44c61a15d55ff662
  Author: Peter Maydell <address@hidden>
  Date:   2015-01-27 (Tue, 27 Jan 2015)

  Changed paths:
    M linux-user/main.c

  Log Message:
  -----------
  linux-user/main.c: Mark end_exclusive() as possibly unused

The function end_exclusive() isn't used on all targets; mark it as
such to avoid a clang warning.

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Riku Voipio <address@hidden>


  Commit: f6c7a05b8985df7eaf9942ca78e19890204eee4a
      
https://github.com/qemu/qemu/commit/f6c7a05b8985df7eaf9942ca78e19890204eee4a
  Author: Peter Maydell <address@hidden>
  Date:   2015-01-27 (Tue, 27 Jan 2015)

  Changed paths:
    M linux-user/signal.c

  Log Message:
  -----------
  linux-user/signal.c: Remove unnecessary wrapper copy_siginfo_to_user

The function copy_siginfo_to_user() just calls tswap_siginfo(), so
call the latter function directly and delete the wrapper function.
The wrapper is actually misleading since it implies that the
semantics are like the kernel function with the same name which
copies the data to a guest user-space address. In fact tswap_siginfo()
just does data-structure conversion between two structures whose
addresses are host addresses (the copy to userspace is handled
in QEMU by the lock_user/unlock_user calls).

This also fixes clang complaints about the wrapper being unused
in some configs.

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Riku Voipio <address@hidden>


  Commit: 95018018caeea209f58695645fd1d50a9d0ba6df
      
https://github.com/qemu/qemu/commit/95018018caeea209f58695645fd1d50a9d0ba6df
  Author: Felix Janda <address@hidden>
  Date:   2015-01-27 (Tue, 27 Jan 2015)

  Changed paths:
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user: translate resource also for prlimit64

The resource argument is translated from host to target for
[gs]etprlimit but not for prlimit64. Fix this.

Signed-off-by: Felix Janda <address@hidden>
Signed-off-by: Riku Voipio <address@hidden>


  Commit: 9c6bf9c7d71d7da18a024182b69569969449d6f9
      
https://github.com/qemu/qemu/commit/9c6bf9c7d71d7da18a024182b69569969449d6f9
  Author: Ed Swierk <address@hidden>
  Date:   2015-01-27 (Tue, 27 Jan 2015)

  Changed paths:
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user: Fix ioctl cmd type mismatch on 64-bit targets

linux-user passes the cmd argument of the ioctl syscall as a signed long,
but compares it to an unsigned int when iterating through the ioctl_entries
list.  When the cmd is a large value like 0x80047476 (TARGET_TIOCSWINSZ on
mips64) it gets sign-extended to 0xffffffff80047476, causing the comparison
to fail and resulting in lots of spurious "Unsupported ioctl" errors.
Changing the target_cmd field in the ioctl_entries list to a signed int
causes those values to be sign-extended as well during the comparison.

Signed-off-by: Ed Swierk <address@hidden>
Signed-off-by: Riku Voipio <address@hidden>


  Commit: ec355f15476fe91b95c4326836d3fe572d8075e1
      
https://github.com/qemu/qemu/commit/ec355f15476fe91b95c4326836d3fe572d8075e1
  Author: Ed Swierk <address@hidden>
  Date:   2015-01-27 (Tue, 27 Jan 2015)

  Changed paths:
    M linux-user/mips64/target_signal.h

  Log Message:
  -----------
  mips64-linux-user: Fix definition of struct sigaltstack

Without this fix, qemu segfaults when emulating the sigaltstack syscall,
because it incorrectly treats the ss_flags field as 64 bits rather than 32
bits.

Signed-off-by: Ed Swierk <address@hidden>
Signed-off-by: Riku Voipio <address@hidden>


  Commit: 1669add752d9f29283f8ebf6a863d7b1e2d0f146
      
https://github.com/qemu/qemu/commit/1669add752d9f29283f8ebf6a863d7b1e2d0f146
  Author: Peter Maydell <address@hidden>
  Date:   2015-01-27 (Tue, 27 Jan 2015)

  Changed paths:
    M linux-user/signal.c

  Log Message:
  -----------
  linux-user: Fix broken m68k signal handling on 64 bit hosts

The m68k signal frame setup code which writes the signal return
trampoline code to the stack was assuming that a 'long' was 32 bits;
on 64 bit systems this meant we would end up writing the 32 bit
(2 insn) trampoline sequence to retaddr+4,retaddr+6 instead of
the intended retaddr+0,retaddr+2, resulting in a guest crash when
it tried to execute the invalid zero-bytes at retaddr+0.
Fix by using uint32_t instead; also use uint16_t rather than short
for consistency. This fixes bug LP:1404690.

Reported-by: Michel Boaventura
Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Riku Voipio <address@hidden>


  Commit: 30b8b68eb574fd68060eebcc4da790fdfe18d668
      
https://github.com/qemu/qemu/commit/30b8b68eb574fd68060eebcc4da790fdfe18d668
  Author: Alex Suykov <address@hidden>
  Date:   2015-01-27 (Tue, 27 Jan 2015)

  Changed paths:
    M linux-user/syscall.c

  Log Message:
  -----------
  linux-user: support target-to-host SCM_CREDENTIALS

When passing ancillary data through a unix socket, handle
credentials properly instead of doing a simple copy and
issuing a warning.

Signed-off-by: Alex Suykov <address@hidden>
Signed-off-by: Riku Voipio <address@hidden>


  Commit: 83761b9244ad2ed39d3cfabe8a0e901ab906f7bf
      
https://github.com/qemu/qemu/commit/83761b9244ad2ed39d3cfabe8a0e901ab906f7bf
  Author: Peter Maydell <address@hidden>
  Date:   2015-01-27 (Tue, 27 Jan 2015)

  Changed paths:
    M linux-user/alpha/syscall_nr.h
    M linux-user/arm/nwfpe/fpopcode.c
    M linux-user/main.c
    M linux-user/mips64/target_signal.h
    M linux-user/signal.c
    M linux-user/syscall.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20150127' 
into staging

linux-user updates since last pull request

# gpg: Signature made Tue 27 Jan 2015 20:52:54 GMT using RSA key ID DE3C9BC0
# gpg: Good signature from "Riku Voipio <address@hidden>"
# gpg:                 aka "Riku Voipio <address@hidden>"

* remotes/riku/tags/pull-linux-user-20150127:
  linux-user: support target-to-host SCM_CREDENTIALS
  linux-user: Fix broken m68k signal handling on 64 bit hosts
  mips64-linux-user: Fix definition of struct sigaltstack
  linux-user: Fix ioctl cmd type mismatch on 64-bit targets
  linux-user: translate resource also for prlimit64
  linux-user/signal.c: Remove unnecessary wrapper copy_siginfo_to_user
  linux-user/main.c: Mark end_exclusive() as possibly unused
  linux-user/main.c: Call cpu_exec_start/end on all target archs
  linux-user/arm/nwfpe: Delete unused aCC array
  linux-user/alpha: Add define for NR_shmat to enable shmat syscall
  linux-user/signal.c: Remove current_exec_domain_sig()

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/b00c92e3ef59...83761b9244ad