[Qemu-commits] [qemu/qemu] 993937: sb16: fix interrupt acknowledgement

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 9939375c282a0f97afa69dc6799d3c77aaf7d544
      
https://github.com/qemu/qemu/commit/9939375c282a0f97afa69dc6799d3c77aaf7d544
  Author: Paolo Bonzini <address@hidden>
  Date:   2015-01-22 (Thu, 22 Jan 2015)

  Changed paths:
    M hw/audio/sb16.c

  Log Message:
  -----------
  sb16: fix interrupt acknowledgement

SoundBlaster 16 emulation is very broken and consumes a lot of CPU, but a
small fix was suggested offlist and it is enough to fix some games.  I
got Epic Pinball to work with the "SoundBlaster Clone" option.

The processing of the interrupt register is wrong due to two missing
"not"s.  This causes the interrupt flag to remain set even after the
Acknowledge ports have been read (0x0e and 0x0f).

The line was introduced by commit 85571bc (audio merge (malc), 2004-11-07),
but the code might have been broken before because I did not look closely
at the huge patches from 10 years ago.

Reported-by: Joshua Bair <address@hidden>
Cc: Gerd Hoffmann <address@hidden>
Cc: address@hidden
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: c6441452b50c44fdbb362b239ce623f77cf3cd51
      
https://github.com/qemu/qemu/commit/c6441452b50c44fdbb362b239ce623f77cf3cd51
  Author: Peter Maydell <address@hidden>
  Date:   2015-01-22 (Thu, 22 Jan 2015)

  Changed paths:
    M hw/audio/sb16.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/pull-audio-20150122-1' into 
staging

b16: fix interrupt acknowledgement

# gpg: Signature made Thu 22 Jan 2015 11:38:29 GMT using RSA key ID D3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"

* remotes/kraxel/tags/pull-audio-20150122-1:
  sb16: fix interrupt acknowledgement

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/8f970eff6e31...c6441452b50c