[Qemu-commits] [qemu/qemu] fe4831: spice: add unix address support

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: fe4831b1e7e7007ae15ae0470a06898660ab3877
      
https://github.com/qemu/qemu/commit/fe4831b1e7e7007ae15ae0470a06898660ab3877
  Author: Marc-André Lureau <address@hidden>
  Date:   2015-01-22 (Thu, 22 Jan 2015)

  Changed paths:
    M qemu-options.hx
    M ui/spice-core.c

  Log Message:
  -----------
  spice: add unix address support

Teach qemu to set up a Spice server with a UNIX socket using the
following arguments -spice unix,addr=path.

Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 51a090991449c7d3c6d428eda18b4f30a36e2c1b
      
https://github.com/qemu/qemu/commit/51a090991449c7d3c6d428eda18b4f30a36e2c1b
  Author: Gerd Hoffmann <address@hidden>
  Date:   2015-01-22 (Thu, 22 Jan 2015)

  Changed paths:
    M ui/spice-display.c

  Log Message:
  -----------
  spice: fix coverity reported defect in display code

Report:

1. Condition surface, taking false branch
406    if (surface && ssd->surface &&
407        surface_width(surface) == pixman_image_get_width(ssd->surface) &&
408        surface_height(surface) == pixman_image_get_height(ssd->surface)) {
409        /* no-resize fast path: just swap backing store */
...

10. alias_transfer: Assigning: ssd->ds = surface.
440    ssd->ds = surface;

11. var_deref_op: Dereferencing null pointer ssd->ds.
CID 1264334 (#1 of 1): Dereference after null check (FORWARD_NULL)
441    ssd->surface = pixman_image_ref(ssd->ds->image);

Fix:

Move code block dereferencing ssd->ds into the already existing
if (ssd->ds) { ... } block.

Cc: Paolo Bonzini <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: adeecf14d668f5f0a73c9be91772e15b4f8727f3
      
https://github.com/qemu/qemu/commit/adeecf14d668f5f0a73c9be91772e15b4f8727f3
  Author: Peter Maydell <address@hidden>
  Date:   2015-01-22 (Thu, 22 Jan 2015)

  Changed paths:
    M qemu-options.hx
    M ui/spice-core.c
    M ui/spice-display.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/spice/tags/pull-spice-20150122-1' into 
staging

spice: fix coverity defect, add unix address support

# gpg: Signature made Thu 22 Jan 2015 11:17:24 GMT using RSA key ID D3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"

* remotes/spice/tags/pull-spice-20150122-1:
  spice: fix coverity reported defect in display code
  spice: add unix address support

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/b3a4755a67a5...adeecf14d668