qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 9feb8a: vt82c686: avoid out-of-bounds read

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 9feb8a: vt82c686: avoid out-of-bounds read
Date: Thu, 15 Jan 2015 03:30:08 -0800 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 9feb8adeaa850d15b930c30f22c1ed2f2f695172
      
https://github.com/qemu/qemu/commit/9feb8adeaa850d15b930c30f22c1ed2f2f695172
  Author: Paolo Bonzini <address@hidden>
  Date:   2015-01-15 (Thu, 15 Jan 2015)

  Changed paths:
    M hw/isa/vt82c686.c

  Log Message:
  -----------
  vt82c686: avoid out-of-bounds read

superio_ioport_readb can read the 256th element of the array.
Coverity reports an out-of-bounds write in superio_ioport_writeb,
but it does not show the corresponding out-of-bounds read
because it cannot prove that it can happen.  Fix the root
cause of the problem (zhanghailang's patch instead fixes
the logic in superio_ioport_writeb).

Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: zhanghailiang <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
Cc: address@hidden


  Commit: 9c6d5c1ade0b681b6f93c3d9d214389355cc563c
      
https://github.com/qemu/qemu/commit/9c6d5c1ade0b681b6f93c3d9d214389355cc563c
  Author: Peter Maydell <address@hidden>
  Date:   2015-01-15 (Thu, 15 Jan 2015)

  Changed paths:
    M tests/hd-geo-test.c

  Log Message:
  -----------
  tests/hd-geo-test.c: Remove unused test_image variable

Remove unused variable test_image; this silences a clang warning.

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 2d8ac5eb7a7e72e0877cca2b3705eebeaf5526e7
      
https://github.com/qemu/qemu/commit/2d8ac5eb7a7e72e0877cca2b3705eebeaf5526e7
  Author: SeokYeon Hwang <address@hidden>
  Date:   2015-01-15 (Thu, 15 Jan 2015)

  Changed paths:
    M translate-all.c

  Log Message:
  -----------
  translate-all: Mark map_exec() with the 'unused' attribute

Mark map_exec() with the 'unused' attribute to avoid '-Wunused-function'
warnings on clang 3.4 or later. This means we don't need to mark it
'inline', which is what we were previously using to suppress the warning
(a trick which only works with gcc, not clang).

Signed-off-by: SeokYeon Hwang <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
[PMM: tweaked comment message a little]
Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 90d6a6730b4dbe7d0ada9900aba8263d61376812
      
https://github.com/qemu/qemu/commit/90d6a6730b4dbe7d0ada9900aba8263d61376812
  Author: Peter Maydell <address@hidden>
  Date:   2015-01-15 (Thu, 15 Jan 2015)

  Changed paths:
    M migration/qemu-file.c

  Log Message:
  -----------
  migration/qemu-file.c: Don't shift left into sign bit

Add a cast in qemu_get_be32() to avoid shifting left into the sign
bit of a signed integer (which is undefined behaviour in C).

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 37097418be0a722342fc0ef77c2e773359d2cd05
      
https://github.com/qemu/qemu/commit/37097418be0a722342fc0ef77c2e773359d2cd05
  Author: Stefan Weil <address@hidden>
  Date:   2015-01-15 (Thu, 15 Jan 2015)

  Changed paths:
    M target-tricore/csfr.def
    M target-tricore/translate.c
    M target-tricore/tricore-opcodes.h

  Log Message:
  -----------
  target-tricore: Fix new typos

adress -> address
managment -> management

Cc: Bastian Koppelmann <address@hidden>
Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 1281f8e3085b9149b8704419534f0e6f23c1fa64
      
https://github.com/qemu/qemu/commit/1281f8e3085b9149b8704419534f0e6f23c1fa64
  Author: Stefan Weil <address@hidden>
  Date:   2015-01-15 (Thu, 15 Jan 2015)

  Changed paths:
    M target-arm/helper.c

  Log Message:
  -----------
  target-arm: Fix typo in comment (seperately -> separately)

Cc: Peter Maydell <address@hidden>
Cc: Greg Bellows <address@hidden>
Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: b4952c3677170139541bc6bc14e9c2cfdc056181
      
https://github.com/qemu/qemu/commit/b4952c3677170139541bc6bc14e9c2cfdc056181
  Author: Stefan Weil <address@hidden>
  Date:   2015-01-15 (Thu, 15 Jan 2015)

  Changed paths:
    M include/hw/hotplug.h
    M tests/ahci-test.c

  Log Message:
  -----------
  misc: Fix new typos in comments

recieve -> receive
suprise -> surprise

Cc: Igor Mammedov <address@hidden>
Cc: John Snow <address@hidden>
Signed-off-by: Stefan Weil <address@hidden>
Reviewed-by: John Snow <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: fac6688a18574b6f2caa8c699a936e729ed53ece
      
https://github.com/qemu/qemu/commit/fac6688a18574b6f2caa8c699a936e729ed53ece
  Author: Don Slutz <address@hidden>
  Date:   2015-01-15 (Thu, 15 Jan 2015)

  Changed paths:
    M qemu-char.c

  Log Message:
  -----------
  Do not hang on full PTY

Signed-off-by: Don Slutz <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 3d59b6808bc5e0efbf1aee48d7f9ea96d19df05d
      
https://github.com/qemu/qemu/commit/3d59b6808bc5e0efbf1aee48d7f9ea96d19df05d
  Author: David Morrison <address@hidden>
  Date:   2015-01-15 (Thu, 15 Jan 2015)

  Changed paths:
    M target-openrisc/translate.c

  Log Message:
  -----------
  target-openrisc: bugfix for dec_sys to decode instructions correctly

Fixed the decoding of "system" instructions (starting with 0x2)
in dec_sys() in translate.c.  In particular, the l.trap instruction
is now correctly decoded, which enables for singlestepping and
breakpoints to be set in GDB.

Signed-off-by: David R. Morrison <address@hidden>
Acked-by: Jia Liu <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: ae21935924365efecf5c5ba998cb6cb8c85a499b
      
https://github.com/qemu/qemu/commit/ae21935924365efecf5c5ba998cb6cb8c85a499b
  Author: Thomas Huth <address@hidden>
  Date:   2015-01-15 (Thu, 15 Jan 2015)

  Changed paths:
    M Makefile

  Log Message:
  -----------
  Makefile: Remove config.status and common.env during 'make distclean'

config.status and tests/qemu-iotests/common.env are generated files
that should be deleted during 'make distclean'.

Signed-off-by: Thomas Huth <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 31fc97c3145d428751f8bc4d5666a525d5c3dc2f
      
https://github.com/qemu/qemu/commit/31fc97c3145d428751f8bc4d5666a525d5c3dc2f
  Author: Paolo Bonzini <address@hidden>
  Date:   2015-01-15 (Thu, 15 Jan 2015)

  Changed paths:
    M hw/display/blizzard.c

  Log Message:
  -----------
  blizzard: do not depend on VGA internals

There is nothing that is used by this ARM-specific device.

Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 99efa84d5c02e33bcca7be83dd7cabc4b0f22f14
      
https://github.com/qemu/qemu/commit/99efa84d5c02e33bcca7be83dd7cabc4b0f22f14
  Author: Marcel Apfelbaum <address@hidden>
  Date:   2015-01-15 (Thu, 15 Jan 2015)

  Changed paths:
    M vl.c

  Log Message:
  -----------
  vl.c: fix some alignment issues

The misalignment was caused by tabs which were used instead of spaces.

Signed-off-by: Marcel Apfelbaum <address@hidden>
Reviewed-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: df58887b20fab8fe8a6dcca4db30cd4e4077d53a
      
https://github.com/qemu/qemu/commit/df58887b20fab8fe8a6dcca4db30cd4e4077d53a
  Author: Peter Maydell <address@hidden>
  Date:   2015-01-15 (Thu, 15 Jan 2015)

  Changed paths:
    M Makefile
    M hw/display/blizzard.c
    M hw/isa/vt82c686.c
    M include/hw/hotplug.h
    M migration/qemu-file.c
    M qemu-char.c
    M target-arm/helper.c
    M target-openrisc/translate.c
    M target-tricore/csfr.def
    M target-tricore/translate.c
    M target-tricore/tricore-opcodes.h
    M tests/ahci-test.c
    M tests/hd-geo-test.c
    M translate-all.c
    M vl.c

  Log Message:
  -----------
  Merge remote-tracking branch 
'remotes/mjt/tags/pull-trivial-patches-2015-01-15' into staging

trivial patches for 2015-01-15

# gpg: Signature made Thu 15 Jan 2015 08:26:26 GMT using RSA key ID A4C3D7DB
# gpg: Good signature from "Michael Tokarev <address@hidden>"
# gpg:                 aka "Michael Tokarev <address@hidden>"
# gpg:                 aka "Michael Tokarev <address@hidden>"

* remotes/mjt/tags/pull-trivial-patches-2015-01-15:
  vl.c: fix some alignment issues
  blizzard: do not depend on VGA internals
  Makefile: Remove config.status and common.env during 'make distclean'
  target-openrisc: bugfix for dec_sys to decode instructions correctly
  Do not hang on full PTY
  misc: Fix new typos in comments
  target-arm: Fix typo in comment (seperately -> separately)
  target-tricore: Fix new typos
  migration/qemu-file.c: Don't shift left into sign bit
  translate-all: Mark map_exec() with the 'unused' attribute
  tests/hd-geo-test.c: Remove unused test_image variable
  vt82c686: avoid out-of-bounds read

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/b629a38a1374...df58887b20fa
reply via email to
[Prev in Thread] Current Thread [Next in Thread]