[Qemu-commits] [qemu/qemu] 0b2824: spice: use bottom half instead of refresh timer fo...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 0b2824e5e48a787be3edbfc897244b4621e5bd61
      
https://github.com/qemu/qemu/commit/0b2824e5e48a787be3edbfc897244b4621e5bd61
  Author: Gerd Hoffmann <address@hidden>
  Date:   2014-12-16 (Tue, 16 Dec 2014)

  Changed paths:
    M hw/display/qxl-render.c
    M hw/display/qxl.c
    M include/ui/spice-display.h
    M ui/spice-display.c

  Log Message:
  -----------
  spice: use bottom half instead of refresh timer for cursor updates

Calling directly doesn't work due to the qxl-render code running in
spice server thread context.  Meanwhile bottom half scheduling is
thread-safe though, so we can use that to kick a cursor update in
main i/o thread context.

Cc: Marc-André Lureau <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 3dcadce5076d4b42fa395c39662d65e050b77784
      
https://github.com/qemu/qemu/commit/3dcadce5076d4b42fa395c39662d65e050b77784
  Author: Gerd Hoffmann <address@hidden>
  Date:   2014-12-16 (Tue, 16 Dec 2014)

  Changed paths:
    M hw/display/qxl.c

  Log Message:
  -----------
  spice: reduce refresh rate in native mode

Now that cursor updates are out of the way qxl needs the refresh timer
only when when running in vga mode, for dirty bitmap checking.  In
native qxl mode the guest will notify us, so we don't need to poll and
can use the idle interval (one refresh wakeup every few seconds).

Cc: Marc-André Lureau <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 555e72f2d02125766601db52c6380357b3820fcb
      
https://github.com/qemu/qemu/commit/555e72f2d02125766601db52c6380357b3820fcb
  Author: Gerd Hoffmann <address@hidden>
  Date:   2014-12-16 (Tue, 16 Dec 2014)

  Changed paths:
    M ui/spice-display.c

  Log Message:
  -----------
  spice: rework mirror allocation, add no-resize fast path

Add fast path to qemu_spice_display_switch in case old and new
displaysurface have identical size (happens with display panning
and page flipping).  We just swap the backing store then and don't
go through the whole process of deleting and creating the primary
surface.

To simplify the code a bit move mirror surface allocation to
qemu_spice_display_switch().

Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: cf7856adefebe86e0cd50302d93b3045e3111690
      
https://github.com/qemu/qemu/commit/cf7856adefebe86e0cd50302d93b3045e3111690
  Author: Marc-André Lureau <address@hidden>
  Date:   2014-12-16 (Tue, 16 Dec 2014)

  Changed paths:
    M ui/spice-core.c

  Log Message:
  -----------
  spice: do not require TCP ports

It is possible to use Spice server without TCP port.  On local VM,
qemu (and libvirt) can add new clients thanks to QMP add_client command.

Signed-off-by: Marc-André Lureau <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: e0883e2de0ef36f254acc274e80ddeac13a2a8f6
      
https://github.com/qemu/qemu/commit/e0883e2de0ef36f254acc274e80ddeac13a2a8f6
  Author: Marc-André Lureau <address@hidden>
  Date:   2014-12-16 (Tue, 16 Dec 2014)

  Changed paths:
    M spice-qemu-char.c
    M ui/spice-core.c

  Log Message:
  -----------
  spice: remove spice-experimental.h include

Nothing seems to be using functions from spice-experimental.h (better
that way). Let's remove its inclusion.

Signed-off-by: Marc-André Lureau <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: a41642708a5d1cbe8ad966227bbee1ed5eb421ad
      
https://github.com/qemu/qemu/commit/a41642708a5d1cbe8ad966227bbee1ed5eb421ad
  Author: Gonglei <address@hidden>
  Date:   2014-12-16 (Tue, 16 Dec 2014)

  Changed paths:
    M ui/spice-core.c

  Log Message:
  -----------
  spice: fix memory leak

If errors happen for middle items of channel_list,
qmp_query_spice_channels() returns NULL, and the variable
cur_item going out of scope leaks the storage it points to.

The flag is a compatibility thing for older spice-server
versions. Meanwhile our minimum spice version requirement is
new enough that we should never ever see this error, and if we
do something went very seriously wrong. Let's using assert()
instead of returning NULL to avoid a memory leak.

Suggested-by: Paolo Bonzini <address@hidden>
Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: d86fb03469e016af4e54f04efccbc20a8afa3e19
      
https://github.com/qemu/qemu/commit/d86fb03469e016af4e54f04efccbc20a8afa3e19
  Author: Peter Maydell <address@hidden>
  Date:   2014-12-16 (Tue, 16 Dec 2014)

  Changed paths:
    M hw/display/qxl-render.c
    M hw/display/qxl.c
    M include/ui/spice-display.h
    M spice-qemu-char.c
    M ui/spice-core.c
    M ui/spice-display.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/spice/tags/pull-spice-20141216-1' into 
staging

misc spice updates.

# gpg: Signature made Tue 16 Dec 2014 14:03:07 GMT using RSA key ID D3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"

* remotes/spice/tags/pull-spice-20141216-1:
  spice: fix memory leak
  spice: remove spice-experimental.h include
  spice: do not require TCP ports
  spice: rework mirror allocation, add no-resize fast path
  spice: reduce refresh rate in native mode
  spice: use bottom half instead of refresh timer for cursor updates

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/4db753b1ac4a...d86fb03469e0