[Qemu-commits] [qemu/qemu] 935fb9: QMP/input-send-event: update document of union Inp...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 935fb9152208fd98d99ffb91e719606b0c8e76b5
      
https://github.com/qemu/qemu/commit/935fb9152208fd98d99ffb91e719606b0c8e76b5
  Author: Amos Kong <address@hidden>
  Date:   2014-11-13 (Thu, 13 Nov 2014)

  Changed paths:
    M qapi-schema.json

  Log Message:
  -----------
  QMP/input-send-event: update document of union InputEvent

Signed-off-by: Amos Kong <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 51fc44768a5b71ad78fa40e609a58f71ed62775a
      
https://github.com/qemu/qemu/commit/51fc44768a5b71ad78fa40e609a58f71ed62775a
  Author: Amos Kong <address@hidden>
  Date:   2014-11-13 (Thu, 13 Nov 2014)

  Changed paths:
    M qapi-schema.json
    M qmp-commands.hx
    M ui/input.c

  Log Message:
  -----------
  QMP/input-send-event: make console parameter optional

The 'QemuConsole' is the input source for handler, we share some
input handlers to process the input events from different QemuConsole.

Normally we only have one set of keyboard, mouse, usbtablet, etc.
The devices have different mask, it's fine to just checking mask to
insure that the handler has the ability to process the event.

I saw we try to bind console to handler in usb/dev-hid.c, but display
always isn't available at that time.

If we have multiseat setup (as Gerd said), we only have 'problem' in
this case. Actually event from different devices have the same effect
for system, it's fine to always use the first available handler
without caring about the console.

For send-key command, we just pass a NULL for console parameter in
calling qemu_input_event_send_key(NULL, ..), but 'input-send-event'
needs to care more devices.

Conclusion:
Generally assigning the special console is meanless, and we can't
directly remove the QMP parameter for compatibility.

So we can make the parameter optional. The parameter might be useful
for some special condition: we have multiple devices without binding
console and they all have the ability(mask) to process events, and
we don't want to use the first one.

Cc: Gerd Hoffmann <address@hidden>
Cc: Markus Armbruster <address@hidden>
Cc: Marcelo Tosatti <address@hidden>
Signed-off-by: Amos Kong <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: e08d3004506e39cf25b3e1fa01f69bd1934d2846
      
https://github.com/qemu/qemu/commit/e08d3004506e39cf25b3e1fa01f69bd1934d2846
  Author: Peter Maydell <address@hidden>
  Date:   2014-11-13 (Thu, 13 Nov 2014)

  Changed paths:
    M qapi-schema.json
    M qmp-commands.hx
    M ui/input.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/pull-input-20141113-1' into 
staging

QMP/input-send-event: make console parameter optional

# gpg: Signature made Thu 13 Nov 2014 10:07:26 GMT using RSA key ID D3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"

* remotes/kraxel/tags/pull-input-20141113-1:
  QMP/input-send-event: make console parameter optional
  QMP/input-send-event: update document of union InputEvent

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/410bd787bf44...e08d3004506e