[Qemu-commits] [qemu/qemu] 7eb731: virtio-serial: avoid crash when port has no name

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 7eb7311427a6e2a9e080c1224f86a897f077282f
      
https://github.com/qemu/qemu/commit/7eb7311427a6e2a9e080c1224f86a897f077282f
  Author: Marc-André Lureau <address@hidden>
  Date:   2014-11-07 (Fri, 07 Nov 2014)

  Changed paths:
    M hw/char/virtio-serial-bus.c

  Log Message:
  -----------
  virtio-serial: avoid crash when port has no name

It seems "name" is not mandatory, and the following command line (based
on one generated by current libvirt) will crash qemu at start:

qemu-system-x86_64 \
    -device virtio-serial-pci \
    -device virtserialport,name=foo \
    -device virtconsole

Program received signal SIGSEGV, Segmentation fault.
__strcmp_ssse3 () at ../sysdeps/x86_64/strcmp.S:210
210        movlpd    (%rsi), %xmm2
Missing separate debuginfos, use: debuginfo-install
python-libs-2.7.5-13.fc20.x86_64
(gdb) bt
 #0  __strcmp_ssse3 () at ../sysdeps/x86_64/strcmp.S:210
 #1  0x000055555566bdc6 in find_port_by_name (name=0x0) at 
/home/elmarco/src/qemu/hw/char/virtio-serial-bus.c:67

Signed-off-by: Marc-André Lureau <address@hidden>
Reviewed-by: Amos Kong <address@hidden>
Signed-off-by: Amit Shah <address@hidden>


  Commit: 7b4b7c5fc7f25a161839802ca7d23f50f99e5174
      
https://github.com/qemu/qemu/commit/7b4b7c5fc7f25a161839802ca7d23f50f99e5174
  Author: Peter Maydell <address@hidden>
  Date:   2014-11-10 (Mon, 10 Nov 2014)

  Changed paths:
    M hw/char/virtio-serial-bus.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/amit/tags/vser-2.2.0-queue-2' into 
staging

Fixes a crash when a virtio-serial port is added without a name to it.

# gpg: Signature made Fri 07 Nov 2014 04:58:05 GMT using RSA key ID 854083B6
# gpg: Good signature from "Amit Shah <address@hidden>"
# gpg:                 aka "Amit Shah <address@hidden>"
# gpg:                 aka "Amit Shah <address@hidden>"

* remotes/amit/tags/vser-2.2.0-queue-2:
  virtio-serial: avoid crash when port has no name

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/6e76d125f244...7b4b7c5fc7f2