qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 43c95d: qdev: Create qdev_get_device_class()


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 43c95d: qdev: Create qdev_get_device_class() function
Date: Tue, 04 Nov 2014 11:00:07 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 43c95d782d6cc2297b6235d9ecb1f66f08e9928a
      
https://github.com/qemu/qemu/commit/43c95d782d6cc2297b6235d9ecb1f66f08e9928a
  Author: Eduardo Habkost <address@hidden>
  Date:   2014-11-04 (Tue, 04 Nov 2014)

  Changed paths:
    M qdev-monitor.c

  Log Message:
  -----------
  qdev: Create qdev_get_device_class() function

Extract the DeviceClass lookup from qdev_device_add() to a separate
function.

Signed-off-by: Eduardo Habkost <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 5185f0e0a6bb076cd1cd0115ef785298a97a71fe
      
https://github.com/qemu/qemu/commit/5185f0e0a6bb076cd1cd0115ef785298a97a71fe
  Author: Eduardo Habkost <address@hidden>
  Date:   2014-11-04 (Tue, 04 Nov 2014)

  Changed paths:
    M qdev-monitor.c

  Log Message:
  -----------
  qdev: Move error printing to the end of qdev_device_help()

Signed-off-by: Eduardo Habkost <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 31bed5509dfcbdfc293154ce81086a4dbd7a80b6
      
https://github.com/qemu/qemu/commit/31bed5509dfcbdfc293154ce81086a4dbd7a80b6
  Author: Eduardo Habkost <address@hidden>
  Date:   2014-11-04 (Tue, 04 Nov 2014)

  Changed paths:
    M qdev-monitor.c

  Log Message:
  -----------
  qdev: Use qdev_get_device_class() for -device <type>,help

Make sure we try to list properties from classes that can be safely used
with "-device".

Fixes the following crashes:

  $ qemu-system-x86_64 -device x86_64-cpu,help
  **
  ERROR:qom/object.c:336:object_initialize_with_type: assertion failed: 
(type->abstract == false)
  Aborted (core dumped)
  $ qemu-system-x86_64 -device host-x86_64-cpu,help
  qemu-system-x86_64: [...]/target-i386/cpu.c:1329: host_x86_cpu_initfn: 
Assertion `(kvm_allowed)' failed.
  Aborted (core dumped)

After applying this patch:

  $ qemu-system-x86_64 -device x86_64-cpu,help
  Parameter 'driver' expects non-abstract device type
  $ qemu-system-x86_64 -device host-x86_64-cpu,help
  Parameter 'driver' expects pluggable device type

Signed-off-by: Eduardo Habkost <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: d5b4dc3b50175f0c34f3cf4b053e123fb37f5aed
      
https://github.com/qemu/qemu/commit/d5b4dc3b50175f0c34f3cf4b053e123fb37f5aed
  Author: Peter Maydell <address@hidden>
  Date:   2014-11-04 (Tue, 04 Nov 2014)

  Changed paths:
    M qdev-monitor.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/afaerber/tags/qom-devices-for-peter' 
into staging

QOM infrastructure fixes and device conversions

* Fixes for -device foo,help

# gpg: Signature made Tue 04 Nov 2014 17:27:41 GMT using RSA key ID 3E7E013F
# gpg: Good signature from "Andreas Färber <address@hidden>"
# gpg:                 aka "Andreas Färber <address@hidden>"

* remotes/afaerber/tags/qom-devices-for-peter:
  qdev: Use qdev_get_device_class() for -device <type>,help
  qdev: Move error printing to the end of qdev_device_help()
  qdev: Create qdev_get_device_class() function

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/2bb41e5d307a...d5b4dc3b5017

reply via email to

[Prev in Thread] Current Thread [Next in Thread]