qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 400519: gtk: Grab accel_group from GtkDisplay


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 400519: gtk: Grab accel_group from GtkDisplayState
Date: Tue, 04 Nov 2014 08:00:07 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 400519d24a56636ef45d4137d0cc84aafe6f0ed8
      
https://github.com/qemu/qemu/commit/400519d24a56636ef45d4137d0cc84aafe6f0ed8
  Author: Cole Robinson <address@hidden>
  Date:   2014-11-04 (Tue, 04 Nov 2014)

  Changed paths:
    M ui/gtk.c

  Log Message:
  -----------
  gtk: Grab accel_group from GtkDisplayState

Rather than needlessly pass it around

Signed-off-by: Cole Robinson <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 954149146193a8acd592b3055a14aad122490127
      
https://github.com/qemu/qemu/commit/954149146193a8acd592b3055a14aad122490127
  Author: Cole Robinson <address@hidden>
  Date:   2014-11-04 (Tue, 04 Nov 2014)

  Changed paths:
    M ui/gtk.c

  Log Message:
  -----------
  gtk: Install fullscreen accelerator on toplevel window

Instead of installing it on the menu. This will be needed to keep the
fullscreen keyboard shortcut working when we hide the menu (in future
patches).

On gtk < 3.8, this has the unfortunate side effect of no longer listing
the key combo in the UI. We could manually change the label in that case,
but it will look visually out of place, and I'm not sure if anyone really
cares.

Signed-off-by: Cole Robinson <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 277836c82bc973b8a39849a0d3398bae4bc265de
      
https://github.com/qemu/qemu/commit/277836c82bc973b8a39849a0d3398bae4bc265de
  Author: Cole Robinson <address@hidden>
  Date:   2014-11-04 (Tue, 04 Nov 2014)

  Changed paths:
    M ui/gtk.c

  Log Message:
  -----------
  gtk: Install vc accelerators on parent window

So they are usable when we hide the menubar in upcoming patches. This
has the accelerator text caveat as the fullscreen bit in the previous
patch.

Signed-off-by: Cole Robinson <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: b0f3182064c4943b91d4089ff2ed2d3c2d389ac6
      
https://github.com/qemu/qemu/commit/b0f3182064c4943b91d4089ff2ed2d3c2d389ac6
  Author: Cole Robinson <address@hidden>
  Date:   2014-11-04 (Tue, 04 Nov 2014)

  Changed paths:
    M ui/gtk.c

  Log Message:
  -----------
  gtk: Hide the menubar when in fullscreen mode (lp 1294898)

In fullscreen mode, we attempt to shrink the menubar to 1 pixel in height,
so it takes up as little room as possible while still allowing us to use
the keyboard shortcuts for its various operations.

However this shrinking is disregarded on gtk3, so the entire menu bar is
visible, which isn't very pleasant. This patch hides the menu bar instead.

The side effect is that the only keyboard shortcuts that will work in this
mode are the ones that we explicitly register on the top level window and
not the menu bar. The previous patches changed the fullscreen and vc
shortcuts to work like that, which I think are the only ones that really
matter in for the fullscreen case.

https://bugs.launchpad.net/qemu/+bug/1294898
Signed-off-by: Cole Robinson <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: dc5201714684fa9bf993e7be5f12d5293e9793d4
      
https://github.com/qemu/qemu/commit/dc5201714684fa9bf993e7be5f12d5293e9793d4
  Author: Gerd Hoffmann <address@hidden>
  Date:   2014-11-04 (Tue, 04 Nov 2014)

  Changed paths:
    M ui/gtk.c

  Log Message:
  -----------
  gtk: add GDK_KEY_pause #define

Add pause key to the list of compatibility defines.
Fixes the build with older gtk versions.

Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 1bc8dae31baa8b02a1b8e70c3244232e03bbb3b2
      
https://github.com/qemu/qemu/commit/1bc8dae31baa8b02a1b8e70c3244232e03bbb3b2
  Author: Peter Maydell <address@hidden>
  Date:   2014-11-04 (Tue, 04 Nov 2014)

  Changed paths:
    M ui/gtk.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/pull-gtk-20141104-2' into 
staging

gtk: fix fullscreen with gtk3, fix build with older gtk2 versions.

# gpg: Signature made Tue 04 Nov 2014 13:42:09 GMT using RSA key ID D3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"

* remotes/kraxel/tags/pull-gtk-20141104-2:
  gtk: add GDK_KEY_pause #define
  gtk: Hide the menubar when in fullscreen mode (lp 1294898)
  gtk: Install vc accelerators on parent window
  gtk: Install fullscreen accelerator on toplevel window
  gtk: Grab accel_group from GtkDisplayState

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/45da08fa8a26...1bc8dae31baa

reply via email to

[Prev in Thread] Current Thread [Next in Thread]