[Qemu-commits] [qemu/qemu] f032cf: libcacard: introduce new vcard_emul_logout

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: f032cfab6158e981a6ea0c369c5366e654e668a6
      
https://github.com/qemu/qemu/commit/f032cfab6158e981a6ea0c369c5366e654e668a6
  Author: Ray Strode <address@hidden>
  Date:   2014-10-28 (Tue, 28 Oct 2014)

  Changed paths:
    M libcacard/vcard_emul.h
    M libcacard/vcard_emul_nss.c

  Log Message:
  -----------
  libcacard: introduce new vcard_emul_logout

vcard_emul_reset currently only logs NSS out, but there is a TODO
for potentially sending insertion/removal events when powering down
or powering up.

For clarity, this commit moves the current guts of vcard_emul_reset to
a new vcard_emul_logout function which will never send insertion/removal
events. The vcard_emul_reset function now just calls vcard_emul_logout,
but also retains its TODO for watching power state transitions and sending
insertion/removal events.

Signed-off-by: Ray Strode <address@hidden>
Reviewed-By: Robert Relyea <address@hidden>
Reviewed-By: Alon Levy <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 1223bc4cee3fcdbcb1f6a3ff4ff7a3ab1d875b8a
      
https://github.com/qemu/qemu/commit/1223bc4cee3fcdbcb1f6a3ff4ff7a3ab1d875b8a
  Author: Ray Strode <address@hidden>
  Date:   2014-10-28 (Tue, 28 Oct 2014)

  Changed paths:
    M libcacard/vcard.c

  Log Message:
  -----------
  libcacard: Lock NSS cert db when selecting an applet on an emulated card

When a process in a guest uses an emulated smartcard, libcacard running
on the host passes the PIN from the guest to the PK11_Authenticate NSS
function. The first time PK11_Authenticate is called the passed in PIN
is used to unlock the certificate database. Subsequent calls to
PK11_Authenticate will transparently succeed, regardless of the passed in
PIN. This is a convenience for applications provided by NSS.

Of course, the guest may have many applications using the one emulated
smart card all driven from the same host QEMU process.  That means if a
user enters the right PIN in one program in the guest, and then enters the
wrong PIN in another program in the guest, the wrong PIN will still
successfully unlock the virtual smartcard.

This commit forces the NSS certificate database to be locked anytime an
applet is selected on an emulated smartcard by calling vcard_emul_logout.

Signed-off-by: Ray Strode <address@hidden>
Reviewed-By: Robert Relyea <address@hidden>
Reviewed-By: Alon Levy <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 81b49e8f892a977f3821f3416ea51aa641d63ac4
      
https://github.com/qemu/qemu/commit/81b49e8f892a977f3821f3416ea51aa641d63ac4
  Author: Ray Strode <address@hidden>
  Date:   2014-10-28 (Tue, 28 Oct 2014)

  Changed paths:
    M libcacard/cac.c

  Log Message:
  -----------
  libcacard: don't free sign buffer while sign op is pending

commit 57f97834efe0c208ffadc9d2959f3d3d55580e52 cleaned up
the cac_applet_pki_process_apdu function to have a single
exit point. Unfortunately, that commit introduced a bug
where the sign buffer can get free'd and nullified while
it's still being used.

This commit corrects the bug by introducing a boolean to
track whether or not the sign buffer should be freed in
the function exit path.

Signed-off-by: Ray Strode <address@hidden>
Reviewed-by: Alon Levy <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 2aa6bfcb663c43775600a95719ef0c6b849188d0
      
https://github.com/qemu/qemu/commit/2aa6bfcb663c43775600a95719ef0c6b849188d0
  Author: Gerd Hoffmann <address@hidden>
  Date:   2014-10-28 (Tue, 28 Oct 2014)

  Changed paths:
    M hw/usb/hcd-xhci.c

  Log Message:
  -----------
  xhci: add property to turn on/off streams support

streams support in usb-redir and usb-host works only with recent enough
versions of the support libraries (libusbredir and libusbx).  Failure
mode is rather unelegant:  Any stream usb transfers will throw stall
errors.  Turning off support for streams in the xhci host controller
will work better as the guest can figure beforehand that streams are
not going to work.

Signed-off-by: Gerd Hoffmann <address@hidden>
Reviewed-by: Hans de Goede <address@hidden>


  Commit: a65e4ef90f0fb437b8e74e250a6f94aa4ecfa25c
      
https://github.com/qemu/qemu/commit/a65e4ef90f0fb437b8e74e250a6f94aa4ecfa25c
  Author: Gonglei <address@hidden>
  Date:   2014-10-28 (Tue, 28 Oct 2014)

  Changed paths:
    M hw/usb/hcd-uhci.c

  Log Message:
  -----------
  uhci: remove useless DEBUG

commit 50dcc0f8 (uhci: tracing support) had removed
DPRINTF, the DEBUG marco is useless now, remove it.

Signed-off-by: Gonglei <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: f33f43bd86beb94ae1be14a62dc89cbeb4a665bb
      
https://github.com/qemu/qemu/commit/f33f43bd86beb94ae1be14a62dc89cbeb4a665bb
  Author: Peter Maydell <address@hidden>
  Date:   2014-10-30 (Thu, 30 Oct 2014)

  Changed paths:
    M hw/usb/hcd-uhci.c
    M hw/usb/hcd-xhci.c
    M libcacard/cac.c
    M libcacard/vcard.c
    M libcacard/vcard_emul.h
    M libcacard/vcard_emul_nss.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/pull-usb-20141028-1' into 
staging

Fixes for libcacard (usb smartcard emulation), xhci and uhci.

# gpg: Signature made Tue 28 Oct 2014 10:39:52 GMT using RSA key ID D3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"

* remotes/kraxel/tags/pull-usb-20141028-1:
  uhci: remove useless DEBUG
  xhci: add property to turn on/off streams support
  libcacard: don't free sign buffer while sign op is pending
  libcacard: Lock NSS cert db when selecting an applet on an emulated card
  libcacard: introduce new vcard_emul_logout

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/3c1d9a15be67...f33f43bd86be