qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 22644c: virtio-balloon: Tweak recent fix for


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 22644c: virtio-balloon: Tweak recent fix for integer overf...
Date: Thu, 23 Oct 2014 11:30:07 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 22644cd2c60151a964d9505f4c5f7baf845f20d8
      
https://github.com/qemu/qemu/commit/22644cd2c60151a964d9505f4c5f7baf845f20d8
  Author: Markus Armbruster <address@hidden>
  Date:   2014-10-23 (Thu, 23 Oct 2014)

  Changed paths:
    M hw/virtio/virtio-balloon.c

  Log Message:
  -----------
  virtio-balloon: Tweak recent fix for integer overflow

Commit 1f9296b avoids "other kinds of overflow" by limiting the
polling interval to UINT_MAX.  The computations to protect are done in
64 bits.  This is indeed safe when unsigned is 32 bits, as it commonly
is.  It isn't when unsigned is 64 bits.  Purely theoretical; I'm not
aware of such a system.  Limit it to UINT32_MAX instead.

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 37917da2d071ab5273703f5169b0b2fefd40cbb5
      
https://github.com/qemu/qemu/commit/37917da2d071ab5273703f5169b0b2fefd40cbb5
  Author: zhanghailiang <address@hidden>
  Date:   2014-10-23 (Thu, 23 Oct 2014)

  Changed paths:
    M dump.c

  Log Message:
  -----------
  dump: Propagate errors into qmp_dump_guest_memory()

The code calls dump_error() on error, and even passes it a suitable
message.  However, the message is thrown away, and its callers pass
up only success/failure.  All qmp_dump_guest_memory() can do is set
a generic error.

Propagate the errors properly, so qmp_dump_guest_memory() can return
a more useful error.

Signed-off-by: zhanghailiang <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 4c7e251ae6d9c328850d62d8aeafa14ca600c858
      
https://github.com/qemu/qemu/commit/4c7e251ae6d9c328850d62d8aeafa14ca600c858
  Author: zhanghailiang <address@hidden>
  Date:   2014-10-23 (Thu, 23 Oct 2014)

  Changed paths:
    M dump.c

  Log Message:
  -----------
  dump: Turn some functions to void to make code cleaner

Functions shouldn't return an error code and an Error object at the same time.
Turn all these functions that returning Error object to void.
We also judge if a function success or fail by reference to the local_err.

Signed-off-by: zhanghailiang <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: f3582ba41c22bfa39fae0c771d943e8c28a7936c
      
https://github.com/qemu/qemu/commit/f3582ba41c22bfa39fae0c771d943e8c28a7936c
  Author: Luiz Capitulino <address@hidden>
  Date:   2014-10-23 (Thu, 23 Oct 2014)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  MAINTAINERS: add entry for qobject files

Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 66e56b13ad432cdb51b3319476fbb4746af5770b
      
https://github.com/qemu/qemu/commit/66e56b13ad432cdb51b3319476fbb4746af5770b
  Author: Zhu Guihua <address@hidden>
  Date:   2014-10-23 (Thu, 23 Oct 2014)

  Changed paths:
    M hw/core/qdev.c
    M include/hw/qdev-core.h

  Log Message:
  -----------
  qdev: add qdev_build_hotpluggable_device_list helper

For peripheral device del completion, add a function to build a list for
hotpluggable devices.

Signed-off-by: Zhu Guihua <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 6a1fa9f5a62937a8552dbc380c5418c696bf7762
      
https://github.com/qemu/qemu/commit/6a1fa9f5a62937a8552dbc380c5418c696bf7762
  Author: Zhu Guihua <address@hidden>
  Date:   2014-10-23 (Thu, 23 Oct 2014)

  Changed paths:
    M monitor.c

  Log Message:
  -----------
  monitor: add del completion for peripheral device

Add peripheral_device_del_completion() to let peripheral device del completion
be possible.

Signed-off-by: Zhu Guihua <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: e799157c766d96506214059d8b75712a3e615431
      
https://github.com/qemu/qemu/commit/e799157c766d96506214059d8b75712a3e615431
  Author: Zhu Guihua <address@hidden>
  Date:   2014-10-23 (Thu, 23 Oct 2014)

  Changed paths:
    M monitor.c

  Log Message:
  -----------
  monitor: delete device_del_bus_completion

device_del_bus_completion() that gathers devices from buses is unused; delete
it.

Signed-off-by: Zhu Guihua <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 1430500bb8ba0bf15bad235439d62276c1b6b22f
      
https://github.com/qemu/qemu/commit/1430500bb8ba0bf15bad235439d62276c1b6b22f
  Author: Peter Maydell <address@hidden>
  Date:   2014-10-23 (Thu, 23 Oct 2014)

  Changed paths:
    M MAINTAINERS
    M dump.c
    M hw/core/qdev.c
    M hw/virtio/virtio-balloon.c
    M include/hw/qdev-core.h
    M monitor.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/qmp-unstable/tags/for-upstream' into 
staging

QMP patches

# gpg: Signature made Thu 23 Oct 2014 16:05:52 BST using RSA key ID E24ED5A7
# gpg: Good signature from "Luiz Capitulino <address@hidden>"

* remotes/qmp-unstable/tags/for-upstream:
  monitor: delete device_del_bus_completion
  monitor: add del completion for peripheral device
  qdev: add qdev_build_hotpluggable_device_list helper
  MAINTAINERS: add entry for qobject files
  dump: Turn some functions to void to make code cleaner
  dump: Propagate errors into qmp_dump_guest_memory()
  virtio-balloon: Tweak recent fix for integer overflow

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/e40830afa1cf...1430500bb8ba

reply via email to

[Prev in Thread] Current Thread [Next in Thread]