[Qemu-commits] [qemu/qemu] 9e5a25: qxl: keep going if reaching guest bug on empty are...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 9e5a25f1c209ff51e4b65124a3b76dd3f1b0fb49
      
https://github.com/qemu/qemu/commit/9e5a25f1c209ff51e4b65124a3b76dd3f1b0fb49
  Author: Marc-André Lureau <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/display/qxl.c

  Log Message:
  -----------
  qxl: keep going if reaching guest bug on empty area

Xorg server hangs when using xfig and typing a text with space:
 #0  qxl_wait_for_io_command (qxl=<value optimized out>) at qxl_io.c:47
 #1  0x00007f826a49a299 in qxl_download_box (surface=0x221d030, x1=231, y1=259,
     x2=<value optimized out>, y2=<value optimized out>) at qxl_surface.c:143
  while (!(ram_header->int_pending & QXL_INTERRUPT_IO_CMD))
   usleep (1);

The QXL driver is calling QXL_IO_UPDATE_AREA with an empty area. This
is a guest bug. The call is async and no ack is sent back on guest
bug, so the X server will hang. The driver should be improved to avoid
this situation and also to abort on QXL_INTERRUPT_ERROR. This will be
a different patch series for the driver. However, it is simple enough
to keep qemu running on empty areas update, which is what this patch
provides.

https://bugzilla.redhat.com/show_bug.cgi?id=1151363

Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 19f377299518d4f68b2b9e983d90bd1382da0460
      
https://github.com/qemu/qemu/commit/19f377299518d4f68b2b9e983d90bd1382da0460
  Author: Peter Maydell <address@hidden>
  Date:   2014-10-22 (Wed, 22 Oct 2014)

  Changed paths:
    M hw/display/qxl.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/spice/tags/pull-spice-20141015-1' into 
staging

qxl: keep going if reaching guest bug on empty area

# gpg: Signature made Wed 15 Oct 2014 11:45:37 BST using RSA key ID D3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"

* remotes/spice/tags/pull-spice-20141015-1:
  qxl: keep going if reaching guest bug on empty area

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/4b4ce6c2b85c...19f377299518