[Qemu-commits] [qemu/qemu] b235a7: qdev: gpio: Don't allow name share be

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] b235a7: qdev: gpio: Don't allow name share be

From:	GitHub
Subject:	[Qemu-commits] [qemu/qemu] b235a7: qdev: gpio: Don't allow name share between I and O
Date:	Wed, 15 Oct 2014 03:30:08 -0700
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: b235a71f52f60d42dd69c4ac2e41fa5a5861cf85
      
https://github.com/qemu/qemu/commit/b235a71f52f60d42dd69c4ac2e41fa5a5861cf85
  Author: Peter Crosthwaite <address@hidden>
  Date:   2014-10-13 (Mon, 13 Oct 2014)

  Changed paths:
    M hw/core/qdev.c

  Log Message:
  -----------
  qdev: gpio: Don't allow name share between I and O

Only allow a GPIO name to be one or the other. Inputs and outputs are
functionally different and should be in different namespaces. Prepares
support for the QOMification of IRQs as Links or Child objects.

The alternative is to munge names .e.g. with "-in" or "-out" suffixes
when giving QOM names. But that reduces clarity and if there are cases
out there where users want I and O with same name they can manually add
their own suffixes.

Reviewed-by: Alexander Graf <address@hidden>
Signed-off-by: Peter Crosthwaite <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: a69bef1cf12159233b0ba193bd9dc9b173cea453
      
https://github.com/qemu/qemu/commit/a69bef1cf12159233b0ba193bd9dc9b173cea453
  Author: Peter Crosthwaite <address@hidden>
  Date:   2014-10-13 (Mon, 13 Oct 2014)

  Changed paths:
    M hw/core/qdev.c

  Log Message:
  -----------
  qdev: gpio: Register GPIO inputs as child objects

To the device that contains them. This will allow for referencing
a GPIO input from it's canonical path (exciting for dynamic machine
generation!)

Reviewed-by: Alexander Graf <address@hidden>
Signed-off-by: Peter Crosthwaite <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 688b057aece53003f9d5a1dadc8961482dc2d948
      
https://github.com/qemu/qemu/commit/688b057aece53003f9d5a1dadc8961482dc2d948
  Author: Peter Crosthwaite <address@hidden>
  Date:   2014-10-13 (Mon, 13 Oct 2014)

  Changed paths:
    M hw/core/qdev.c

  Log Message:
  -----------
  qdev: gpio: Register GPIO outputs as QOM links

Within the object that contains the GPIO output. This allows for
connecting GPIO outputs via setting of a Link property.

Also clear the link value to zero. This catch-alls the case
where a device improperly inits a gpio_out (malloc instead of
malloc0).

Reviewed-by: Alexander Graf <address@hidden>
Signed-off-by: Peter Crosthwaite <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 3a53009fa044a554dbdeacf30a6b8ea3eb02fe63
      
https://github.com/qemu/qemu/commit/3a53009fa044a554dbdeacf30a6b8ea3eb02fe63
  Author: Gonglei <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M qom/object.c

  Log Message:
  -----------
  qom: Add error handler for object_property_print()

Avoid the caller of object_property_print() leaking string
argument's memory, such as qdev_print_props() when
encounter errors.

Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Gonglei <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 8ae9a9ef4e610a58d0748f5aa7dd144b08e09039
      
https://github.com/qemu/qemu/commit/8ae9a9ef4e610a58d0748f5aa7dd144b08e09039
  Author: Gonglei <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M qom/object.c

  Log Message:
  -----------
  qom: Add error handler for object alias property

object_property_add_alias() is called at some
places at present. And its parameter errp may not NULL,
such as
 object_property_add_alias(obj, "iothread", OBJECT(&dev->vdev),"iothread",
                        &error_abort);
This patch add error handler for security.

Cc: Stefan Hajnoczi <address@hidden>
Cc: Michael S. Tsirkin <address@hidden>
Cc: Markus Armbruster <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Gonglei <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: ac2c4946ccc62e0c3eabd93206134f9e98db75c9
      
https://github.com/qemu/qemu/commit/ac2c4946ccc62e0c3eabd93206134f9e98db75c9
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M tests/virtio-scsi-test.c

  Log Message:
  -----------
  tests: virtio-scsi: Check if hot-plug/unplug works

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 823a9987c99da3d2ee6249730f6cf5c4dcdc15cc
      
https://github.com/qemu/qemu/commit/823a9987c99da3d2ee6249730f6cf5c4dcdc15cc
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M tests/virtio-serial-test.c

  Log Message:
  -----------
  tests: virtio-serial: Check if hot-plug/unplug works

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 2f8b2767203a73814b3c3c386e3ed74cd0b5a32e
      
https://github.com/qemu/qemu/commit/2f8b2767203a73814b3c3c386e3ed74cd0b5a32e
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M tests/libqos/pci-pc.c
    M tests/libqos/pci.h

  Log Message:
  -----------
  libqos: Add qpci_plug_device_test() and qpci_unplug_acpi_device_test()

Functions will be used for testing hot(un)plug of PCI devices.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: d1f3fc24f8c0fd193929eb4303d2768241d18a95
      
https://github.com/qemu/qemu/commit/d1f3fc24f8c0fd193929eb4303d2768241d18a95
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M tests/Makefile
    M tests/virtio-rng-test.c

  Log Message:
  -----------
  tests: virtio-rng: Check if hot-plug/unplug works

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 9224709b7bde6d6a81fad4c1aa2c2479cf840a60
      
https://github.com/qemu/qemu/commit/9224709b7bde6d6a81fad4c1aa2c2479cf840a60
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M tests/Makefile
    M tests/virtio-net-test.c

  Log Message:
  -----------
  tests: virtio-net: Check if hot-plug/unplug works

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: aaf36070510cd95f8d77ec208fda8a555b507a1d
      
https://github.com/qemu/qemu/commit/aaf36070510cd95f8d77ec208fda8a555b507a1d
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M tests/virtio-blk-test.c

  Log Message:
  -----------
  tests: virtio-blk: Check if hot-plug/unplug works

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: b0354ec59640a23c3be544d904400e38be8ff51d
      
https://github.com/qemu/qemu/commit/b0354ec59640a23c3be544d904400e38be8ff51d
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M tests/Makefile
    A tests/libqos/usb.c
    A tests/libqos/usb.h
    M tests/usb-hcd-ehci-test.c

  Log Message:
  -----------
  tests: usb: Move uhci port test code to libqos/usb.c

Move code necessary for testing uhci port into library
so it could be used by other USB tests.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: fbd942c993001f5276fcd1f25a56405fdd968472
      
https://github.com/qemu/qemu/commit/fbd942c993001f5276fcd1f25a56405fdd968472
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M tests/Makefile
    M tests/usb-hcd-uhci-test.c

  Log Message:
  -----------
  tests: usb: add port test to uhci unit test

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: b3937683147481fba3406a01da4ce15f0b2deb21
      
https://github.com/qemu/qemu/commit/b3937683147481fba3406a01da4ce15f0b2deb21
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M tests/Makefile
    M tests/libqos/usb.c
    M tests/libqos/usb.h
    M tests/usb-hcd-ehci-test.c
    M tests/usb-hcd-ohci-test.c
    M tests/usb-hcd-uhci-test.c
    M tests/usb-hcd-xhci-test.c

  Log Message:
  -----------
  tests: usb: Generic usb device hotplug

use usb-tablet as a hotplugged usb device.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: b6ca82feedbf341af42ffaf6241a850443d853ae
      
https://github.com/qemu/qemu/commit/b6ca82feedbf341af42ffaf6241a850443d853ae
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M tests/usb-hcd-uhci-test.c

  Log Message:
  -----------
  tests: usb: usb-storage hotplug test

usb-storage is different from usual usb devices
in that it uses a child SCSI bus for underlying storage.
This commit verifies that the SCSI bus is hotpluggable, as
hotplug operation wouldn't succeed without it.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 49cec38591d6fef833cf12873fb4ff9748d0f08b
      
https://github.com/qemu/qemu/commit/49cec38591d6fef833cf12873fb4ff9748d0f08b
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M tests/usb-hcd-xhci-test.c

  Log Message:
  -----------
  tests: usb: usb-uas hotplug test

checks that it's possible to hotplug usb-uas HBA and
then if it's possible to hot(un)plug scsi-disk to it.
Thest basically covers hot(un)plug on dummy HBAs
without means of hot(un)plug notification of the guest.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 39b888bd88296b178082b5a2e4c6e82fcbd877f8
      
https://github.com/qemu/qemu/commit/39b888bd88296b178082b5a2e4c6e82fcbd877f8
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/core/qdev.c
    M hw/i386/acpi-build.c
    M hw/pci/pci-hotplug-old.c
    M include/hw/qdev-core.h
    M qdev-monitor.c

  Log Message:
  -----------
  Access BusState::allow_hotplug using wraper qbus_is_hotpluggable()

It would allow to transparently switch detection whether Bus
is hotpluggable from allow_hotplug field to hotplug_handler
link and to drop allow_hotplug field once all users are
converted to hotplug handler API.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: ce9835e00df65bf5beb6c094c0865d8e60018310
      
https://github.com/qemu/qemu/commit/ce9835e00df65bf5beb6c094c0865d8e60018310
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M qdev-monitor.c

  Log Message:
  -----------
  qdev: do not allow to instantiate non hotpluggable device with device_add

It will allow explicitly mark device as not hotpluggable and
avoid its creation with following error at realize time
and destroying it afterwards anyway. Instead of it will
error out even before instance of device is created.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 14d5a28fb6bb8ac6505ad1faca2690df56fef326
      
https://github.com/qemu/qemu/commit/14d5a28fb6bb8ac6505ad1faca2690df56fef326
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/acpi/piix4.c
    M hw/core/hotplug.c
    M hw/core/qdev.c
    M hw/isa/lpc_ich9.c
    M hw/pci-bridge/pci_bridge_dev.c
    M hw/pci/pcie.c
    M hw/pci/pcie_port.c
    M hw/pci/shpc.c
    M include/hw/hotplug.h
    M include/hw/pci/pcie.h
    M include/hw/pci/shpc.h

  Log Message:
  -----------
  qdev: HotplugHandler: Rename unplug callback to unplug_request

'HotplugHandler.unplug' callback is currently used as async
call to issue unplug request for device that implements it.
Renaming 'unplug' callback to 'unplug_request' should help to
avoid confusion about what callback does and would allow to
introduce 'unplug' callback that would perform actual device
removal when guest is ready for it.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 181a2c63236966b3c80eef131bac33a355a492da
      
https://github.com/qemu/qemu/commit/181a2c63236966b3c80eef131bac33a355a492da
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/core/hotplug.c
    M hw/core/qdev.c
    M include/hw/hotplug.h

  Log Message:
  -----------
  qdev: HotplugHandler: Provide unplug callback

It is to be called for actual device removal and
will allow to separate request and removal handling
phases of x86-CPU devices and also it's a handler
to be called for synchronously removable devices.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 014176f914ab8e41a88225e8f26569ef0e0bf223
      
https://github.com/qemu/qemu/commit/014176f914ab8e41a88225e8f26569ef0e0bf223
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/core/qdev.c
    M include/hw/qdev-core.h

  Log Message:
  -----------
  qdev: Add simple/generic unplug callback for HotplugHandler

It will be used in shallow conversion from legacy hotplug
mechanism and eventually replace all the uses of old mechanism
DeviceClass::unplug = qdev_simple_unplug_cb()

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 431bbb26cbd0e9862c48320deaaf83aa9aacd6ce
      
https://github.com/qemu/qemu/commit/431bbb26cbd0e9862c48320deaaf83aa9aacd6ce
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/core/qdev.c
    M include/hw/qdev-core.h

  Log Message:
  -----------
  qdev: Add wrapper to set BUS as HotplugHandler

To be used for conversion of SCSI and USB devices,
and would allow to make every HBA/USB host switch
to HotplugHandler API without touching each controller
explicitly.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: e378acb4047fbec4f89031dbba7fb7851042f6ee
      
https://github.com/qemu/qemu/commit/e378acb4047fbec4f89031dbba7fb7851042f6ee
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/core/qdev.c

  Log Message:
  -----------
  qdev: Drop hotplug check from bus_add_child()

Check is too restrictive and does not allow
to add children to just created bus during hotplug
when the bus is part of composite device.

Removing check from bus_add_child() doesn't affect
devices creatable with device_add/del commands since
they have a similar builtin check and patch will
allow to create complex composite devices during
hotplug.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: c32e36f6ab847e0726542a822606a3525f959ff4
      
https://github.com/qemu/qemu/commit/c32e36f6ab847e0726542a822606a3525f959ff4
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/cpu/icc_bus.c

  Log Message:
  -----------
  target-i386: ICC bus: Drop BusState::allow_hotplug

Since bus_add_child() no longer cares if BUS is hotpluggable
or not, there is no need in setting allow_hotplug field.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 7f17a917150abb38221d32a35398527b3e9a87cb
      
https://github.com/qemu/qemu/commit/7f17a917150abb38221d32a35398527b3e9a87cb
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/virtio/virtio-pci.c

  Log Message:
  -----------
  virtio-pci: Drop BusState::allow_hotplug

virtio-pci-bus is an internal object of composite
virtio-pci device and it doesn't participate in
-device/device_add hotplug flow, and since it's
not required by bus_add_child() that BUS must
be hotpluggable to be able to add child at runtime,
it's possible to drop not needed 'allow_hotplug'
field.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 0ddef15b0432fbcb65429e17b32231e18aa103c9
      
https://github.com/qemu/qemu/commit/0ddef15b0432fbcb65429e17b32231e18aa103c9
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/char/virtio-serial-bus.c

  Log Message:
  -----------
  virtio-serial: Convert to hotplug-handler API

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 2f4f60351782c22744ae7c7de6afcefbe66f28a4
      
https://github.com/qemu/qemu/commit/2f4f60351782c22744ae7c7de6afcefbe66f28a4
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/virtio/virtio-mmio.c

  Log Message:
  -----------
  virtio-mmio: Drop useless bus->allow_hotplug = 0

Bus by default is not hotpluggable.
virtio-mmio-bus and its parent types do not set allow_hotplug
anywhere explicitly, so remove not needed field access
and wrapper along with it.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 492bcf8f711cfd1f1056b0a7cff768a6a5f387ee
      
https://github.com/qemu/qemu/commit/492bcf8f711cfd1f1056b0a7cff768a6a5f387ee
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/s390x/event-facility.c

  Log Message:
  -----------
  s390x: Drop not used allow_hotplug in event-facility

s390-sclp-event-facility creates s390-sclp-events-bus
and immediately sets its allow_hotplug field to 0,
which is NOP since it's already 0 by default.

Also since BUS is not hotpluggable, it's not possible
to call SCLP_EVENT{ DeviceClass::unplug } callback
from qdev_unplug() making this unreachable code,
so drop it as well.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: e98f8c36222d2d6574a137ebb452fb35c59ad697
      
https://github.com/qemu/qemu/commit/e98f8c36222d2d6574a137ebb452fb35c59ad697
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/s390x/s390-virtio-bus.c

  Log Message:
  -----------
  s390x: Convert s390-virtio to hotplug handler API

Beside of conversion, patch drops present unplug
handling, effectively disabling hot-unplug of
s390-virtio devices.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 277bc95ed31c2db08c5e3662e1dcebaf27cb5150
      
https://github.com/qemu/qemu/commit/277bc95ed31c2db08c5e3662e1dcebaf27cb5150
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/s390x/virtio-ccw.c

  Log Message:
  -----------
  s390x: Convert virtio-ccw to hotplug handler API

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: bddd763a4e43213ba4e003ee2f8afb4f1222ec88
      
https://github.com/qemu/qemu/commit/bddd763a4e43213ba4e003ee2f8afb4f1222ec88
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/scsi/scsi-bus.c

  Log Message:
  -----------
  scsi: Set SCSI BUS itself as default HotplugHandler

That would allow to handle SCSI device unplug
on HBAs without dedicated hot(un)plug handlers
and avoid making such HBAs explicitly hotpluggable.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 91c8daad4b66cebe5cecc799c988bed215cd791c
      
https://github.com/qemu/qemu/commit/91c8daad4b66cebe5cecc799c988bed215cd791c
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/scsi/vmw_pvscsi.c

  Log Message:
  -----------
  scsi: Convert pvscsi HBA to hotplug handler API

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 02206e5275ee1e34b2adf177c05aadec56af4bf8
      
https://github.com/qemu/qemu/commit/02206e5275ee1e34b2adf177c05aadec56af4bf8
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/scsi/virtio-scsi.c

  Log Message:
  -----------
  scsi: Convert virtio-scsi HBA to hotplug handler API

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 10bdcd565992e17f0b4f04e0b28793b169e51a26
      
https://github.com/qemu/qemu/commit/10bdcd565992e17f0b4f04e0b28793b169e51a26
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/scsi/scsi-bus.c
    M include/hw/scsi/scsi.h

  Log Message:
  -----------
  scsi: Cleanup not used anymore SCSIBusInfo{hotplug, hot_unplug} fields

SCSI subsytem was converted to hotplug handler API and
doesn't use SCSIBusInfo{hotplug, hot_unplug} fields and
related callbacks anymore.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: e9fd12aa0dd734f1e3725d93a0afa8721fab3bd2
      
https://github.com/qemu/qemu/commit/e9fd12aa0dd734f1e3725d93a0afa8721fab3bd2
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/usb/dev-storage.c

  Log Message:
  -----------
  usb-bot: Mark device as non hotpluggable

usb-bot creates SCSI bus and immediately makes it
non hotpluggable which was making not possible to
hotplug usb-bot since QEMU would abort at
bus_add_child(scsi-hd) time when usb-bot is
realized.

Mark usb-bot as not hotpluggable so that attempt
to hotplug it would error out even before it gets
to device initialization point.

Signed-off-by: Igor Mammedov <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: af01492755b82ccaf0d15014477b34ba3ea643fc
      
https://github.com/qemu/qemu/commit/af01492755b82ccaf0d15014477b34ba3ea643fc
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/usb/dev-storage.c

  Log Message:
  -----------
  usb-bot: Drop not needed "allow_hotplug = 0"

Drop useless hack that disables hotplug on bus by setting
"allow_hotplug = 0". Even if bus is hotpluggable, It won't
be possible to add another SCSI device to bus since its
realization will fail early with error "no free target"
in scsi_qdev_realize() method.

Signed-off-by: Igor Mammedov <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 77de4a09c6d3d1e4fabcc0eb6cfdb9ea5a1616d5
      
https://github.com/qemu/qemu/commit/77de4a09c6d3d1e4fabcc0eb6cfdb9ea5a1616d5
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/usb/dev-storage.c

  Log Message:
  -----------
  usb-storage: Drop not needed "allow_hotplug = 0"

Drop useless hack that disables hotplug on bus, after backend
storage was added to it, by setting "allow_hotplug = 0". Even
if bus is hotpluggable, it won't be possible to add another
SCSI device to bus since its realize will fail early with
error "no free target" in scsi_qdev_realize() method.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 138d587afbf17dc6ef42106f0dd0de9ae707b81c
      
https://github.com/qemu/qemu/commit/138d587afbf17dc6ef42106f0dd0de9ae707b81c
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/usb/dev-smartcard-reader.c

  Log Message:
  -----------
  usb: Convert usb-ccid to hotplug handler API

Signed-off-by: Igor Mammedov <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 5f4d917376fef99fe7f2e978b404cddc41727fa4
      
https://github.com/qemu/qemu/commit/5f4d917376fef99fe7f2e978b404cddc41727fa4
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/usb/bus.c

  Log Message:
  -----------
  usb: Convert usb devices to hotplug handler API

Signed-off-by: Igor Mammedov <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 2d9a982f37cc7c427d655a828c5ffa3cc5753863
      
https://github.com/qemu/qemu/commit/2d9a982f37cc7c427d655a828c5ffa3cc5753863
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/core/qdev.c
    M include/hw/qdev-core.h

  Log Message:
  -----------
  qdev: Drop legacy hotplug fields/methods

It removes not needed anymore BusState::allow_hotplug field and
DeviceClass::unplug callback.

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 7716b8ca7479dec146062c97453dd38e505a5ab4
      
https://github.com/qemu/qemu/commit/7716b8ca7479dec146062c97453dd38e505a5ab4
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/core/qdev.c

  Log Message:
  -----------
  qdev: HotplugHandler: Add support for unplugging BUS-less devices

Signed-off-by: Igor Mammedov <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: b6cc36abb20a54a30fbd7d0ae98066df6c5adabc
      
https://github.com/qemu/qemu/commit/b6cc36abb20a54a30fbd7d0ae98066df6c5adabc
  Author: Igor Mammedov <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M qdev-monitor.c

  Log Message:
  -----------
  qdev: device_del: Search for to be unplugged device in 'peripheral' container

device_add puts every device with 'id' inside of 'peripheral'
container using id's value as the last component name.
Use it by replacing recursive search on sysbus with path
lookup in 'peripheral' container, which could handle both
BUS and BUS-less device cases.

Signed-off-by: Igor Mammedov <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 51b2e8c331c1e3de5463bd7fe13676c2a9ec52fe
      
https://github.com/qemu/qemu/commit/51b2e8c331c1e3de5463bd7fe13676c2a9ec52fe
  Author: Gonglei <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/core/qdev-properties-system.c
    M hw/core/qdev-properties.c
    M include/hw/qdev-core.h
    M target-ppc/translate_init.c

  Log Message:
  -----------
  qdev: Add description field in PropertyInfo struct

The descriptions can serve as documentation in the code,
and they can be used to provide better help.

Cc: Markus Armbruster <address@hidden>
Signed-off-by: Gonglei <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 8074264203db3351a4017ea0371c2c5eeb86df82
      
https://github.com/qemu/qemu/commit/8074264203db3351a4017ea0371c2c5eeb86df82
  Author: Gonglei <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M include/qom/object.h
    M qom/object.c

  Log Message:
  -----------
  qom: Add description field in ObjectProperty struct

The descriptions can serve as documentation in the code,
and they can be used to provide better help.

Copy property descriptions when copying alias properties.

Cc: Markus Armbruster <address@hidden>
Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: b8c9cd5c8cf2a105dab8ac3e5799e3b27bfda9d5
      
https://github.com/qemu/qemu/commit/b8c9cd5c8cf2a105dab8ac3e5799e3b27bfda9d5
  Author: Gonglei <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/core/qdev.c

  Log Message:
  -----------
  qdev: Set the object property's description to the qdev property's.

Set all static qdev properties' descriptions to object property's
description.

Cc: Markus Armbruster <address@hidden>
Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 07d09c58dbbb9e3c6f6d06e5a27b23531f84a6f6
      
https://github.com/qemu/qemu/commit/07d09c58dbbb9e3c6f6d06e5a27b23531f84a6f6
  Author: Gonglei <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M qapi-schema.json
    M qdev-monitor.c
    M qmp.c

  Log Message:
  -----------
  qmp: Print descriptions of object properties

Add a new "description" field to DevicePropertyInfo.
The descriptions can serve as documentation in the code,
and they can be used to provide better help. For example:

$./qemu-system-x86_64 -device virtio-blk-pci,?

Before this patch:

virtio-blk-pci.iothread=link<iothread>
virtio-blk-pci.x-data-plane=bool
virtio-blk-pci.scsi=bool
virtio-blk-pci.config-wce=bool
virtio-blk-pci.serial=str
virtio-blk-pci.secs=uint32
virtio-blk-pci.heads=uint32
virtio-blk-pci.cyls=uint32
virtio-blk-pci.discard_granularity=uint32
virtio-blk-pci.bootindex=int32
virtio-blk-pci.opt_io_size=uint32
virtio-blk-pci.min_io_size=uint16
virtio-blk-pci.physical_block_size=uint16
virtio-blk-pci.logical_block_size=uint16
virtio-blk-pci.drive=str
virtio-blk-pci.virtio-backend=child<virtio-blk-device>
virtio-blk-pci.command_serr_enable=on/off
virtio-blk-pci.multifunction=on/off
virtio-blk-pci.rombar=uint32
virtio-blk-pci.romfile=str
virtio-blk-pci.addr=pci-devfn
virtio-blk-pci.event_idx=on/off
virtio-blk-pci.indirect_desc=on/off
virtio-blk-pci.vectors=uint32
virtio-blk-pci.ioeventfd=on/off
virtio-blk-pci.class=uint32

After:

virtio-blk-pci.iothread=link<iothread>
virtio-blk-pci.x-data-plane=bool (on/off)
virtio-blk-pci.scsi=bool (on/off)
virtio-blk-pci.config-wce=bool (on/off)
virtio-blk-pci.serial=str
virtio-blk-pci.secs=uint32
virtio-blk-pci.heads=uint32
virtio-blk-pci.cyls=uint32
virtio-blk-pci.discard_granularity=uint32
virtio-blk-pci.bootindex=int32
virtio-blk-pci.opt_io_size=uint32
virtio-blk-pci.min_io_size=uint16
virtio-blk-pci.physical_block_size=uint16 (A power of two between 512 and 32768)
virtio-blk-pci.logical_block_size=uint16 (A power of two between 512 and 32768)
virtio-blk-pci.drive=str (ID of a drive to use as a backend)
virtio-blk-pci.virtio-backend=child<virtio-blk-device>
virtio-blk-pci.command_serr_enable=bool (on/off)
virtio-blk-pci.multifunction=bool (on/off)
virtio-blk-pci.rombar=uint32
virtio-blk-pci.romfile=str
virtio-blk-pci.addr=int32 (Slot and optional function number, example: 06.0 or 
06)
virtio-blk-pci.event_idx=bool (on/off)
virtio-blk-pci.indirect_desc=bool (on/off)
virtio-blk-pci.vectors=uint32
virtio-blk-pci.ioeventfd=bool (on/off)
virtio-blk-pci.class=uint32

Cc: Markus Armbruster <address@hidden>
Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 18b91a3e082e7111455fd69ab43181831f8e0169
      
https://github.com/qemu/qemu/commit/18b91a3e082e7111455fd69ab43181831f8e0169
  Author: Gonglei <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/core/qdev-properties-system.c
    M hw/core/qdev-properties.c
    M include/hw/qdev-core.h
    M target-ppc/translate_init.c

  Log Message:
  -----------
  qdev: Drop legacy_name from qdev properties

The legacy_name is useless now, better help
information is provided by description field of property.

Cc: Markus Armbruster <address@hidden>
Signed-off-by: Gonglei <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 88e6599669a2f8c9ec5b8baa62178bc3dfc340ae
      
https://github.com/qemu/qemu/commit/88e6599669a2f8c9ec5b8baa62178bc3dfc340ae
  Author: Peter Maydell <address@hidden>
  Date:   2014-10-15 (Wed, 15 Oct 2014)

  Changed paths:
    M hw/acpi/piix4.c
    M hw/char/virtio-serial-bus.c
    M hw/core/hotplug.c
    M hw/core/qdev-properties-system.c
    M hw/core/qdev-properties.c
    M hw/core/qdev.c
    M hw/cpu/icc_bus.c
    M hw/i386/acpi-build.c
    M hw/isa/lpc_ich9.c
    M hw/pci-bridge/pci_bridge_dev.c
    M hw/pci/pci-hotplug-old.c
    M hw/pci/pcie.c
    M hw/pci/pcie_port.c
    M hw/pci/shpc.c
    M hw/s390x/event-facility.c
    M hw/s390x/s390-virtio-bus.c
    M hw/s390x/virtio-ccw.c
    M hw/scsi/scsi-bus.c
    M hw/scsi/virtio-scsi.c
    M hw/scsi/vmw_pvscsi.c
    M hw/usb/bus.c
    M hw/usb/dev-smartcard-reader.c
    M hw/usb/dev-storage.c
    M hw/virtio/virtio-mmio.c
    M hw/virtio/virtio-pci.c
    M include/hw/hotplug.h
    M include/hw/pci/pcie.h
    M include/hw/pci/shpc.h
    M include/hw/qdev-core.h
    M include/hw/scsi/scsi.h
    M include/qom/object.h
    M qapi-schema.json
    M qdev-monitor.c
    M qmp.c
    M qom/object.c
    M target-ppc/translate_init.c
    M tests/Makefile
    M tests/libqos/pci-pc.c
    M tests/libqos/pci.h
    A tests/libqos/usb.c
    A tests/libqos/usb.h
    M tests/usb-hcd-ehci-test.c
    M tests/usb-hcd-ohci-test.c
    M tests/usb-hcd-uhci-test.c
    M tests/usb-hcd-xhci-test.c
    M tests/virtio-blk-test.c
    M tests/virtio-net-test.c
    M tests/virtio-rng-test.c
    M tests/virtio-scsi-test.c
    M tests/virtio-serial-test.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/afaerber/tags/qom-devices-for-peter' 
into staging

QOM infrastructure fixes and device conversions

* GPIO conversion to QOM, continued
* Device property description support
* QTest cases for hotplug
* Hotplug handler conversion

# gpg: Signature made Wed 15 Oct 2014 04:05:17 BST using RSA key ID 3E7E013F
# gpg: Good signature from "Andreas Färber <address@hidden>"
# gpg:                 aka "Andreas Färber <address@hidden>"

* remotes/afaerber/tags/qom-devices-for-peter: (47 commits)
  qdev: Drop legacy_name from qdev properties
  qmp: Print descriptions of object properties
  qdev: Set the object property's description to the qdev property's.
  qom: Add description field in ObjectProperty struct
  qdev: Add description field in PropertyInfo struct
  qdev: device_del: Search for to be unplugged device in 'peripheral' container
  qdev: HotplugHandler: Add support for unplugging BUS-less devices
  qdev: Drop legacy hotplug fields/methods
  usb: Convert usb devices to hotplug handler API
  usb: Convert usb-ccid to hotplug handler API
  usb-storage: Drop not needed "allow_hotplug = 0"
  usb-bot: Drop not needed "allow_hotplug = 0"
  usb-bot: Mark device as non hotpluggable
  scsi: Cleanup not used anymore SCSIBusInfo{hotplug, hot_unplug} fields
  scsi: Convert virtio-scsi HBA to hotplug handler API
  scsi: Convert pvscsi HBA to hotplug handler API
  scsi: Set SCSI BUS itself as default HotplugHandler
  s390x: Convert virtio-ccw to hotplug handler API
  s390x: Convert s390-virtio to hotplug handler API
  s390x: Drop not used allow_hotplug in event-facility
  ...

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/b1d28ec6a7db...88e6599669a2
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] b235a7: qdev: gpio: Don't allow name share between I and O, GitHub <=
Prev by Date: [Qemu-commits] [qemu/qemu] a9fd16: linux-headers: update to 3.17-rc7
Next by Date: [Qemu-commits] [qemu/qemu] deb22f: QEMUSizedBuffer based QEMUFile
Previous by thread: [Qemu-commits] [qemu/qemu] a9fd16: linux-headers: update to 3.17-rc7
Next by thread: [Qemu-commits] [qemu/qemu] deb22f: QEMUSizedBuffer based QEMUFile
Index(es):
- Date
- Thread