qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 5ff5ef: block: Pass errp in blkconf_geometry

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 5ff5ef: block: Pass errp in blkconf_geometry
Date: Thu, 28 Aug 2014 10:00:06 -0700 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 5ff5efb46c4526f111e14c2247609f1c56f0f8f3
      
https://github.com/qemu/qemu/commit/5ff5efb46c4526f111e14c2247609f1c56f0f8f3
  Author: Fam Zheng <address@hidden>
  Date:   2014-08-26 (Tue, 26 Aug 2014)

  Changed paths:
    M hw/block/block.c
    M hw/block/virtio-blk.c
    M hw/ide/qdev.c
    M hw/scsi/scsi-disk.c
    M include/hw/block/block.h

  Log Message:
  -----------
  block: Pass errp in blkconf_geometry

This allows us to pass error information to caller.

Reviewed-by: Andreas Färber <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: a818a4b69d47ca3826dee36878074395aeac2083
      
https://github.com/qemu/qemu/commit/a818a4b69d47ca3826dee36878074395aeac2083
  Author: Fam Zheng <address@hidden>
  Date:   2014-08-26 (Tue, 26 Aug 2014)

  Changed paths:
    M hw/scsi/lsi53c895a.c
    M hw/scsi/scsi-bus.c
    M hw/scsi/scsi-disk.c
    M hw/scsi/scsi-generic.c
    M include/hw/scsi/scsi.h
    M tests/qemu-iotests/051.out

  Log Message:
  -----------
  scsi-bus: Convert DeviceClass init to realize

Replace "init/destroy" with "realize/unrealize" in SCSIDeviceClass,
which has errp as a parameter. So all the implementations now use
error_setg instead of error_report for reporting error.

Also in scsi_bus_legacy_handle_cmdline, report the error when
initializing the if=scsi devices, before returning it, because in the
callee, error_report is changed to error_setg. And the callers don't
have the right locations (e.g. "-drive if=scsi").

Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Fam Zheng <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 9db693f76441e2fc7e1b05dc454e7db4d3298dcb
      
https://github.com/qemu/qemu/commit/9db693f76441e2fc7e1b05dc454e7db4d3298dcb
  Author: Peter Lieven <address@hidden>
  Date:   2014-08-26 (Tue, 26 Aug 2014)

  Changed paths:
    M block/iscsi.c

  Log Message:
  -----------
  block/iscsi: fix memory corruption on iscsi resize

bs->total_sectors is not yet updated at this point. resulting
in memory corruption if the volume has grown and data is written
to the newly availble areas.

CC: address@hidden
Signed-off-by: Peter Lieven <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: f93d2c15d603b811c877efbf2a47e418bf975f0c
      
https://github.com/qemu/qemu/commit/f93d2c15d603b811c877efbf2a47e418bf975f0c
  Author: Gonglei <address@hidden>
  Date:   2014-08-26 (Tue, 26 Aug 2014)

  Changed paths:
    M hw/scsi/scsi-generic.c

  Log Message:
  -----------
  scsi-generic: remove superfluous DPRINTF avoid to break compiling

variables lun and tag had been eliminated, break compiling
when enable debug switch. Meanwhile traces provide the same
information with this DPRINTF, so remove it.

Signed-off-by: Gonglei <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: c9f6552803d852d593dec9ef5bb39b7a61091963
      
https://github.com/qemu/qemu/commit/c9f6552803d852d593dec9ef5bb39b7a61091963
  Author: Fam Zheng <address@hidden>
  Date:   2014-08-26 (Tue, 26 Aug 2014)

  Changed paths:
    M hw/scsi/virtio-scsi.c

  Log Message:
  -----------
  virtio-scsi: Report error if num_queues is 0 or too large

No cmd vq surprises guest (Linux panics in virtscsi_probe), too many
queues abort qemu (in the following virtio_add_queue).

Signed-off-by: Fam Zheng <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: dc6c4fe8378b2e94bcf2ee2efa62ed0aba9aa5cc
      
https://github.com/qemu/qemu/commit/dc6c4fe8378b2e94bcf2ee2efa62ed0aba9aa5cc
  Author: Peter Crosthwaite <address@hidden>
  Date:   2014-08-28 (Thu, 28 Aug 2014)

  Changed paths:
    M xen-hvm.c

  Log Message:
  -----------
  xen-hvm: Constify string

It's constant, and sourced from existing const strings. Avoid dodgy
casts by converting to const.

Signed-off-by: Peter Crosthwaite <address@hidden>
Reviewed-by: Stefan Weil <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 3e1f50867b6872130cc19b7eadd93ab9ce268cdc
      
https://github.com/qemu/qemu/commit/3e1f50867b6872130cc19b7eadd93ab9ce268cdc
  Author: Peter Crosthwaite <address@hidden>
  Date:   2014-08-28 (Thu, 28 Aug 2014)

  Changed paths:
    M xen-hvm.c

  Log Message:
  -----------
  xen: hvm: Abstract away memory region name ref

The mr->name field is removed. This slipped through compile testing.
Fix.

Reviewed-by: Stefan Weil <address@hidden>
Signed-off-by: Peter Crosthwaite <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: d1dd32af6f37e5bb8e6b2024d07fce74f510a668
      
https://github.com/qemu/qemu/commit/d1dd32af6f37e5bb8e6b2024d07fce74f510a668
  Author: Peter Crosthwaite <address@hidden>
  Date:   2014-08-28 (Thu, 28 Aug 2014)

  Changed paths:
    M memory.c

  Log Message:
  -----------
  memory: Lazy init name from QOM name as needed

To support name retrieval of MemoryRegions that were created
dynamically (that is, not via memory_region_init and friends). We
cache the name in MemoryRegion's state as
object_get_canonical_path_component mallocs the returned value
so it's not suitable for direct return to callers. Memory already
frees the name field, so this will be garbage collected along with
the MR object.

Signed-off-by: Peter Crosthwaite <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: a6aebb38ba4682951ab04fe6d6e6b169bd9e4dca
      
https://github.com/qemu/qemu/commit/a6aebb38ba4682951ab04fe6d6e6b169bd9e4dca
  Author: Peter Maydell <address@hidden>
  Date:   2014-08-28 (Thu, 28 Aug 2014)

  Changed paths:
    M hw/block/block.c
    M hw/block/virtio-blk.c
    M hw/ide/qdev.c
    M hw/scsi/lsi53c895a.c
    M hw/scsi/scsi-bus.c
    M hw/scsi/scsi-disk.c
    M hw/scsi/scsi-generic.c
    M hw/scsi/virtio-scsi.c
    M include/hw/block/block.h
    M include/hw/scsi/scsi.h
    M memory.c
    M tests/qemu-iotests/051.out
    M xen-hvm.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging

SCSI patches include bug fixes from Fam and Peter, improved error
reporting from Fam and a fix for DPRINTF bitrot.  Memory patches try
again to initialize name from the QOM name.

# gpg: Signature made Thu 28 Aug 2014 15:10:31 BST using RSA key ID 9B4D86F2
# gpg: Good signature from "Paolo Bonzini <address@hidden>"
# gpg:                 aka "Paolo Bonzini <address@hidden>"

* remotes/bonzini/tags/for-upstream:
  memory: Lazy init name from QOM name as needed
  xen: hvm: Abstract away memory region name ref
  xen-hvm: Constify string
  virtio-scsi: Report error if num_queues is 0 or too large
  scsi-generic: remove superfluous DPRINTF avoid to break compiling
  block/iscsi: fix memory corruption on iscsi resize
  scsi-bus: Convert DeviceClass init to realize
  block: Pass errp in blkconf_geometry

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/38a01e55d268...a6aebb38ba46
reply via email to
[Prev in Thread] Current Thread [Next in Thread]