[Qemu-commits] [qemu/qemu] a1abf4: linux-aio: Fix laio resource leak

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: a1abf40d6be2fc4b40d90ae3b46442f4a671776b
      
https://github.com/qemu/qemu/commit/a1abf40d6be2fc4b40d90ae3b46442f4a671776b
  Author: Gonglei <address@hidden>
  Date:   2014-07-15 (Tue, 15 Jul 2014)

  Changed paths:
    M block/linux-aio.c

  Log Message:
  -----------
  linux-aio: Fix laio resource leak

when hotplug virtio-scsi disks using laio, the aio_nr will
increase in laio_init() by io_setup(), we can see the number by
  # cat /proc/sys/fs/aio-nr
  128
if the aio_nr attach the maxnum, which found from
  # cat /proc/sys/fs/aio-max-nr
  65536
the hotplug process will fail because of aio context leak.

Fix it by io_destroy in laio_cleanup().

Reported-by: daifulai <address@hidden>
Signed-off-by: Gonglei <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: e926d9b8c52d5ddf413617df4b341a3114642b14
      
https://github.com/qemu/qemu/commit/e926d9b8c52d5ddf413617df4b341a3114642b14
  Author: Ming Lei <address@hidden>
  Date:   2014-07-15 (Tue, 15 Jul 2014)

  Changed paths:
    M hw/block/dataplane/virtio-blk.c

  Log Message:
  -----------
  virtio-blk: data-plane: fix save/set .complete_request in start

The callback has to be saved and reset in virtio_blk_data_plane_start(),
otherwise dataplane's requests will be completed in qemu aio context.

Reviewed-by: Fam Zheng <address@hidden>
Signed-off-by: Ming Lei <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 5b2ffbe4d99843fd8305c573a100047a8c962327
      
https://github.com/qemu/qemu/commit/5b2ffbe4d99843fd8305c573a100047a8c962327
  Author: Ming Lei <address@hidden>
  Date:   2014-07-15 (Tue, 15 Jul 2014)

  Changed paths:
    M hw/block/dataplane/virtio-blk.c

  Log Message:
  -----------
  virtio-blk: dataplane: notify guest as a batch

Now requests are submitted as a batch, so it is natural
to notify guest as a batch too.

This may suppress interrupt notification to VM a lot:
   - in my test, decreased by ~13K/sec

Signed-off-by: Ming Lei <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>


  Commit: 2c65ebe6465618ca159398dfb15d9118ae0fd99f
      
https://github.com/qemu/qemu/commit/2c65ebe6465618ca159398dfb15d9118ae0fd99f
  Author: Peter Maydell <address@hidden>
  Date:   2014-07-15 (Tue, 15 Jul 2014)

  Changed paths:
    M block/linux-aio.c
    M hw/block/dataplane/virtio-blk.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into 
staging

Block pull request

# gpg: Signature made Tue 15 Jul 2014 14:49:01 BST using RSA key ID 81AB73C8
# gpg: Good signature from "Stefan Hajnoczi <address@hidden>"
# gpg:                 aka "Stefan Hajnoczi <address@hidden>"

* remotes/stefanha/tags/block-pull-request:
  virtio-blk: dataplane: notify guest as a batch
  virtio-blk: data-plane: fix save/set .complete_request in start
  linux-aio: Fix laio resource leak

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/0e1629746126...2c65ebe64656