[Qemu-commits] [qemu/qemu] dfecbb: virtio-scsi: virtio_scsi_push_event() lacks VirtIO...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: dfecbb95e38d94d0e68f6e648a3c6489219a885d
      
https://github.com/qemu/qemu/commit/dfecbb95e38d94d0e68f6e648a3c6489219a885d
  Author: Greg Kurz <address@hidden>
  Date:   2014-07-01 (Tue, 01 Jul 2014)

  Changed paths:
    M hw/scsi/virtio-scsi.c

  Log Message:
  -----------
  virtio-scsi: virtio_scsi_push_event() lacks VirtIOSCSIReq parsing

Hotplug of a virtio scsi disk is currently broken: no disk appears in the
guest (verified with a fedora 20 host running a fedora 20 guest with KVM).
Bisect leeds to Paolo's patches to support any_layout, especially this
commit:

commit 36b15c79aa1bef5fe7543f9f2629b6413720bbfb
Author: Paolo Bonzini <address@hidden>
Date:   Tue Jun 10 16:21:18 2014 +0200

    virtio-scsi: start preparing for any_layout

It modifies virtio_scsi_pop_req() so that it is up to the callers to parse
the virtio scsi request. It seems that virtio_scsi_push_event() was not
modified accordingly...

This patch adds a call to virtio_scsi_parse_req(). It also drops some
sanity checks that are already performed by virtio_scsi_parse_req().

Signed-off-by: Greg Kurz <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 424baff549a9c8a7b5e814ce2bcb857d25163468
      
https://github.com/qemu/qemu/commit/424baff549a9c8a7b5e814ce2bcb857d25163468
  Author: Cédric Le Goater <address@hidden>
  Date:   2014-07-01 (Tue, 01 Jul 2014)

  Changed paths:
    M hw/scsi/virtio-scsi.c

  Log Message:
  -----------
  virtio-scsi: scsi events must be converted to target endianness

Virtio SCSI Events need to be byteswapped before being pushed
when host and guest have a different endianness. Not doing so
breaks hotplug of virtio scsi disks, with the following error
message being printed in the guest console:

virtio_scsi: Unsupport virtio scsi event 1000000

This issue got uncovered while testing disk hotplug with a PowerKVM
ppc64le guest. I have checked that this issue also affects a x86_64
guest run on a ppc64 host.

Signed-off-by: Cédric Le Goater <address@hidden>
[ Ported from PowerKVM,
  Greg Kurz <address@hidden> ]
Signed-off-by: Greg Kurz <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: f80ea9862fed7ca89a672785bdce0e2611f9ba97
      
https://github.com/qemu/qemu/commit/f80ea9862fed7ca89a672785bdce0e2611f9ba97
  Author: Alexey Kardashevskiy <address@hidden>
  Date:   2014-07-01 (Tue, 01 Jul 2014)

  Changed paths:
    M Makefile.target
    M configure

  Log Message:
  -----------
  configure: Fix -lm test, so that tools can be compiled on hosts that require 
-lm

The existing test whether "-lm" needs to be included or not is
insufficient as it reports false negative on Fedora20/ppc64.
This happens because sin(0.0) is a constant value which compiler
can safely throw away and therefore there is no need to add "-lm".
As the result, qemu-nbd/qemu-io/qemu-img tools cannot compile.

This adds a global variable and uses it in the test to prevent
from optimization.

Signed-off-by: Alexey Kardashevskiy <address@hidden>
[Use Peter's improvement on the test to fool LTO, and remove the
 now useless -lm addition in Makefile.target. - Paolo]
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: d94a658712591ba716f84d4295adaf463c2e4a84
      
https://github.com/qemu/qemu/commit/d94a658712591ba716f84d4295adaf463c2e4a84
  Author: Peter Maydell <address@hidden>
  Date:   2014-07-01 (Tue, 01 Jul 2014)

  Changed paths:
    M Makefile.target
    M configure
    M hw/scsi/virtio-scsi.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/bonzini/scsi-next' into staging

* remotes/bonzini/scsi-next:
  configure: Fix -lm test, so that tools can be compiled on hosts that require 
-lm
  virtio-scsi: scsi events must be converted to target endianness
  virtio-scsi: virtio_scsi_push_event() lacks VirtIOSCSIReq parsing

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/53a259da5697...d94a65871259