qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] e9d21c: char: fix avail_connections init in q


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] e9d21c: char: fix avail_connections init in qemu_chr_open_...
Date: Fri, 13 Jun 2014 07:30:06 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: e9d21c436f716603b3844513ba890ac570e642e1
      
https://github.com/qemu/qemu/commit/e9d21c436f716603b3844513ba890ac570e642e1
  Author: David Marchand <address@hidden>
  Date:   2014-06-13 (Fri, 13 Jun 2014)

  Changed paths:
    M qemu-char.c

  Log Message:
  -----------
  char: fix avail_connections init in qemu_chr_open_eventfd()

When trying to use a ivshmem server with qemu, ivshmem init code tries to
create a CharDriverState object for each eventfd retrieved from the server.
To create this object, a call to qemu_chr_open_eventfd() is done.
Right after this, before adding a frontend, qemu_chr_fe_claim_no_fail() is
called.
qemu_chr_open_eventfd() does not set avail_connections to 1, so no frontend can
be associated because qemu_chr_fe_claim_no_fail() makes qemu stop right away.

This problem comes from 456d60692310e7ac25cf822cc1e98192ad636ece
"qemu-char: Call fe_claim / fe_release when not using qdev chr properties".

Fix this, by setting avail_connections to 1 in qemu_chr_open_eventfd().

Signed-off-by: David Marchand <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 7d5bef0873abdc336c7e9f4e2ddbf30f7348342e
      
https://github.com/qemu/qemu/commit/7d5bef0873abdc336c7e9f4e2ddbf30f7348342e
  Author: Peter Maydell <address@hidden>
  Date:   2014-06-13 (Fri, 13 Jun 2014)

  Changed paths:
    M qemu-char.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/pull-chardev-20140613-1' 
into staging

char: fix avail_connections init in qemu_chr_open_eventfd()

# gpg: Signature made Fri 13 Jun 2014 12:16:50 BST using RSA key ID D3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"

* remotes/kraxel/tags/pull-chardev-20140613-1:
  char: fix avail_connections init in qemu_chr_open_eventfd()

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/d61de7255b70...7d5bef0873ab

reply via email to

[Prev in Thread] Current Thread [Next in Thread]