qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] afff2b: console: Abort on property access err


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] afff2b: console: Abort on property access errors
Date: Wed, 28 May 2014 06:00:05 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: afff2b15e89ac81c113f2ebfd729aaa02b40edb6
      
https://github.com/qemu/qemu/commit/afff2b15e89ac81c113f2ebfd729aaa02b40edb6
  Author: Kirill Batuzov <address@hidden>
  Date:   2014-05-26 (Mon, 26 May 2014)

  Changed paths:
    M ui/console.c

  Log Message:
  -----------
  console: Abort on property access errors

All defined properties of QemuConsole are mandatory and no access to them
should fail. Nevertheless not checking returned errors is bad because in case
of unexpected failure it will hide the bug and cause a memory leak.

Abort in case of unexpected property access errors. This change exposed a bug
where an attempt was made to write to a read-only property "head".

Set "head" property's value at creation time and do not attempt to change it
later. This fixes the bug mentioned above.

Signed-off-by: Kirill Batuzov <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 521a580d2352ad30086babcabb91e6338e47cf62
      
https://github.com/qemu/qemu/commit/521a580d2352ad30086babcabb91e6338e47cf62
  Author: Gerd Hoffmann <address@hidden>
  Date:   2014-05-26 (Mon, 26 May 2014)

  Changed paths:
    M ui/console.c

  Log Message:
  -----------
  console: nicer initial screen

Now that we have a function to create a fancy DisplaySurface with a
message for the user, to handle non-existing graphics hardware, we
can make it more generic and use it for other things too.

This patch adds a text line to the in initial DisplaySurface, notifying
the user that the display isn't initialized yet by the guest.

You can see this in action when starting qemu with '-S'.  Also when
booting ovmf in qemu (which needs a few moments to initialize itself
before it initializes the vga).

Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: b35e3ba01a2759f79015c7d1a0859fd0dc4ec67c
      
https://github.com/qemu/qemu/commit/b35e3ba01a2759f79015c7d1a0859fd0dc4ec67c
  Author: Gerd Hoffmann <address@hidden>
  Date:   2014-05-26 (Mon, 26 May 2014)

  Changed paths:
    M ui/console.c

  Log Message:
  -----------
  console: update text terminal surface unconditionally

These days each QemuConsole has its own private DisplaySurface,
so we can simply render updates all the time.

Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: aea7947c74e67e35352d6e7de2a06c8826c2c24d
      
https://github.com/qemu/qemu/commit/aea7947c74e67e35352d6e7de2a06c8826c2c24d
  Author: Gerd Hoffmann <address@hidden>
  Date:   2014-05-26 (Mon, 26 May 2014)

  Changed paths:
    M ui/console.c

  Log Message:
  -----------
  console: rework text terminal cursor logic

Have a global timer.  Update all visible terminal windows syncronously.
Right now this can be the active_console only, but that will change
soon.  The global timer will disable itself if not needed, so we only
have to care start it if needed.  Which might be at console switch time
or when a new displaychangelistener is registered.

Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 3f9a6e852eec56453a423a9564499fa2305f1cb4
      
https://github.com/qemu/qemu/commit/3f9a6e852eec56453a423a9564499fa2305f1cb4
  Author: Gerd Hoffmann <address@hidden>
  Date:   2014-05-26 (Mon, 26 May 2014)

  Changed paths:
    M include/ui/console.h
    M ui/console.c

  Log Message:
  -----------
  console: add kbd_put_keysym_console

So you can send keysyms to a specific (text terminal) console.

Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 53651ec26b26440d73ed0f1bcd011e0d636b2d73
      
https://github.com/qemu/qemu/commit/53651ec26b26440d73ed0f1bcd011e0d636b2d73
  Author: Peter Maydell <address@hidden>
  Date:   2014-05-28 (Wed, 28 May 2014)

  Changed paths:
    M include/ui/console.h
    M ui/console.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/pull-console-1' into staging

console: multiwindow support for text terminal QemuConsoles
console: small fixes

# gpg: Signature made Mon 26 May 2014 09:17:27 BST using RSA key ID D3E87138
# gpg: Can't check signature: public key not found

* remotes/kraxel/tags/pull-console-1:
  console: add kbd_put_keysym_console
  console: rework text terminal cursor logic
  console: update text terminal surface unconditionally
  console: nicer initial screen
  console: Abort on property access errors

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/109519fd326f...53651ec26b26

reply via email to

[Prev in Thread] Current Thread [Next in Thread]