qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 61c7bb: kvm: Fix enable_cap helpers on older

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 61c7bb: kvm: Fix enable_cap helpers on older gcc
Date: Thu, 22 May 2014 09:30:05 -0700 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 61c7bbd236b90da7531fcf957223a2456670d44d
      
https://github.com/qemu/qemu/commit/61c7bbd236b90da7531fcf957223a2456670d44d
  Author: Alexander Graf <address@hidden>
  Date:   2014-05-20 (Tue, 20 May 2014)

  Changed paths:
    M include/sysemu/kvm.h

  Log Message:
  -----------
  kvm: Fix enable_cap helpers on older gcc

Commit 40f1ee27aa1 introduced handy helpers for enable_cap calls on
vcpu and vm level. Unfortunately some older gcc versions (4.7.1, 4.6)
seem to choke on signedness detection in inline created variables:

target-ppc/kvm.c: In function 'kvmppc_booke_watchdog_enable':
target-ppc/kvm.c:1302:21: error: comparison of unsigned expression < 0 is 
always false [-Werror=type-limits]
target-ppc/kvm.c: In function 'kvmppc_set_papr':
target-ppc/kvm.c:1504:21: error: comparison of unsigned expression < 0 is 
always false [-Werror=type-limits]

However - thanks to Thomas Huth for the suggestion - we can just cast the
offending potentially 0 value to a signed type, making the comparison signed.

Reviewed-by: Thomas Huth <address@hidden>
Acked-by: Cornelia Huck <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: 7b35d0c44cae3dcce6347a0729a416c2929cd4bb
      
https://github.com/qemu/qemu/commit/7b35d0c44cae3dcce6347a0729a416c2929cd4bb
  Author: Cornelia Huck <address@hidden>
  Date:   2014-05-20 (Tue, 20 May 2014)

  Changed paths:
    M default-configs/s390x-softmmu.mak
    M hw/intc/Makefile.objs
    M hw/intc/s390_flic.c
    A hw/intc/s390_flic_kvm.c
    M include/hw/s390x/s390_flic.h

  Log Message:
  -----------
  s390x: split flic into kvm and non-kvm parts

Introduce a common parent class for both cases, where kvm and non-kvm
can hook up callbacks. This will be used by follow-on patches for
adapter registration and mapping.

We now always have a flic, regardless of whether we use kvm; the
non-kvm implementation just doesn't do anything.

Reviewed-by: Jens Freimann <address@hidden>
Reviewed-by: Christian Borntraeger <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: 03cf077ac9c02ccc192b9011ced12cc74f9151bb
      
https://github.com/qemu/qemu/commit/03cf077ac9c02ccc192b9011ced12cc74f9151bb
  Author: Cornelia Huck <address@hidden>
  Date:   2014-05-20 (Tue, 20 May 2014)

  Changed paths:
    M hw/intc/s390_flic.c
    M hw/intc/s390_flic_kvm.c
    M hw/s390x/css.c
    M hw/s390x/css.h
    M hw/s390x/virtio-ccw.c
    M hw/s390x/virtio-ccw.h
    M include/hw/s390x/s390_flic.h

  Log Message:
  -----------
  s390x: add I/O adapter registration

Register an I/O adapter interrupt source for when virtio-ccw devices start
using adapter interrupts.

Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Christian Borntraeger <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: 7bca3892cb951afb5945480b090e3fb93578cd6a
      
https://github.com/qemu/qemu/commit/7bca3892cb951afb5945480b090e3fb93578cd6a
  Author: Cornelia Huck <address@hidden>
  Date:   2014-05-20 (Tue, 20 May 2014)

  Changed paths:
    M hw/s390x/virtio-ccw.c
    M hw/s390x/virtio-ccw.h

  Log Message:
  -----------
  s390x/virtio-ccw: reference-counted indicators

Make code using the same indicators point to a single allocated structure
that is freed when the last user goes away.

This will be used by the irqfd code to unmap addresses after the last user
is gone.

Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Christian Borntraeger <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: d426d9fba8ea5d728038a9bea6a7c51f11941157
      
https://github.com/qemu/qemu/commit/d426d9fba8ea5d728038a9bea6a7c51f11941157
  Author: Cornelia Huck <address@hidden>
  Date:   2014-05-20 (Tue, 20 May 2014)

  Changed paths:
    M hw/intc/s390_flic.c
    M hw/intc/s390_flic_kvm.c
    M hw/s390x/virtio-ccw.c
    M hw/s390x/virtio-ccw.h
    A include/hw/s390x/adapter.h
    M include/hw/s390x/s390_flic.h
    M include/qemu/typedefs.h
    M include/sysemu/kvm.h
    M kvm-all.c
    M kvm-stub.c
    M target-s390x/kvm.c

  Log Message:
  -----------
  s390x/virtio-ccw: wire up irq routing and irqfds

Make use of the new s390 adapter irq routing support to enable real
in-kernel irqfds for virtio-ccw with adapter interrupts.

Note that s390 doesn't provide the common KVM_CAP_IRQCHIP capability, but
rather needs KVM_CAP_S390_IRQCHIP to be enabled. This is to ensure backward
compatibility.

Reviewed-by: Thomas Huth <address@hidden>
Reviewed-by: Christian Borntraeger <address@hidden>
Acked-by: Paolo Bonzini <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: 76eb98d51c0a0448c5bc2f70d15fe334e7234964
      
https://github.com/qemu/qemu/commit/76eb98d51c0a0448c5bc2f70d15fe334e7234964
  Author: Jens Freimann <address@hidden>
  Date:   2014-05-20 (Tue, 20 May 2014)

  Changed paths:
    M linux-headers/asm-s390/kvm.h
    M linux-headers/linux/kvm.h

  Log Message:
  -----------
  linux-headers: update

Sync linux-headers with kvm/next (87c00572ba05aa8c9db118da75c608f47eb10b9e)

Signed-off-by: Jens Freimann <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: 8e4e86afa524588397be2101c3582c897fc408df
      
https://github.com/qemu/qemu/commit/8e4e86afa524588397be2101c3582c897fc408df
  Author: David Hildenbrand <address@hidden>
  Date:   2014-05-20 (Tue, 20 May 2014)

  Changed paths:
    M target-s390x/kvm.c

  Log Message:
  -----------
  s390x: remove duplicate definitions of DIAG 501

When restoring the previously saved instruction in
kvm_arch_remove_sw_breakpoint(), we only restored one byte. Let's use
the sizeof() operator to make sure we restore the entire instruction.

While we are at it, let's remove the duplicate definitions of DIAG 501
and replace its size (used when reading/writing the instruction) with
a sizeof() operator to make the code self explaining and less error-prone.

Signed-off-by: David Hildenbrand <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Signed-off-by: Jens Freimann <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: b30f4dfbdaf353e580f8a834aeea6b96ac1c67c9
      
https://github.com/qemu/qemu/commit/b30f4dfbdaf353e580f8a834aeea6b96ac1c67c9
  Author: David Hildenbrand <address@hidden>
  Date:   2014-05-20 (Tue, 20 May 2014)

  Changed paths:
    M target-s390x/kvm.c

  Log Message:
  -----------
  s390x/kvm: software breakpoint support

This patch allows to insert and remove sw breakpoints using the QEMU gdbserver
on s390 as well as to interrupt execution on a breakpoint hit when running
with KVM enabled.

Whenever a software breakpoint is inserted, common code calls kvm ioctl
KVM_UPDATE_GUEST_DEBUG. As this method's default on s390 is to return an error
if not implement, the insertion will fail. Therefore, KVM also has to be
updated in order to make use of software breakpoints.

Signed-off-by: David Hildenbrand <address@hidden>
Signed-off-by: Jens Freimann <address@hidden>
Reviewed-by: Cornelia Huck <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: 770a63792b2c9a3f9565b68b0a7ef0be6883f551
      
https://github.com/qemu/qemu/commit/770a63792b2c9a3f9565b68b0a7ef0be6883f551
  Author: David Hildenbrand <address@hidden>
  Date:   2014-05-20 (Tue, 20 May 2014)

  Changed paths:
    M target-s390x/cpu-qom.h
    M target-s390x/helper.c
    M target-s390x/kvm.c

  Log Message:
  -----------
  s390x/kvm: hw debugging support via guest PER facility

This patch makes use of the hw debugging support in kvm (provided by the guest's
PER facility) on s390. It enables the following features, available using the
gdbserver:
- single-stepping
- hw breakpoints
- hw watchpoints

Signed-off-by: David Hildenbrand <address@hidden>
Signed-off-by: Jens Freimann <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>


  Commit: 45e66b7beb275bd1f8c4e56fe97dfb88b35345d0
      
https://github.com/qemu/qemu/commit/45e66b7beb275bd1f8c4e56fe97dfb88b35345d0
  Author: Peter Maydell <address@hidden>
  Date:   2014-05-22 (Thu, 22 May 2014)

  Changed paths:
    M default-configs/s390x-softmmu.mak
    M hw/intc/Makefile.objs
    M hw/intc/s390_flic.c
    A hw/intc/s390_flic_kvm.c
    M hw/s390x/css.c
    M hw/s390x/css.h
    M hw/s390x/virtio-ccw.c
    M hw/s390x/virtio-ccw.h
    A include/hw/s390x/adapter.h
    M include/hw/s390x/s390_flic.h
    M include/qemu/typedefs.h
    M include/sysemu/kvm.h
    M kvm-all.c
    M kvm-stub.c
    M linux-headers/asm-s390/kvm.h
    M linux-headers/linux/kvm.h
    M target-s390x/cpu-qom.h
    M target-s390x/helper.c
    M target-s390x/kvm.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20140520' into staging

some s390 patches:

- Enable irqfds on s390 via the new adapter interrupt routing type.
  As a prereq, fix the kvm enable_cap helpers for some compilers and
  split the s390 flic into kvm and non-kvm parts.
- Enable software and hardware debugging support on s390. This needs a
  kernel headers update.

# gpg: Signature made Tue 20 May 2014 12:30:54 BST using RSA key ID C6F02FAF
# gpg: Can't check signature: public key not found

* remotes/cohuck/tags/s390x-20140520:
  s390x/kvm: hw debugging support via guest PER facility
  s390x/kvm: software breakpoint support
  s390x: remove duplicate definitions of DIAG 501
  linux-headers: update
  s390x/virtio-ccw: wire up irq routing and irqfds
  s390x/virtio-ccw: reference-counted indicators
  s390x: add I/O adapter registration
  s390x: split flic into kvm and non-kvm parts
  kvm: Fix enable_cap helpers on older gcc

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/65903a8b0807...45e66b7beb27
reply via email to
[Prev in Thread] Current Thread [Next in Thread]