[Qemu-commits] [qemu/qemu] 4fc005: configure: remove bashism

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 4fc00556ab68fc91c6d0150152f824d262c0be12
      
https://github.com/qemu/qemu/commit/4fc00556ab68fc91c6d0150152f824d262c0be12
  Author: Michael Tokarev <address@hidden>
  Date:   2014-05-07 (Wed, 07 May 2014)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: remove bashism

Commit e26110cfc67d48 added a check for shacmd to create a hash
for modules.  This check in configure is using bash construct &>
to redirect both stdout and stderr, which does fun things on some
shells.  Get rid of it, use standard redirection instead.

Signed-off-by: Michael Tokarev <address@hidden>
Reviewed-by: Fam Zheng <address@hidden>


  Commit: 8e8be266af067277664c96670c779d8924b4d61e
      
https://github.com/qemu/qemu/commit/8e8be266af067277664c96670c779d8924b4d61e
  Author: Stefan Weil <address@hidden>
  Date:   2014-05-07 (Wed, 07 May 2014)

  Changed paths:
    M qga/main.c

  Log Message:
  -----------
  qga: Fix typo (plural) in comment

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: ad0a118fa322b39887938185911d4fb332617b5c
      
https://github.com/qemu/qemu/commit/ad0a118fa322b39887938185911d4fb332617b5c
  Author: Peter Maydell <address@hidden>
  Date:   2014-05-07 (Wed, 07 May 2014)

  Changed paths:
    M tests/tcg/Makefile
    M tests/tcg/test_path.c

  Log Message:
  -----------
  tests/tcg: Fix compilation of test_path

The test_path binary is (unlike the other test binaries in tests/tcg)
actually intended to be compiled with the same compiler used to build
the main QEMU executables. It actually #includes a number of the
QEMU source files in an attempt to unit-test the util/path.c functions,
and so if it is not compiled with the same compiler used by configure
to set CONFIG_ settings then it is liable to fail to build.
Fix the makefile to build it with the default C compiler rules, not
CC_I386, and fix the test itself not to include a lot of unnecessary
trace related source files which cause the build to fail if the trace
backend is anything other than 'simple'.

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 4798fe55c4d539ddf8c7f5befcddfa145b3c6102
      
https://github.com/qemu/qemu/commit/4798fe55c4d539ddf8c7f5befcddfa145b3c6102
  Author: Chen Gang <address@hidden>
  Date:   2014-05-07 (Wed, 07 May 2014)

  Changed paths:
    M arch_init.c

  Log Message:
  -----------
  arch_init: Be sure of only one exit entry with DPRINTF() for ram_load()

When DPRINTF() has effect, the original author wants to print all
ram_load() calling results. So need use 'goto' instead of 'return'
within ram_load(), just like other areas have done.

Signed-off-by: Chen Gang <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: f5a014d2368b7a309cafc724e36089ab9e2af8c2
      
https://github.com/qemu/qemu/commit/f5a014d2368b7a309cafc724e36089ab9e2af8c2
  Author: Stefan Weil <address@hidden>
  Date:   2014-05-07 (Wed, 07 May 2014)

  Changed paths:
    M hw/9pfs/virtio-9p-synth.c
    M hw/core/qdev.c

  Log Message:
  -----------
  hw/9pfs: Add missing 'static' attributes

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: f73cdbc6acdb85f5fdb42a75121d0c97e00663ac
      
https://github.com/qemu/qemu/commit/f73cdbc6acdb85f5fdb42a75121d0c97e00663ac
  Author: Stefan Weil <address@hidden>
  Date:   2014-05-07 (Wed, 07 May 2014)

  Changed paths:
    M hw/mips/mips_fulong2e.c

  Log Message:
  -----------
  hw/mips: Add missing 'static' and 'const' attributes

This fixes a warning from the static code analysis (smatch).

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
Acked-by: Aurelien Jarno <address@hidden>


  Commit: bfaaad02814b1f4e86eb4ba1978a93a6dccd1e7d
      
https://github.com/qemu/qemu/commit/bfaaad02814b1f4e86eb4ba1978a93a6dccd1e7d
  Author: Stefan Weil <address@hidden>
  Date:   2014-05-07 (Wed, 07 May 2014)

  Changed paths:
    M hw/s390x/event-facility.c

  Log Message:
  -----------
  hw/s390x: Add missing 'static' attribute

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 79f320246c8ee972e4b3469027492533fca178d8
      
https://github.com/qemu/qemu/commit/79f320246c8ee972e4b3469027492533fca178d8
  Author: Stefan Weil <address@hidden>
  Date:   2014-05-07 (Wed, 07 May 2014)

  Changed paths:
    M monitor.c

  Log Message:
  -----------
  monitor: Add missing 'static' attribute

This fixes a warning from the static code analysis (smatch).

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 6075137d949e078744b332ba2279348bff64bf83
      
https://github.com/qemu/qemu/commit/6075137d949e078744b332ba2279348bff64bf83
  Author: Stefan Weil <address@hidden>
  Date:   2014-05-07 (Wed, 07 May 2014)

  Changed paths:
    M ui/console.c

  Log Message:
  -----------
  ui: Add missing 'static' attribute

There was already a forward declaration using 'static',
but the attribute was missing in the implementation.

This fixes a warning from the static code analysis (smatch).

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: fbdb664cb69730d043e7eb3b89db1cc8b419080f
      
https://github.com/qemu/qemu/commit/fbdb664cb69730d043e7eb3b89db1cc8b419080f
  Author: Stefan Weil <address@hidden>
  Date:   2014-05-07 (Wed, 07 May 2014)

  Changed paths:
    M qemu-timer.c

  Log Message:
  -----------
  qemu-timer: Add missing 'static' attribute

This fixes a warning from the static code analysis (smatch).

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 6a0a70b0f51001ca86a9671ef6b6352f537c2d64
      
https://github.com/qemu/qemu/commit/6a0a70b0f51001ca86a9671ef6b6352f537c2d64
  Author: Stefan Weil <address@hidden>
  Date:   2014-05-07 (Wed, 07 May 2014)

  Changed paths:
    M hw/net/cadence_gem.c
    M hw/net/vmxnet3.c
    M hw/net/xgmac.c
    M hw/ppc/spapr_iommu.c
    M hw/ppc/spapr_rtas.c
    M hw/scsi/scsi-bus.c

  Log Message:
  -----------
  hw: Add missing 'static' attributes

This fixes warnings from the static code analysis (smatch).

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 770e39f743e9070964a78903950348af67cd0788
      
https://github.com/qemu/qemu/commit/770e39f743e9070964a78903950348af67cd0788
  Author: Jim Meyering <address@hidden>
  Date:   2014-05-07 (Wed, 07 May 2014)

  Changed paths:
    M hw/xen/xen_backend.c

  Log Message:
  -----------
  xen: remove unused global, xen_xcg

Reviewed-by: Stefan Weil <address@hidden>
Signed-off-by: Jim Meyering <address@hidden>
Acked-by: Stefano Stabellini <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 69b15212d761889b2768b654f09a0eac78951674
      
https://github.com/qemu/qemu/commit/69b15212d761889b2768b654f09a0eac78951674
  Author: Stefan Weil <address@hidden>
  Date:   2014-05-07 (Wed, 07 May 2014)

  Changed paths:
    M hw/9pfs/virtio-9p-local.c

  Log Message:
  -----------
  hw/9pfs: Add include file for exported symbol

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: f33cc84dd4af7776309d118412df008ec4108a57
      
https://github.com/qemu/qemu/commit/f33cc84dd4af7776309d118412df008ec4108a57
  Author: Michael Tokarev <address@hidden>
  Date:   2014-05-07 (Wed, 07 May 2014)

  Changed paths:
    M coroutine-gthread.c
    M util/osdep.c

  Log Message:
  -----------
  do not call g_thread_init() for glib >= 2.31

glib >= 2.31 always enables thread support and g_thread_supported()
is #defined to 1, there's no need to call g_thread_init() anymore,
and it definitely does not need to report error which never happens.
Keep code for old < 2.31 glibc anyway for now, just #ifdef it
differently.

Signed-off-by: Michael Tokarev <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Cc: address@hidden


  Commit: f95c967a7950797109d2a96fcfa2e3a2899f2c99
      
https://github.com/qemu/qemu/commit/f95c967a7950797109d2a96fcfa2e3a2899f2c99
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2014-05-07 (Wed, 07 May 2014)

  Changed paths:
    M include/glib-compat.h
    M include/qemu-common.h

  Log Message:
  -----------
  glib: move g_poll() replacement into glib-compat.h

We have a dedicated header file for wrappers to smooth over glib version
differences.  Move the g_poll() definition into glib-compat.h for
consistency.

Signed-off-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
Cc: address@hidden


  Commit: a22f8f38942623dc473bf5ced5b4117b8bdf4821
      
https://github.com/qemu/qemu/commit/a22f8f38942623dc473bf5ced5b4117b8bdf4821
  Author: Michael Tokarev <address@hidden>
  Date:   2014-05-07 (Wed, 07 May 2014)

  Changed paths:
    M libcacard/vcard_emul_nss.c

  Log Message:
  -----------
  libcacard: replace pstrcpy() with memcpy()

Commit 2e679780ae86c6ca8 replaced strncpy() with pstrcpy()
in one place in libcacard.  This is a qemu-specific function,
while libcacard is a stand-alone library (or tries to be).
But since we know the exact length of the string to copy,
and know that it definitely will fit in the destination
buffer, use memcpy() instead, and null-terminate the string
after that.

An alternative is to use g_strlcpy() or strncpy(), but memcpy()
is more than adequate in this place.

Signed-off-by: Michael Tokarev <address@hidden>
Cc: address@hidden
Cc: Alon Levy <address@hidden>


  Commit: 797720876a5c24dd6adb3c2d6e0c872ac3b35c11
      
https://github.com/qemu/qemu/commit/797720876a5c24dd6adb3c2d6e0c872ac3b35c11
  Author: Michael Tokarev <address@hidden>
  Date:   2014-05-07 (Wed, 07 May 2014)

  Changed paths:
    M qmp.c

  Log Message:
  -----------
  qmp: report path ambiguity error

Without this, ambiguous path is reported to the user as
"not found", which is confusing at least.

Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 6ad7c326a1b62a71a83b46de79b8d8391bb768ff
      
https://github.com/qemu/qemu/commit/6ad7c326a1b62a71a83b46de79b8d8391bb768ff
  Author: Michael Tokarev <address@hidden>
  Date:   2014-05-07 (Wed, 07 May 2014)

  Changed paths:
    M util/readline.c

  Log Message:
  -----------
  readline: use g_strndup instead of open-coding it

Signed-off-by: Michael Tokarev <address@hidden>
Reviewed-by: Andreas Färber <address@hidden>


  Commit: 307b2f01488ae0fab18a8f0538e7c750842e74dd
      
https://github.com/qemu/qemu/commit/307b2f01488ae0fab18a8f0538e7c750842e74dd
  Author: Hani Benhabiles <address@hidden>
  Date:   2014-05-07 (Wed, 07 May 2014)

  Changed paths:
    M util/readline.c

  Log Message:
  -----------
  readline: Sort completions before printing them.

Signed-off-by: Hani Benhabiles <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: edc1ba7a7a13b1c721f2a7791ff809633d85fb9b
      
https://github.com/qemu/qemu/commit/edc1ba7a7a13b1c721f2a7791ff809633d85fb9b
  Author: Fam Zheng <address@hidden>
  Date:   2014-05-07 (Wed, 07 May 2014)

  Changed paths:
    M docs/memory.txt
    M include/exec/memory.h

  Log Message:
  -----------
  docs/memory.txt: Fix document on MMIO operations

.impl.valid should be .impl.unaligned and the description needs some
fixes.

.old_portio is removed since commit b40acf99b (ioport: Switch
dispatching to memory core layer).

Signed-off-by: Fam Zheng <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 8e25c274ae5830cf879fa5d2d7f98f4d6f5aecfa
      
https://github.com/qemu/qemu/commit/8e25c274ae5830cf879fa5d2d7f98f4d6f5aecfa
  Author: Alon Levy <address@hidden>
  Date:   2014-05-07 (Wed, 07 May 2014)

  Changed paths:
    M libcacard/vreader.c

  Log Message:
  -----------
  libcacard: remove unnecessary EOL from debug prints

Signed-off-by: Alon Levy <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: ff788b6fe67f694666781f821c1af812e8c7999b
      
https://github.com/qemu/qemu/commit/ff788b6fe67f694666781f821c1af812e8c7999b
  Author: Peter Maydell <address@hidden>
  Date:   2014-05-07 (Wed, 07 May 2014)

  Changed paths:
    M arch_init.c
    M configure
    M coroutine-gthread.c
    M docs/memory.txt
    M hw/9pfs/virtio-9p-local.c
    M hw/9pfs/virtio-9p-synth.c
    M hw/core/qdev.c
    M hw/mips/mips_fulong2e.c
    M hw/net/cadence_gem.c
    M hw/net/vmxnet3.c
    M hw/net/xgmac.c
    M hw/ppc/spapr_iommu.c
    M hw/ppc/spapr_rtas.c
    M hw/s390x/event-facility.c
    M hw/scsi/scsi-bus.c
    M hw/xen/xen_backend.c
    M include/exec/memory.h
    M include/glib-compat.h
    M include/qemu-common.h
    M libcacard/vcard_emul_nss.c
    M libcacard/vreader.c
    M monitor.c
    M qemu-timer.c
    M qga/main.c
    M qmp.c
    M tests/tcg/Makefile
    M tests/tcg/test_path.c
    M ui/console.c
    M util/osdep.c
    M util/readline.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-2014-05-07' 
into staging

trivial patches for 2014-05-07

# gpg: Signature made Wed 07 May 2014 18:01:15 BST using RSA key ID A4C3D7DB
# gpg: Good signature from "Michael Tokarev <address@hidden>"
# gpg:                 aka "Michael Tokarev <address@hidden>"
# gpg:                 aka "Michael Tokarev <address@hidden>"
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 6EE1 95D1 886E 8FFB 810D  4324 457C E0A0 8044 65C5
#      Subkey fingerprint: 6F67 E18E 7C91 C5B1 5514  66A7 BEE5 9D74 A4C3 D7DB

* remotes/mjt/tags/trivial-patches-2014-05-07: (21 commits)
  libcacard: remove unnecessary EOL from debug prints
  docs/memory.txt: Fix document on MMIO operations
  readline: Sort completions before printing them.
  readline: use g_strndup instead of open-coding it
  qmp: report path ambiguity error
  libcacard: replace pstrcpy() with memcpy()
  glib: move g_poll() replacement into glib-compat.h
  do not call g_thread_init() for glib >= 2.31
  hw/9pfs: Add include file for exported symbol
  xen: remove unused global, xen_xcg
  hw: Add missing 'static' attributes
  qemu-timer: Add missing 'static' attribute
  ui: Add missing 'static' attribute
  monitor: Add missing 'static' attribute
  hw/s390x: Add missing 'static' attribute
  hw/mips: Add missing 'static' and 'const' attributes
  hw/9pfs: Add missing 'static' attributes
  arch_init: Be sure of only one exit entry with DPRINTF() for ram_load()
  tests/tcg: Fix compilation of test_path
  qga: Fix typo (plural) in comment
  ...

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/5894145a26af...ff788b6fe67f