[Qemu-commits] [qemu/qemu] 02d160: slirp: Remove default

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 02d160: slirp: Remove default_mon usage

From:	GitHub
Subject:	[Qemu-commits] [qemu/qemu] 02d160: slirp: Remove default_mon usage
Date:	Mon, 28 Apr 2014 06:00:09 -0700
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 02d16089802234f4883a4792300889d2823cbb77
      
https://github.com/qemu/qemu/commit/02d16089802234f4883a4792300889d2823cbb77
  Author: Cole Robinson <address@hidden>
  Date:   2014-04-25 (Fri, 25 Apr 2014)

  Changed paths:
    M slirp/misc.c
    M slirp/slirp.c
    M slirp/slirp.h

  Log Message:
  -----------
  slirp: Remove default_mon usage

These errors don't seem user initiated, so forcibly printing to the
monitor doesn't seem right. Just use error_report.

Drop lprint since it's now unused.

Cc: Jan Kiszka <address@hidden>

Signed-off-by: Cole Robinson <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 027a79c373954920d5e9a1d0bafe1f315a2cd624
      
https://github.com/qemu/qemu/commit/027a79c373954920d5e9a1d0bafe1f315a2cd624
  Author: Cole Robinson <address@hidden>
  Date:   2014-04-25 (Fri, 25 Apr 2014)

  Changed paths:
    M ui/vnc.c

  Log Message:
  -----------
  vnc: Remove default_mon usage

These errors don't seem user initiated, so forcibly printing to the
monitor doesn't seem right. Just use error_report.

Cc: Anthony Liguori <address@hidden>
Cc: Gerd Hoffmann <address@hidden>
Signed-off-by: Cole Robinson <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: d876f60d14d491c27719bafeaed21669e15348a3
      
https://github.com/qemu/qemu/commit/d876f60d14d491c27719bafeaed21669e15348a3
  Author: Cole Robinson <address@hidden>
  Date:   2014-04-25 (Fri, 25 Apr 2014)

  Changed paths:
    M include/qemu/error-report.h
    M util/qemu-error.c

  Log Message:
  -----------
  error: Privatize error_print_loc

Cc: Luiz Capitulino <address@hidden>
Cc: Markus Armbruster <address@hidden>
Signed-off-by: Cole Robinson <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 4a66d3bf9ad3d121c32375081dc1379c3478fdb8
      
https://github.com/qemu/qemu/commit/4a66d3bf9ad3d121c32375081dc1379c3478fdb8
  Author: Cole Robinson <address@hidden>
  Date:   2014-04-25 (Fri, 25 Apr 2014)

  Changed paths:
    M include/monitor/monitor.h
    M monitor.c
    M stubs/Makefile.objs
    R stubs/mon-print-filename.c

  Log Message:
  -----------
  monitor: Remove unused monitor_print_filename

Cc: Luiz Capitulino <address@hidden>
Cc: Markus Armbruster <address@hidden>
Signed-off-by: Cole Robinson <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 4ad417baa43424b6b988c52b83989fd95670c113
      
https://github.com/qemu/qemu/commit/4ad417baa43424b6b988c52b83989fd95670c113
  Author: Cole Robinson <address@hidden>
  Date:   2014-04-25 (Fri, 25 Apr 2014)

  Changed paths:
    M util/qemu-error.c

  Log Message:
  -----------
  error: Print error_report() to stderr if using qmp

monitor_printf will drop the requested output if cur_mon is qmp (for
good reason). However these messages are often helpful for debugging
issues with via libvirt.

If we know the message won't hit the monitor, send it to stderr.

Cc: Luiz Capitulino <address@hidden>
Cc: Markus Armbruster <address@hidden>
Signed-off-by: Cole Robinson <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: d73f0beadb57f885e678bffc362864f4401262e0
      
https://github.com/qemu/qemu/commit/d73f0beadb57f885e678bffc362864f4401262e0
  Author: Cole Robinson <address@hidden>
  Date:   2014-04-25 (Fri, 25 Apr 2014)

  Changed paths:
    M include/qapi/qmp/qerror.h

  Log Message:
  -----------
  qerror.h: Remove unused error classes

Cc: Luiz Capitulino <address@hidden>
Cc: Markus Armbruster <address@hidden>
Signed-off-by: Cole Robinson <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: f231b88db14f13ee9a41599896f57f3594c1ca8b
      
https://github.com/qemu/qemu/commit/f231b88db14f13ee9a41599896f57f3594c1ca8b
  Author: Cole Robinson <address@hidden>
  Date:   2014-04-25 (Fri, 25 Apr 2014)

  Changed paths:
    M block/commit.c
    M blockdev.c
    M hw/9pfs/virtio-9p.c
    M hw/core/qdev-properties.c
    M hw/misc/ivshmem.c
    M include/qapi/qmp/qerror.h
    M qapi/qmp-dispatch.c
    M qapi/qmp-input-visitor.c
    M qdev-monitor.c
    M qmp.c
    M qobject/json-parser.c
    M qom/object.c
    M savevm.c
    M util/qemu-config.c
    M util/qemu-option.c

  Log Message:
  -----------
  qerror.h: Remove QERR defines that are only used once

Just hardcode them in the callers

Cc: Luiz Capitulino <address@hidden>
Cc: Markus Armbruster <address@hidden>
Signed-off-by: Cole Robinson <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 0b15abfcbcb6d4f658bf92d618386f79a7f7e9e8
      
https://github.com/qemu/qemu/commit/0b15abfcbcb6d4f658bf92d618386f79a7f7e9e8
  Author: Cole Robinson <address@hidden>
  Date:   2014-04-25 (Fri, 25 Apr 2014)

  Changed paths:
    M blockjob.c
    M include/qapi/qmp/qerror.h
    M stubs/arch-query-cpu-def.c

  Log Message:
  -----------
  qerror.h: Replace QERR_NOT_SUPPORTED with QERR_UNSUPPORTED

The former is only used twice, the latter is used over 30 times, and
has a nicer error message.

Cc: Luiz Capitulino <address@hidden>
Cc: Markus Armbruster <address@hidden>
Signed-off-by: Cole Robinson <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 073a341151ecd02b4d4b7ae01ce7c3ff4e9b71f8
      
https://github.com/qemu/qemu/commit/073a341151ecd02b4d4b7ae01ce7c3ff4e9b71f8
  Author: Cole Robinson <address@hidden>
  Date:   2014-04-25 (Fri, 25 Apr 2014)

  Changed paths:
    M include/qapi/qmp/qerror.h
    M util/error.c

  Log Message:
  -----------
  error: Remove some unused headers

Makes it a bit clear how the interdependencies work.

Cc: Luiz Capitulino <address@hidden>
Cc: Markus Armbruster <address@hidden>
Signed-off-by: Cole Robinson <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: f7bdc41acc0f9e3f35562ff6a2c37d1a09b79b7b
      
https://github.com/qemu/qemu/commit/f7bdc41acc0f9e3f35562ff6a2c37d1a09b79b7b
  Author: Hani Benhabiles <address@hidden>
  Date:   2014-04-25 (Fri, 25 Apr 2014)

  Changed paths:
    M hmp-commands.hx

  Log Message:
  -----------
  monitor: Fix drive_del id argument type completion.

Signed-off-by: Hani Benhabiles <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: bfa40f77af05731e2e976c5aa8c4edc86a87acd3
      
https://github.com/qemu/qemu/commit/bfa40f77af05731e2e976c5aa8c4edc86a87acd3
  Author: Hani Benhabiles <address@hidden>
  Date:   2014-04-25 (Fri, 25 Apr 2014)

  Changed paths:
    M hmp-commands.hx
    M hmp.h
    M monitor.c

  Log Message:
  -----------
  monitor: Add command_completion callback to mon_cmd_t.

Convert object_add and object_del commands to use the new callback.

Signed-off-by: Hani Benhabiles <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 2da1b3abbccd267f09ebda7ba604fbbb0220f406
      
https://github.com/qemu/qemu/commit/2da1b3abbccd267f09ebda7ba604fbbb0220f406
  Author: Hani Benhabiles <address@hidden>
  Date:   2014-04-25 (Fri, 25 Apr 2014)

  Changed paths:
    M hmp-commands.hx
    M hmp.h
    M monitor.c

  Log Message:
  -----------
  monitor: Add device_add and device_del completion.

Also fix device_add completion including non-hotpluggable devices.

Signed-off-by: Hani Benhabiles <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: c3481247e58ff3f13337ce0a262b058799bd156c
      
https://github.com/qemu/qemu/commit/c3481247e58ff3f13337ce0a262b058799bd156c
  Author: Eduardo Habkost <address@hidden>
  Date:   2014-04-25 (Fri, 25 Apr 2014)

  Changed paths:
    M qmp.c

  Log Message:
  -----------
  qmp: object-add: Validate class before creating object

Currently it is very easy to crash QEMU by issuing an object-add command
using an abstract class or a class that doesn't support
TYPE_USER_CREATABLE as parameter.

Example: with the following QMP command:

    (QEMU) object-add qom-type=cpu id=foo

QEMU aborts at:

    ERROR:qom/object.c:335:object_initialize_with_type: assertion failed: 
(type->abstract == false)

This patch moves the check for TYPE_USER_CREATABLE before object_new(),
and adds a check to prevent the code from trying to instantiate abstract
classes.

Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Matthew Rosato <address@hidden>
Tested-by: Matthew Rosato <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: c20499d9854e5d04710f17d577df65ed7c7aacf1
      
https://github.com/qemu/qemu/commit/c20499d9854e5d04710f17d577df65ed7c7aacf1
  Author: Qiao Nuohan <address@hidden>
  Date:   2014-04-25 (Fri, 25 Apr 2014)

  Changed paths:
    M hmp-commands.hx

  Log Message:
  -----------
  HMP: fix doc of dump-guest-memory

Signed-off-by: Qiao Nuohan <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 1b7a0f758bb3e49c8468fd2af75ebb215b26e6f4
      
https://github.com/qemu/qemu/commit/1b7a0f758bb3e49c8468fd2af75ebb215b26e6f4
  Author: Qiao Nuohan <address@hidden>
  Date:   2014-04-25 (Fri, 25 Apr 2014)

  Changed paths:
    M hmp-commands.hx
    M hmp.c

  Log Message:
  -----------
  HMP: support specifying dump format for dump-guest-memory

Dumping guest memory is available to specify the dump format now. This patch
adds options '-z|-l|-s' to HMP command dump-guest-memory to specify dumping in
kdump-compression format, with zlib/lzo/snappy compression. And without these
options ELF format will be used.

The discussion about this feature is here:

http://lists.nongnu.org/archive/html/qemu-devel/2014-03/msg04235.html

Signed-off-by: Qiao Nuohan <address@hidden>
Suggested-by: Christian Borntraeger <address@hidden>
Tested-by: Christian Borntraeger <address@hidden> (on s390x/kvm)
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 0b9f0e2fd7c5070fa06cd6bd5ec69055e3a7d2b1
      
https://github.com/qemu/qemu/commit/0b9f0e2fd7c5070fa06cd6bd5ec69055e3a7d2b1
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2014-04-25 (Fri, 25 Apr 2014)

  Changed paths:
    M monitor.c

  Log Message:
  -----------
  monitor: fix qmp_getfd() fd leak in error case

qemu_chr_fe_get_msgfd() transfers ownership of the file descriptor to
the caller.  Therefore all code paths in qmp_getfd() should either
register the file descriptor somewhere or close it.

Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 13de54eedd40a1b01fa7176dfb96d1c22c5cfa71
      
https://github.com/qemu/qemu/commit/13de54eedd40a1b01fa7176dfb96d1c22c5cfa71
  Author: Peter Maydell <address@hidden>
  Date:   2014-04-28 (Mon, 28 Apr 2014)

  Changed paths:
    M block/commit.c
    M blockdev.c
    M blockjob.c
    M hmp-commands.hx
    M hmp.c
    M hmp.h
    M hw/9pfs/virtio-9p.c
    M hw/core/qdev-properties.c
    M hw/misc/ivshmem.c
    M include/monitor/monitor.h
    M include/qapi/qmp/qerror.h
    M include/qemu/error-report.h
    M monitor.c
    M qapi/qmp-dispatch.c
    M qapi/qmp-input-visitor.c
    M qdev-monitor.c
    M qmp.c
    M qobject/json-parser.c
    M qom/object.c
    M savevm.c
    M slirp/misc.c
    M slirp/slirp.c
    M slirp/slirp.h
    M stubs/Makefile.objs
    M stubs/arch-query-cpu-def.c
    R stubs/mon-print-filename.c
    M ui/vnc.c
    M util/error.c
    M util/qemu-config.c
    M util/qemu-error.c
    M util/qemu-option.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/qmp-unstable/queue/qmp' into staging

* remotes/qmp-unstable/queue/qmp:
  monitor: fix qmp_getfd() fd leak in error case
  HMP: support specifying dump format for dump-guest-memory
  HMP: fix doc of dump-guest-memory
  qmp: object-add: Validate class before creating object
  monitor: Add device_add and device_del completion.
  monitor: Add command_completion callback to mon_cmd_t.
  monitor: Fix drive_del id argument type completion.
  error: Remove some unused headers
  qerror.h: Replace QERR_NOT_SUPPORTED with QERR_UNSUPPORTED
  qerror.h: Remove QERR defines that are only used once
  qerror.h: Remove unused error classes
  error: Print error_report() to stderr if using qmp
  monitor: Remove unused monitor_print_filename
  error: Privatize error_print_loc
  vnc: Remove default_mon usage
  slirp: Remove default_mon usage

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/a41b2c995b52...13de54eedd40
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] 02d160: slirp: Remove default_mon usage, GitHub <=
Prev by Date: [Qemu-commits] [qemu/qemu] 1ba4b6: block: Prevent coroutine stack overflow when recur...
Next by Date: [Qemu-commits] [qemu/qemu] eb6282: misc: Use cpu_physical_memory_read and cpu_physica...
Previous by thread: [Qemu-commits] [qemu/qemu] 1ba4b6: block: Prevent coroutine stack overflow when recur...
Next by thread: [Qemu-commits] [qemu/qemu] eb6282: misc: Use cpu_physical_memory_read and cpu_physica...
Index(es):
- Date
- Thread