qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 482f38: acpi: fix incorrect encoding for 0x{F


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 482f38: acpi: fix incorrect encoding for 0x{F-1}FFFF
Date: Mon, 14 Apr 2014 08:00:05 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 482f38b9488cb42939b92332ca7b5b42af882cd0
      
https://github.com/qemu/qemu/commit/482f38b9488cb42939b92332ca7b5b42af882cd0
  Author: Igor Mammedov <address@hidden>
  Date:   2014-04-14 (Mon, 14 Apr 2014)

  Changed paths:
    M hw/i386/acpi-build.c

  Log Message:
  -----------
  acpi: fix incorrect encoding for 0x{F-1}FFFF

Fix typo in build_append_int() which causes integer
truncation when it's in range 0x{F-1}FFFF by packing it
as WordConst instead of required DWordConst.

In partucular this fixes a regression: hotplug in slots 16,17,18 and 19
didn't work, since SSDT had code like this:
           If (And (Arg0, 0x0000))
          {
              Notify (S80, Arg1)
          }

Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
Reviewed-by: Stefan Weil <address@hidden>


  Commit: 8611224a7b21db8fa1b0d12fdd053443543dd708
      
https://github.com/qemu/qemu/commit/8611224a7b21db8fa1b0d12fdd053443543dd708
  Author: Michael S. Tsirkin <address@hidden>
  Date:   2014-04-14 (Mon, 14 Apr 2014)

  Changed paths:
    M tests/acpi-test-data/pc/SSDT

  Log Message:
  -----------
  acpi-test: update expected files

commit 58b035c7354afc0c5351ea62264c01d74196ec26
    acpi: fix incorrect encoding for 0x{F-1}FFFF
changes the SSDT, update expected files accordingly.

Signed-off-by: Michael S. Tsirkin <address@hidden>


  Commit: c2b9af1d6c2dda4c58a1c0ff389d09dcd9601b9e
      
https://github.com/qemu/qemu/commit/c2b9af1d6c2dda4c58a1c0ff389d09dcd9601b9e
  Author: Peter Maydell <address@hidden>
  Date:   2014-04-14 (Mon, 14 Apr 2014)

  Changed paths:
    M hw/i386/acpi-build.c
    M tests/acpi-test-data/pc/SSDT

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging

acpi: SSDT update

This has a fix by Igor for a regression introduced by
bridge hotplug code.
Expected test files were updated accordingly.

Signed-off-by: Michael S. Tsirkin <address@hidden>

# gpg: Signature made Mon 14 Apr 2014 13:13:35 BST using RSA key ID D28D5469
# gpg: Good signature from "Michael S. Tsirkin <address@hidden>"
# gpg:                 aka "Michael S. Tsirkin <address@hidden>"

* remotes/mst/tags/for_upstream:
  acpi-test: update expected files
  acpi: fix incorrect encoding for 0x{F-1}FFFF

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/940973ae0b45...c2b9af1d6c2d

reply via email to

[Prev in Thread] Current Thread [Next in Thread]