[Qemu-commits] [qemu/qemu] 0d0e04: gtk: Use gtk generic event signal instead of motio...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 0d0e044dee0ed59628bb093a5be03528d6bde445
      
https://github.com/qemu/qemu/commit/0d0e044dee0ed59628bb093a5be03528d6bde445
  Author: Takashi Iwai <address@hidden>
  Date:   2014-04-07 (Mon, 07 Apr 2014)

  Changed paths:
    M ui/gtk.c

  Log Message:
  -----------
  gtk: Use gtk generic event signal instead of motion-notify-event

The GDK motion-notify-event isn't generated when the pointer goes out
of the target window even if the pointer is grabbed, which essentially
means to lose the pointer tracking in gtk-ui.

Meanwhile the generic "event" signal is sent when the pointer is
grabbed, so we can use this and pick the motion notify events manually
there instead.

Reference: https://bugzilla.novell.com/show_bug.cgi?id=849587
Tested-by: Cole Robinson <address@hidden>
Reviewed-by: Cole Robinson <address@hidden>
Tested-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Takashi Iwai <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: e61031cdd81826c433a8bbfa3aca2bae4ffaf845
      
https://github.com/qemu/qemu/commit/e61031cdd81826c433a8bbfa3aca2bae4ffaf845
  Author: Takashi Iwai <address@hidden>
  Date:   2014-04-07 (Mon, 07 Apr 2014)

  Changed paths:
    M ui/gtk.c

  Log Message:
  -----------
  gtk: Fix the relative pointer tracking mode

The relative pointer tracking mode was still buggy even after the
previous fix of the motion-notify-event since the events are filtered
out when the pointer moves outside the drawing window due to the
boundary check for the absolute mode.

This patch fixes the issue by moving the unnecessary boundary check
into the if block of absolute mode, and keep the coordinate in the
relative mode even if it's outside the drawing area.  But this makes
the coordinate (last_x, last_y) possibly pointing to (-1,-1),
introduce a new flag to indicate the last coordinate has been
updated.

Reference: https://bugzilla.novell.com/show_bug.cgi?id=849587
Tested-by: Cole Robinson <address@hidden>
Reviewed-by: Cole Robinson <address@hidden>
Tested-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Takashi Iwai <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: ecce1929bcb0d8f4efde39df5ceb1aac42df75d4
      
https://github.com/qemu/qemu/commit/ecce1929bcb0d8f4efde39df5ceb1aac42df75d4
  Author: Takashi Iwai <address@hidden>
  Date:   2014-04-07 (Mon, 07 Apr 2014)

  Changed paths:
    M ui/gtk.c

  Log Message:
  -----------
  gtk: Remember the last grabbed pointer position

It's pretty annoying that the pointer reappears at a random place once
after grabbing and ungrabbing the input.  Better to restore to the
original position where the pointer was grabbed.

Reference: https://bugzilla.novell.com/show_bug.cgi?id=849587
Tested-by: Cole Robinson <address@hidden>
Reviewed-by: Cole Robinson <address@hidden>
Tested-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Takashi Iwai <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 25eccc37ff91254efdd123f5dafb37526a83a990
      
https://github.com/qemu/qemu/commit/25eccc37ff91254efdd123f5dafb37526a83a990
  Author: Gerd Hoffmann <address@hidden>
  Date:   2014-04-07 (Mon, 07 Apr 2014)

  Changed paths:
    M MAINTAINERS

  Log Message:
  -----------
  ui: Update MAINTAINERS entry.

With Amazon eating Anthonys time status "Maintained" certainly isn't
true any more.  Update entry accordingly.

Also add myself, so scripts/get_maintainer.pl will Cc: me, to reduce
the chance ui patches fall through the cracks on our pretty loaded
qemu-devel mailing list.

Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: e20c016e322e0c977ab332322c3a882c119eb1d4
      
https://github.com/qemu/qemu/commit/e20c016e322e0c977ab332322c3a882c119eb1d4
  Author: Peter Maydell <address@hidden>
  Date:   2014-04-07 (Mon, 07 Apr 2014)

  Changed paths:
    M MAINTAINERS
    M ui/gtk.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/kraxel/tags/pull-gtk-4' into staging

gtk: pointer fixes from Takashi Iwai.

# gpg: Signature made Mon 07 Apr 2014 09:51:52 BST using RSA key ID D3E87138
# gpg: Good signature from "Gerd Hoffmann (work) <address@hidden>"
# gpg:                 aka "Gerd Hoffmann <address@hidden>"
# gpg:                 aka "Gerd Hoffmann (private) <address@hidden>"

* remotes/kraxel/tags/pull-gtk-4:
  ui: Update MAINTAINERS entry.
  gtk: Remember the last grabbed pointer position
  gtk: Fix the relative pointer tracking mode
  gtk: Use gtk generic event signal instead of motion-notify-event

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/466e6e9d13d5...e20c016e322e