qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] d581eb: scsi-bus: remove bogus assertion


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] d581eb: scsi-bus: remove bogus assertion
Date: Thu, 03 Apr 2014 05:00:05 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: d581eb7ca4b58649ade5fb7570ecf6b4b9a41879
      
https://github.com/qemu/qemu/commit/d581eb7ca4b58649ade5fb7570ecf6b4b9a41879
  Author: Paolo Bonzini <address@hidden>
  Date:   2014-04-02 (Wed, 02 Apr 2014)

  Changed paths:
    M hw/scsi/scsi-bus.c

  Log Message:
  -----------
  scsi-bus: remove bogus assertion

This assertion is invalid, because get_sg_list can return an
empty sg-list even for commands that transfer no data (such
as SYNCHRONIZE CACHE).

Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 27898a5daa4c6d28adb32b401a011d7198494482
      
https://github.com/qemu/qemu/commit/27898a5daa4c6d28adb32b401a011d7198494482
  Author: Paolo Bonzini <address@hidden>
  Date:   2014-04-03 (Thu, 03 Apr 2014)

  Changed paths:
    M block/iscsi.c

  Log Message:
  -----------
  iscsi: recognize "invalid field" ASCQ from WRITE SAME command

Some targets may return "invalid field" as the ASCQ from WRITE SAME
if they support the command only without the UNMAP field.  Recognize
that, and return ENOTSUP just like for "invalid operation code".

Reviewed-by: Peter Lieven <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: b2f9c08a4f11f16ec101e95feab8e71d7cfcfee9
      
https://github.com/qemu/qemu/commit/b2f9c08a4f11f16ec101e95feab8e71d7cfcfee9
  Author: Paolo Bonzini <address@hidden>
  Date:   2014-04-03 (Thu, 03 Apr 2014)

  Changed paths:
    M block/iscsi.c

  Log Message:
  -----------
  iscsi: ignore flushes on scsi-generic devices

Non-block SCSI devices do not support flushing, but we may still send
them requests via bdrv_flush_all.  Just ignore them.

Reviewed-by: Peter Lieven <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: c97ca29db0a68deb281a901f535cec5ea4862244
      
https://github.com/qemu/qemu/commit/c97ca29db0a68deb281a901f535cec5ea4862244
  Author: Paolo Bonzini <address@hidden>
  Date:   2014-04-03 (Thu, 03 Apr 2014)

  Changed paths:
    M block/iscsi.c

  Log Message:
  -----------
  iscsi: always query max WRITE SAME length

Max WRITE SAME length is also used when the UNMAP bit is zero, so it
should be queried even if LBPWS=0.  Same for the optimal transfer
length.

However, the write_zeroes_alignment only matters for UNMAP=1 so we
still restrict it to LBPWS=1.

Reviewed-by: Peter Lieven <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>


  Commit: 784a5592c9e7721d9035a83570f09a286cf75284
      
https://github.com/qemu/qemu/commit/784a5592c9e7721d9035a83570f09a286cf75284
  Author: Peter Maydell <address@hidden>
  Date:   2014-04-03 (Thu, 03 Apr 2014)

  Changed paths:
    M block/iscsi.c
    M hw/scsi/scsi-bus.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/bonzini/scsi-next' into staging

* remotes/bonzini/scsi-next:
  iscsi: always query max WRITE SAME length
  iscsi: ignore flushes on scsi-generic devices
  iscsi: recognize "invalid field" ASCQ from WRITE SAME command
  scsi-bus: remove bogus assertion

Signed-off-by: Peter Maydell <address@hidden>


  Commit: 87d8354de3560eb705bcee83142d775f703177a6
      
https://github.com/qemu/qemu/commit/87d8354de3560eb705bcee83142d775f703177a6
  Author: Alexander Graf <address@hidden>
  Date:   2014-04-03 (Thu, 03 Apr 2014)

  Changed paths:
    M hw/intc/openpic_kvm.c

  Log Message:
  -----------
  PPC: openpic_kvm: Filter memory events properly

Commit 6f1834a2b exposed a bug in openpic_kvm where we don't filter
for memory events that only happen to the region we want to know
events about.

Add proper filtering, fixing the e500plat target with KVM.

Signed-off-by: Alexander Graf <address@hidden>
Message-id: address@hidden
Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/97891afab801...87d8354de356

reply via email to

[Prev in Thread] Current Thread [Next in Thread]