qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 96b8ca: Revert "qtest: Fix crash if SIGABRT d

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 96b8ca: Revert "qtest: Fix crash if SIGABRT during qtest_i...
Date: Tue, 01 Apr 2014 09:30:05 -0700 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 96b8ca47f8f21ba32a60930cddbf5da27d36b20d
      
https://github.com/qemu/qemu/commit/96b8ca47f8f21ba32a60930cddbf5da27d36b20d
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2014-03-31 (Mon, 31 Mar 2014)

  Changed paths:
    M tests/libqtest.c
    M tests/libqtest.h

  Log Message:
  -----------
  Revert "qtest: Fix crash if SIGABRT during qtest_init()"

It turns out there are test cases that use multiple libqtest instances.
We cannot use a global qtest instance in the SIGABRT handler.

This reverts commit cb201b4872f16dfbce63f8648b2584631e2e965f.

Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: d766825190615bc0b1b57d2837475cdec1a075de
      
https://github.com/qemu/qemu/commit/d766825190615bc0b1b57d2837475cdec1a075de
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2014-03-31 (Mon, 31 Mar 2014)

  Changed paths:
    M tests/libqtest.c

  Log Message:
  -----------
  qtest: Keep list of qtest instances for SIGABRT handler

Keep track of active qtest instances so we can kill them when the test
aborts.  This ensures no QEMU processes are left running after test
failure.

Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Marcel Apfelbaum <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 087570942994db2550b0aa377fedca2235373004
      
https://github.com/qemu/qemu/commit/087570942994db2550b0aa377fedca2235373004
  Author: Stefan Weil <address@hidden>
  Date:   2014-03-31 (Mon, 31 Mar 2014)

  Changed paths:
    M tests/test-aio.c

  Log Message:
  -----------
  tests: Remove unsupported tests for MinGW

test_timer_schedule and test_source_timer_schedule don't compile for MinGW
because some functions are not implemented for MinGW (qemu_pipe,
aio_set_fd_handler).

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: d597a32a6dc5b2ef58b280100cd551b7fb30c963
      
https://github.com/qemu/qemu/commit/d597a32a6dc5b2ef58b280100cd551b7fb30c963
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2014-03-31 (Mon, 31 Mar 2014)

  Changed paths:
    M tests/Makefile

  Log Message:
  -----------
  tests: Skip POSIX-only tests on Windows

test-rfifolock and test-vmstate only build on POSIX hosts.  Exclude them
if building for Windows.

Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Stefan Weil <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 5c4e24c1516b6b8c21b6defcd4ffcf05f21202f7
      
https://github.com/qemu/qemu/commit/5c4e24c1516b6b8c21b6defcd4ffcf05f21202f7
  Author: Stefan Hajnoczi <address@hidden>
  Date:   2014-03-31 (Mon, 31 Mar 2014)

  Changed paths:
    M tests/Makefile

  Log Message:
  -----------
  tests: Correctly skip qtest on non-POSIX hosts

qtest test cases only work on POSIX hosts.  The following line only
defines dependencies for qtest binaries on POSIX hosts:

  check-qtest-$(CONFIG_POSIX)=$(foreach 
TARGET,$(TARGETS),$(check-qtest-$(TARGET)-y))

But the QTEST_TARGETS definition earlier in the Makefile fails to check
CONFIG_POSIX.  This causes make targets to be generated for qtest test
cases even though we don't know how to build the binaries.

The following error message is printed when trying to run gtester on a
binary that was never built:

  GLib-WARNING **: Failed to execute test binary: tests/endianness-test.exe: 
Failed to execute child process "tests/endianness-test.exe" (No such file or 
directory)

This patch makes QTEST_TARGETS empty on non-POSIX hosts.  This prevents
the targets from being generated.

Signed-off-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 592408b8cab08bb4ec4771d7b1e20343b7f072fc
      
https://github.com/qemu/qemu/commit/592408b8cab08bb4ec4771d7b1e20343b7f072fc
  Author: Andreas Färber <address@hidden>
  Date:   2014-03-31 (Mon, 31 Mar 2014)

  Changed paths:
    M hw/block/nvme.c

  Log Message:
  -----------
  nvme: Permit zero-length block devices

It may not be sensible for normal use cases, but it allows to use
/dev/null in QTest.

Acked-by: Keith Busch <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: fc9677915cc1273b4757a911f27f2f5038168053
      
https://github.com/qemu/qemu/commit/fc9677915cc1273b4757a911f27f2f5038168053
  Author: Andreas Färber <address@hidden>
  Date:   2014-03-31 (Mon, 31 Mar 2014)

  Changed paths:
    M MAINTAINERS
    M tests/Makefile
    A tests/nvme-test.c

  Log Message:
  -----------
  tests: Add nvme qtest

Acked-by: Keith Busch <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 2d888c099cb89eea0c5329d66abf6cd2865eed8a
      
https://github.com/qemu/qemu/commit/2d888c099cb89eea0c5329d66abf6cd2865eed8a
  Author: Andreas Färber <address@hidden>
  Date:   2014-03-31 (Mon, 31 Mar 2014)

  Changed paths:
    M MAINTAINERS
    M tests/Makefile
    A tests/virtio-9p-test.c

  Log Message:
  -----------
  tests: Add virtio-9p qtest

Make it conditional to 9p availability.
Create a temporary directory to share.

Signed-off-by: Andreas Färber <address@hidden>


  Commit: abc53733f34a8a29cc49c1ecb6475a11a44dcb7a
      
https://github.com/qemu/qemu/commit/abc53733f34a8a29cc49c1ecb6475a11a44dcb7a
  Author: Andreas Färber <address@hidden>
  Date:   2014-03-31 (Mon, 31 Mar 2014)

  Changed paths:
    M tests/Makefile
    A tests/pvpanic-test.c

  Log Message:
  -----------
  tests: Add pvpanic qtest

Signed-off-by: Andreas Färber <address@hidden>


  Commit: 66e0c7b187e130f5059e45e12832951deda31668
      
https://github.com/qemu/qemu/commit/66e0c7b187e130f5059e45e12832951deda31668
  Author: Andreas Färber <address@hidden>
  Date:   2014-03-31 (Mon, 31 Mar 2014)

  Changed paths:
    M tests/libqtest.c
    M tests/libqtest.h

  Log Message:
  -----------
  qtest: Factor out qtest_qmp_receive()

Signed-off-by: Andreas Färber <address@hidden>


  Commit: 627b1a17ced89e13df34a85feef54a50e9b94191
      
https://github.com/qemu/qemu/commit/627b1a17ced89e13df34a85feef54a50e9b94191
  Author: Andreas Färber <address@hidden>
  Date:   2014-03-31 (Mon, 31 Mar 2014)

  Changed paths:
    M tests/pvpanic-test.c

  Log Message:
  -----------
  pvpanic-test: Assert pause event

Signed-off-by: Andreas Färber <address@hidden>


  Commit: e683eb9ecc5cb72a6e89ddacaf097cb8fa839584
      
https://github.com/qemu/qemu/commit/e683eb9ecc5cb72a6e89ddacaf097cb8fa839584
  Author: Andreas Färber <address@hidden>
  Date:   2014-03-31 (Mon, 31 Mar 2014)

  Changed paths:
    M tests/Makefile
    A tests/i82801b11-test.c

  Log Message:
  -----------
  tests: Add i82801b11 qtest

Signed-off-by: Andreas Färber <address@hidden>


  Commit: efdf6a56a7c73753dd135ed085a223a119b5d805
      
https://github.com/qemu/qemu/commit/efdf6a56a7c73753dd135ed085a223a119b5d805
  Author: Paolo Bonzini <address@hidden>
  Date:   2014-03-31 (Mon, 31 Mar 2014)

  Changed paths:
    M hw/misc/tmp105.c

  Log Message:
  -----------
  tmp105: Read temperature in milli-celsius

Right now, the temperature property must be written in milli-celsius,
but it reads back the value in 8.8 fixed point.  Fix this by letting the
property read back the original value (possibly rounded).  Also simplify
the code that does the conversion.

Before:

    (QEMU) qom-set path=/machine/peripheral/sensor property=temperature 
value=20000
    {u'return': {}}
    (QEMU) qom-get path=sensor property=temperature
    {u'return': 5120}

After:

    (QEMU) qom-set path=/machine/peripheral/sensor property=temperature 
value=20000
    {u'return': {}}
    (QEMU) qom-get path=sensor property=temperature
    {u'return': 20000}

Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: cebac614983a7479f2cd3b903e2127edd865c013
      
https://github.com/qemu/qemu/commit/cebac614983a7479f2cd3b903e2127edd865c013
  Author: Paolo Bonzini <address@hidden>
  Date:   2014-03-31 (Mon, 31 Mar 2014)

  Changed paths:
    M tests/tmp105-test.c

  Log Message:
  -----------
  tmp105-test: Wrap simple building blocks for testing

The next patches will add more reads and writes.  Add a simple testing
API for this.

Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: a4ec5bb7188490ad65b916a4a2e6ea7129602b60
      
https://github.com/qemu/qemu/commit/a4ec5bb7188490ad65b916a4a2e6ea7129602b60
  Author: Paolo Bonzini <address@hidden>
  Date:   2014-03-31 (Mon, 31 Mar 2014)

  Changed paths:
    M tests/tmp105-test.c

  Log Message:
  -----------
  tmp105-test: Add a second sensor and test that one

This will make it easier to reach the device under test via QOM.

Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 7373fc76930fc0994bab1bc2defd1d3a2b2adaa3
      
https://github.com/qemu/qemu/commit/7373fc76930fc0994bab1bc2defd1d3a2b2adaa3
  Author: Paolo Bonzini <address@hidden>
  Date:   2014-03-31 (Mon, 31 Mar 2014)

  Changed paths:
    M tests/tmp105-test.c

  Log Message:
  -----------
  tmp105-test: Test QOM property and precision

This adds a regression test for commit
efdf6a56a7c73753dd135ed085a223a119b5d805 (tmp105: Read temperature in
milli-celsius).

Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 95224e87a71d3190f46bf543ec9bc59ae36050eb
      
https://github.com/qemu/qemu/commit/95224e87a71d3190f46bf543ec9bc59ae36050eb
  Author: Peter Maydell <address@hidden>
  Date:   2014-03-31 (Mon, 31 Mar 2014)

  Changed paths:
    M MAINTAINERS
    M hw/block/nvme.c
    M hw/misc/tmp105.c
    M tests/Makefile
    A tests/i82801b11-test.c
    M tests/libqtest.c
    M tests/libqtest.h
    A tests/nvme-test.c
    A tests/pvpanic-test.c
    M tests/test-aio.c
    M tests/tmp105-test.c
    A tests/virtio-9p-test.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/afaerber/tags/qom-devices-for-2.0' into 
staging

QOM/QTest infrastructure fixes

* Revised QTest SIGABRT fix
* Test cleanups for non-POSIX hosts
* QTest test cases for NVMe, virtio-9p, pvpanic, i82801b11
* QTest API addition for reading events
* TMP105 fix and regression test

# gpg: Signature made Mon 31 Mar 2014 22:08:10 BST using RSA key ID 3E7E013F
# gpg: Good signature from "Andreas Färber <address@hidden>"
# gpg:                 aka "Andreas Färber <address@hidden>"

* remotes/afaerber/tags/qom-devices-for-2.0:
  tmp105-test: Test QOM property and precision
  tmp105-test: Add a second sensor and test that one
  tmp105-test: Wrap simple building blocks for testing
  tmp105: Read temperature in milli-celsius
  tests: Add i82801b11 qtest
  pvpanic-test: Assert pause event
  qtest: Factor out qtest_qmp_receive()
  tests: Add pvpanic qtest
  tests: Add virtio-9p qtest
  tests: Add nvme qtest
  nvme: Permit zero-length block devices
  tests: Correctly skip qtest on non-POSIX hosts
  tests: Skip POSIX-only tests on Windows
  tests: Remove unsupported tests for MinGW
  qtest: Keep list of qtest instances for SIGABRT handler
  Revert "qtest: Fix crash if SIGABRT during qtest_init()"

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/63678e17cf39...95224e87a71d
reply via email to
[Prev in Thread] Current Thread [Next in Thread]