[Qemu-commits] [qemu/qemu] ecb4e0: target-s390x: Add missing 'static' an

qemu-commits
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] ecb4e0: target-s390x: Add missing 'static' an

From:	GitHub
Subject:	[Qemu-commits] [qemu/qemu] ecb4e0: target-s390x: Add missing 'static' and 'const' att...
Date:	Thu, 27 Mar 2014 10:30:05 -0700
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: ecb4e01e3449074576ae866c4547b5ff3849ddd7
      
https://github.com/qemu/qemu/commit/ecb4e01e3449074576ae866c4547b5ff3849ddd7
  Author: Stefan Weil <address@hidden>
  Date:   2014-03-27 (Thu, 27 Mar 2014)

  Changed paths:
    M target-s390x/arch_dump.c

  Log Message:
  -----------
  target-s390x: Add missing 'static' and 'const' attributes

This fixes warnings from the static code analysis (smatch).

Signed-off-by: Stefan Weil <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 6df05bdd172d26b699fecf162c277286579f2c16
      
https://github.com/qemu/qemu/commit/6df05bdd172d26b699fecf162c277286579f2c16
  Author: Stefan Weil <address@hidden>
  Date:   2014-03-27 (Thu, 27 Mar 2014)

  Changed paths:
    M target-arm/machine.c

  Log Message:
  -----------
  target-arm: Add missing 'static' attribute

This fixes a warning from the static code analysis (smatch).

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 06ab66cfab317741ab55d164ec3530c08ce1a547
      
https://github.com/qemu/qemu/commit/06ab66cfab317741ab55d164ec3530c08ce1a547
  Author: Stefan Weil <address@hidden>
  Date:   2014-03-27 (Thu, 27 Mar 2014)

  Changed paths:
    M hw/ide/pci.c

  Log Message:
  -----------
  hw/ide: Add missing 'static' attributes

This fixes a warning from the static code analysis (smatch).

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 08cf99629d5de859aad0d54bafb2f18803a86dfe
      
https://github.com/qemu/qemu/commit/08cf99629d5de859aad0d54bafb2f18803a86dfe
  Author: Stefan Weil <address@hidden>
  Date:   2014-03-27 (Thu, 27 Mar 2014)

  Changed paths:
    M util/module.c

  Log Message:
  -----------
  util: Add 'static' attribute to function implementation

The static code analyzer smatch complains because of a missing 'static'
attribute:

util/module.c:166:6: warning:
 symbol 'module_load' was not declared. Should it be static?

'static' is used in the forward declaration, but not in the implementation.
Add it there, too.

Signed-off-by: Stefan Weil <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: a443bc3496658c9e144ad914933607ebc8418979
      
https://github.com/qemu/qemu/commit/a443bc3496658c9e144ad914933607ebc8418979
  Author: Stefan Weil <address@hidden>
  Date:   2014-03-27 (Thu, 27 Mar 2014)

  Changed paths:
    M target-i386/cpu.c
    M target-i386/kvm.c

  Log Message:
  -----------
  target-i386: Add missing 'static' and 'const' attributes

This fixes warnings from the static code analysis (smatch).

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: b533f658a98325d0e47b36113bd9f5bcc046fdae
      
https://github.com/qemu/qemu/commit/b533f658a98325d0e47b36113bd9f5bcc046fdae
  Author: Mario Smarduch <address@hidden>
  Date:   2014-03-27 (Thu, 27 Mar 2014)

  Changed paths:
    M kvm-all.c

  Log Message:
  -----------
  fix return check for KVM_GET_DIRTY_LOG ioctl

Fix return condition check from kvm_vm_ioctl(s, KVM_GET_DIRTY_LOG, &d) to
handle internal failures or no support for memory slot dirty bitmap.
Otherwise the ioctl succeeds and continues with migration.
Addresses BUG# 1294227

Signed-off-by: Mario Smarduch <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 33632788089531a4452976ff40bbb15551d37fea
      
https://github.com/qemu/qemu/commit/33632788089531a4452976ff40bbb15551d37fea
  Author: Mark Cave-Ayland <address@hidden>
  Date:   2014-03-27 (Thu, 27 Mar 2014)

  Changed paths:
    M qemu-doc.texi
    M qemu-options.hx

  Log Message:
  -----------
  doc: update sun4m documentation

A few minor tidy-ups, plus add reference to the new -vga tcx and cg3 options.

Signed-off-by: Mark Cave-Ayland <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 340fb41b311356d66b280468698b1f2d7b0c1a56
      
https://github.com/qemu/qemu/commit/340fb41b311356d66b280468698b1f2d7b0c1a56
  Author: Mark Cave-Ayland <address@hidden>
  Date:   2014-03-27 (Thu, 27 Mar 2014)

  Changed paths:
    M qemu-doc.texi

  Log Message:
  -----------
  doc: update default PowerPC framebuffer settings

Since 1.7, the default framebuffer settings for PowerPC are 800x600x32.

Signed-off-by: Mark Cave-Ayland <address@hidden>
CC: address@hidden
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: e939c6ed619e2cf98c379318f6ee389c97163f18
      
https://github.com/qemu/qemu/commit/e939c6ed619e2cf98c379318f6ee389c97163f18
  Author: Eduardo Habkost <address@hidden>
  Date:   2014-03-27 (Thu, 27 Mar 2014)

  Changed paths:
    M CODING_STYLE

  Log Message:
  -----------
  CODING_STYLE: Section about mixed declarations

We had an unwritten rule about declarations having to be at beginning of
blocks. Make it a written rule.

Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Stefan Weil <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 2cd49cbfab0dd294de421893048ab614518fa263
      
https://github.com/qemu/qemu/commit/2cd49cbfab0dd294de421893048ab614518fa263
  Author: Peter Maydell <address@hidden>
  Date:   2014-03-27 (Thu, 27 Mar 2014)

  Changed paths:
    M target-i386/cpu.h

  Log Message:
  -----------
  target-i386: Avoid shifting left into sign bit

Add 'U' suffixes where necessary to avoid (1 << 31) which
shifts left into the sign bit, which is undefined behaviour.
Add the suffix also for other constants in the same groupings
even if they don't shift into bit 31, for consistency.

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 6d55574a656f3a533a370156aaefedcf7980d4d8
      
https://github.com/qemu/qemu/commit/6d55574a656f3a533a370156aaefedcf7980d4d8
  Author: Peter Maydell <address@hidden>
  Date:   2014-03-27 (Thu, 27 Mar 2014)

  Changed paths:
    M hw/intc/apic.c

  Log Message:
  -----------
  hw/intc/apic.c: Use uint32_t for mask word in foreach_apic

Use unsigned arithmetic for operations on the mask word
in the foreach_apic() macro, to avoid relying on undefined
behaviour when shifting into the sign bit.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Stefan Weil <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: ac43fa508cc1cfe6d6f67c8eb99dc012e52c164e
      
https://github.com/qemu/qemu/commit/ac43fa508cc1cfe6d6f67c8eb99dc012e52c164e
  Author: Peter Maydell <address@hidden>
  Date:   2014-03-27 (Thu, 27 Mar 2014)

  Changed paths:
    M hw/pci/pci_host.c

  Log Message:
  -----------
  hw/pci/pci_host.c: Avoid shifting left into sign bit

Add U suffix to avoid undefined behaviour.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: d9631b90da6ac592ea76b41a654dd5d29b2645d4
      
https://github.com/qemu/qemu/commit/d9631b90da6ac592ea76b41a654dd5d29b2645d4
  Author: Peter Maydell <address@hidden>
  Date:   2014-03-27 (Thu, 27 Mar 2014)

  Changed paths:
    M hw/i386/acpi-build.c

  Log Message:
  -----------
  hw/i386/acpi_build.c: Avoid shifting left into sign bit

Add U suffix to avoid undefined behaviour.

Signed-off-by: Peter Maydell <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: f45cb2f43f5bb0a4122a64e61c746048b59a84ed
      
https://github.com/qemu/qemu/commit/f45cb2f43f5bb0a4122a64e61c746048b59a84ed
  Author: Peter Maydell <address@hidden>
  Date:   2014-03-27 (Thu, 27 Mar 2014)

  Changed paths:
    M target-mips/cpu.h
    M target-mips/helper.c
    M target-mips/op_helper.c
    M target-mips/translate_init.c

  Log Message:
  -----------
  target-mips: Avoid shifting left into sign bit

Add U suffix to various places where we shift a 1 left by 31,
to avoid undefined behaviour.

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 00b0179347bae12c5856c1195b67ef5dc7887b9b
      
https://github.com/qemu/qemu/commit/00b0179347bae12c5856c1195b67ef5dc7887b9b
  Author: Peter Maydell <address@hidden>
  Date:   2014-03-27 (Thu, 27 Mar 2014)

  Changed paths:
    M hw/usb/hcd-ohci.c

  Log Message:
  -----------
  hw/usb/hcd-ohci.c: Avoid shifting left into sign bit

Add U suffix to avoid undefined behaviour. This is only
strictly necessary for the 1<<31 cases, but we add it for the
other constants in these groups for consistency.

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: def60298825ccff006688ab9ee0ebb266c98b7e7
      
https://github.com/qemu/qemu/commit/def60298825ccff006688ab9ee0ebb266c98b7e7
  Author: Peter Maydell <address@hidden>
  Date:   2014-03-27 (Thu, 27 Mar 2014)

  Changed paths:
    M hw/intc/openpic.c

  Log Message:
  -----------
  hw/intc/openpic: Avoid shifting left into sign bit

Add U suffix to avoid undefined behaviour. This is only strictly
necessary for the 1 << 31 cases; for consistency we extend it
to other constants in the same group.

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: a1f7f97b950a46393b0e55a9a0082e70f540cbbd
      
https://github.com/qemu/qemu/commit/a1f7f97b950a46393b0e55a9a0082e70f540cbbd
  Author: Peter Maydell <address@hidden>
  Date:   2014-03-27 (Thu, 27 Mar 2014)

  Changed paths:
    M hw/ppc/ppc.c
    M hw/ppc/ppc440_bamboo.c
    M hw/ppc/ppc4xx_devs.c
    M hw/ppc/ppc_booke.c
    M hw/ppc/virtex_ml507.c

  Log Message:
  -----------
  hw/ppc: Avoid shifting left into sign bit

Add U suffix to various places where we were doing "1 << 31",
which is undefined behaviour, and also to other constant
definitions in the same groups, for consistency.

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: a879125b47c3ae554c01824f996a64a45a86556e
      
https://github.com/qemu/qemu/commit/a879125b47c3ae554c01824f996a64a45a86556e
  Author: Peter Maydell <address@hidden>
  Date:   2014-03-27 (Thu, 27 Mar 2014)

  Changed paths:
    M tests/libqos/pci-pc.c

  Log Message:
  -----------
  tests/libqos/pci-pc: Avoid shifting left into sign bit

Add U suffix when doing "1 << 31" to avoid undefined behaviour.

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 7d45e784015971e70239e33256fd606638107a3e
      
https://github.com/qemu/qemu/commit/7d45e784015971e70239e33256fd606638107a3e
  Author: Peter Maydell <address@hidden>
  Date:   2014-03-27 (Thu, 27 Mar 2014)

  Changed paths:
    M hw/intc/slavio_intctl.c

  Log Message:
  -----------
  hw/intc/slavio_intctl: Avoid shifting left into sign bit

Add 'U' suffix to avoid undefined behaviour.

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 0bc60bd7b34ad6e59b47dbf91179ba9427a85df7
      
https://github.com/qemu/qemu/commit/0bc60bd7b34ad6e59b47dbf91179ba9427a85df7
  Author: Peter Maydell <address@hidden>
  Date:   2014-03-27 (Thu, 27 Mar 2014)

  Changed paths:
    M hw/intc/xilinx_intc.c

  Log Message:
  -----------
  hw/intc/xilinx_intc: Avoid shifting left into sign bit

Avoid undefined behaviour shifting left into the sign bit.

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: af23906d50c7d7c28e7e5ff49f7cbf0fa5c6228a
      
https://github.com/qemu/qemu/commit/af23906d50c7d7c28e7e5ff49f7cbf0fa5c6228a
  Author: Peter Maydell <address@hidden>
  Date:   2014-03-27 (Thu, 27 Mar 2014)

  Changed paths:
    M hw/pci-host/apb.c

  Log Message:
  -----------
  hw/pci-host/apb.c: Avoid shifting left into sign bit

Add U suffix to avoid undefined behaviour.

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: c9f2d70cc88346d50020d01face2135481e5acde
      
https://github.com/qemu/qemu/commit/c9f2d70cc88346d50020d01face2135481e5acde
  Author: Prasad Joshi <address@hidden>
  Date:   2014-03-27 (Thu, 27 Mar 2014)

  Changed paths:
    M hw/timer/grlib_gptimer.c

  Log Message:
  -----------
  hw/timer/grlib_gptimer: remove unnecessary assignment

Signed-off-by: Prasad Joshi <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 3768d505adcd6c3fe819432d7dabd312995fa678
      
https://github.com/qemu/qemu/commit/3768d505adcd6c3fe819432d7dabd312995fa678
  Author: Prasad Joshi <address@hidden>
  Date:   2014-03-27 (Thu, 27 Mar 2014)

  Changed paths:
    M linux-user/signal.c

  Log Message:
  -----------
  linux-user: remove duplicate statement

Signed-off-by: Prasad Joshi <address@hidden>
Acked-by: Riku Voipio <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: c6c09ba9950407a075bfe19c7604f09b71499a20
      
https://github.com/qemu/qemu/commit/c6c09ba9950407a075bfe19c7604f09b71499a20
  Author: Peter Maydell <address@hidden>
  Date:   2014-03-27 (Thu, 27 Mar 2014)

  Changed paths:
    M CODING_STYLE
    M hw/i386/acpi-build.c
    M hw/ide/pci.c
    M hw/intc/apic.c
    M hw/intc/openpic.c
    M hw/intc/slavio_intctl.c
    M hw/intc/xilinx_intc.c
    M hw/pci-host/apb.c
    M hw/pci/pci_host.c
    M hw/ppc/ppc.c
    M hw/ppc/ppc440_bamboo.c
    M hw/ppc/ppc4xx_devs.c
    M hw/ppc/ppc_booke.c
    M hw/ppc/virtex_ml507.c
    M hw/timer/grlib_gptimer.c
    M hw/usb/hcd-ohci.c
    M kvm-all.c
    M linux-user/signal.c
    M qemu-doc.texi
    M qemu-options.hx
    M target-arm/machine.c
    M target-i386/cpu.c
    M target-i386/cpu.h
    M target-i386/kvm.c
    M target-mips/cpu.h
    M target-mips/helper.c
    M target-mips/op_helper.c
    M target-mips/translate_init.c
    M target-s390x/arch_dump.c
    M tests/libqos/pci-pc.c
    M util/module.c

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-2014-03-27' 
into staging

trivial patches for 2014-03-27

# gpg: Signature made Thu 27 Mar 2014 15:23:53 GMT using RSA key ID 74F0C838
# gpg: Good signature from "Michael Tokarev <address@hidden>"
# gpg:                 aka "Michael Tokarev <address@hidden>"
# gpg:                 aka "Michael Tokarev <address@hidden>"
# gpg: WARNING: This key is not certified with a trusted signature!
# gpg:          There is no indication that the signature belongs to the owner.
# Primary key fingerprint: 6EE1 95D1 886E 8FFB 810D  4324 457C E0A0 8044 65C5
#      Subkey fingerprint: E190 8639 3B10 B51B AC2C  8B73 5253 C5AD 74F0 C838

* remotes/mjt/tags/trivial-patches-2014-03-27: (23 commits)
  linux-user: remove duplicate statement
  hw/timer/grlib_gptimer: remove unnecessary assignment
  hw/pci-host/apb.c: Avoid shifting left into sign bit
  hw/intc/xilinx_intc: Avoid shifting left into sign bit
  hw/intc/slavio_intctl: Avoid shifting left into sign bit
  tests/libqos/pci-pc: Avoid shifting left into sign bit
  hw/ppc: Avoid shifting left into sign bit
  hw/intc/openpic: Avoid shifting left into sign bit
  hw/usb/hcd-ohci.c: Avoid shifting left into sign bit
  target-mips: Avoid shifting left into sign bit
  hw/i386/acpi_build.c: Avoid shifting left into sign bit
  hw/pci/pci_host.c: Avoid shifting left into sign bit
  hw/intc/apic.c: Use uint32_t for mask word in foreach_apic
  target-i386: Avoid shifting left into sign bit
  CODING_STYLE: Section about mixed declarations
  doc: update default PowerPC framebuffer settings
  doc: update sun4m documentation
  fix return check for KVM_GET_DIRTY_LOG ioctl
  target-i386: Add missing 'static' and 'const' attributes
  util: Add 'static' attribute to function implementation
  ...

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/6ff45f01c734...c6c09ba99504
[Prev in Thread]
Current Thread
[Next in Thread]
[Qemu-commits] [qemu/qemu] ecb4e0: target-s390x: Add missing 'static' and 'const' att..., GitHub <=
Prev by Date: [Qemu-commits] [qemu/qemu] d4715c: hw/arm: Stop specifying integratorcp as the defaul...
Next by Date: [Qemu-commits] [qemu/qemu] 6f1834: intc/openpic_kvm: Fix MemListener delete region ca...
Previous by thread: [Qemu-commits] [qemu/qemu] d4715c: hw/arm: Stop specifying integratorcp as the defaul...
Next by thread: [Qemu-commits] [qemu/qemu] 6f1834: intc/openpic_kvm: Fix MemListener delete region ca...
Index(es):
- Date
- Thread