qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 4c1b8f: qga: vss-win32: Use NULL as an invali


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 4c1b8f: qga: vss-win32: Use NULL as an invalid pointer for...
Date: Tue, 25 Feb 2014 05:00:04 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 4c1b8f1e8357d85c613d779596e4079cc581d74f
      
https://github.com/qemu/qemu/commit/4c1b8f1e8357d85c613d779596e4079cc581d74f
  Author: Tomoki Sekiyama <address@hidden>
  Date:   2014-02-23 (Sun, 23 Feb 2014)

  Changed paths:
    M qga/vss-win32/provider.cpp
    M qga/vss-win32/requester.cpp

  Log Message:
  -----------
  qga: vss-win32: Use NULL as an invalid pointer for OpenEvent and CreateEvent

OpenEvent and CreateEvent WinAPI return NULL when failed to open/create
events handles, instead of INVALID_HANDLE_VALUE (although their return
types are HANDLE).
This replaces INVALID_HANDLE_VALUE related to event handles with NULL.

Signed-off-by: Tomoki Sekiyama <address@hidden>
Reviewed-by: Gal Hammer <address@hidden>
Reviewed-by: Yan Vugenfirer <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: ff8adbcfdbbd9c0f2b01ff8a32bc75082fdd9844
      
https://github.com/qemu/qemu/commit/ff8adbcfdbbd9c0f2b01ff8a32bc75082fdd9844
  Author: Tomoki Sekiyama <address@hidden>
  Date:   2014-02-23 (Sun, 23 Feb 2014)

  Changed paths:
    M qga/vss-win32/provider.cpp
    M qga/vss-win32/requester.cpp

  Log Message:
  -----------
  qga: vss-win32: Fix interference with snapshot creation by other VSS 
requesters

When a VSS requester such as vshadow.exe or diskshadow.exe requests to
create disk snapshots, Windows may choose qemu-ga VSS provider if it is
only provider registered on the system. However, because it provides only a
function to freeze the filesystem, the snapshotting fails.

This patch adds a check into CQGAVssProvider::IsVolumeSupported() to reject
the request from other VSS requesters, so that the other provider is chosen.

The check of requester is done by confirming event channels between
qemu-ga's requester and provider established. To ensure that the events are
initialized when CQGAVssProvider::IsVolumeSupported() is called, it moves
the initialization earlier.

Signed-off-by: Tomoki Sekiyama <address@hidden>
Reviewed-by: Gal Hammer <address@hidden>
Reviewed-by: Yan Vugenfirer <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: d9e1f574cb6eac0a3a2f97b67d2e7a3ad9c1dc95
      
https://github.com/qemu/qemu/commit/d9e1f574cb6eac0a3a2f97b67d2e7a3ad9c1dc95
  Author: Tomoki Sekiyama <address@hidden>
  Date:   2014-02-23 (Sun, 23 Feb 2014)

  Changed paths:
    M qga/vss-win32/provider.cpp

  Log Message:
  -----------
  qga: vss-win32: Fix interference with snapshot deletion by other VSS request

When a VSS requester such as vshadow.exe or diskshadow.exe requests to
delete snapshots, qemu-ga VSS provider's DeleteSnapshots() is also called
and returns E_NOTIMPL, that makes the deletion fail.
To avoid this issue, return S_OK and set values that represent no snapshots
are deleted by qemu-ga VSS provider.

Signed-off-by: Tomoki Sekiyama <address@hidden>
Reviewed-by: Gal Hammer <address@hidden>
Reviewed-by: Yan Vugenfirer <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: 2c958923bc09b1faf2505a988b4b1c458580e9ac
      
https://github.com/qemu/qemu/commit/2c958923bc09b1faf2505a988b4b1c458580e9ac
  Author: Michal Privoznik <address@hidden>
  Date:   2014-02-23 (Sun, 23 Feb 2014)

  Changed paths:
    M qga/commands-posix.c
    M qga/commands-win32.c
    M qga/qapi-schema.json

  Log Message:
  -----------
  qga: Don't require 'time' argument in guest-set-time command

As the description to the guest-set-time states, the command is
there to ease time synchronization after resume. If guest was
suspended for longer period of time, its system time can go off
so badly, that even NTP refuses to set it. That's why the command
was invented: to give users chance to set the time (not
necessarily 100% correct). However, there's is no real need for
us to require users to pass an arbitrary time. Especially if we
can read the correct value from RTC (boiling down to reading
host's time). Hence this commit enables logic:

guest-set-time() == guest-set-time($now_from_rtc)

Signed-off-by: Michal Privoznik <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: 10b7c5dd0da1a92182e87f5fc1887d779ad1a9e8
      
https://github.com/qemu/qemu/commit/10b7c5dd0da1a92182e87f5fc1887d779ad1a9e8
  Author: Markus Armbruster <address@hidden>
  Date:   2014-02-23 (Sun, 23 Feb 2014)

  Changed paths:
    M qga/commands-posix.c

  Log Message:
  -----------
  qga: Fix memory allocation pasto

qmp_guest_file_seek() allocates memory for a GuestFileRead object
instead of the GuestFileSeek object it actually uses.  Harmless,
because the GuestFileRead is slightly larger.

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Michael Roth <address@hidden>


  Commit: a749f42da5129bbfadea6926964d9a213ed4bc5f
      
https://github.com/qemu/qemu/commit/a749f42da5129bbfadea6926964d9a213ed4bc5f
  Author: Miki Mishael <address@hidden>
  Date:   2014-02-23 (Sun, 23 Feb 2014)

  Changed paths:
    M qga/channel-win32.c
    M qga/main.c

  Log Message:
  -----------
  qemu-ga: isa-serial support on Windows

Add support for isa-serial method for qemu-ga on Windows,
Added -p command line parameter for serial port name
specification, e.g. "-p COM15".

Signed-off-by: Miki Mishael <address@hidden>
Signed-off-by: Dmitry Fleytman <address@hidden>

*added default isa-serial path to help output

Signed-off-by: Michael Roth <address@hidden>


  Commit: 0459650d94d18218808fcabc8c3227d2ee99af39
      
https://github.com/qemu/qemu/commit/0459650d94d18218808fcabc8c3227d2ee99af39
  Author: Peter Maydell <address@hidden>
  Date:   2014-02-25 (Tue, 25 Feb 2014)

  Changed paths:
    M qga/channel-win32.c
    M qga/commands-posix.c
    M qga/commands-win32.c
    M qga/main.c
    M qga/qapi-schema.json
    M qga/vss-win32/provider.cpp
    M qga/vss-win32/requester.cpp

  Log Message:
  -----------
  Merge remote-tracking branch 'remotes/mdroth/qga-pull-2014-02-24' into staging

* remotes/mdroth/qga-pull-2014-02-24:
  qemu-ga: isa-serial support on Windows
  qga: Fix memory allocation pasto
  qga: Don't require 'time' argument in guest-set-time command
  qga: vss-win32: Fix interference with snapshot deletion by other VSS request
  qga: vss-win32: Fix interference with snapshot creation by other VSS 
requesters
  qga: vss-win32: Use NULL as an invalid pointer for OpenEvent and CreateEvent

Signed-off-by: Peter Maydell <address@hidden>


Compare: https://github.com/qemu/qemu/compare/05fd3bf2a1c9...0459650d94d1

reply via email to

[Prev in Thread] Current Thread [Next in Thread]