qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 117e0c: block/drive-mirror: Reuse backing HD


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 117e0c: block/drive-mirror: Reuse backing HD for sync=none
Date: Wed, 27 Nov 2013 14:30:03 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 117e0c82881f05d88902d4059a3171bc6cd02df0
      
https://github.com/qemu/qemu/commit/117e0c82881f05d88902d4059a3171bc6cd02df0
  Author: Max Reitz <address@hidden>
  Date:   2013-11-27 (Wed, 27 Nov 2013)

  Changed paths:
    M blockdev.c

  Log Message:
  -----------
  block/drive-mirror: Reuse backing HD for sync=none

For "none" sync mode in "absolute-paths" mode, the current image should
be used as the backing file for the newly created image.

The current behavior is:
a) If the image to be mirrored has a backing file, use that (which is
   wrong, since the operations recorded by "none" are applied to the
   image itself, not to its backing file).
b) If the image to be mirrored lacks a backing file, the target doesn't
   have one either (which is not really wrong, but not really right,
   either; "none" records a set of operations executed on the image
   file, therefore having no backing file to apply these operations on
   seems rather pointless).

For a, this is clearly a bugfix. For b, it is still a bugfix, although
it might break existing API - but since that case crashed qemu just
three weeks ago (before 1452686495922b81d6cf43edf025c1aef15965c0), we
can safely assume there is no such API relying on that case yet.

Suggested-by: Paolo Bonzini <address@hidden>
Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 171d64319c9604228429b0580edf764a69b67c75
      
https://github.com/qemu/qemu/commit/171d64319c9604228429b0580edf764a69b67c75
  Author: Max Reitz <address@hidden>
  Date:   2013-11-27 (Wed, 27 Nov 2013)

  Changed paths:
    M tests/qemu-iotests/041
    M tests/qemu-iotests/041.out

  Log Message:
  -----------
  qemu-iotests: Fix test 041

Performing multiple drive-mirror blockjobs on the same qemu instance
results in the image file used for the block device being replaced by
the newly mirrored file, which is not what we want.

Fix this by performing one dedicated test per sync mode.

Signed-off-by: Max Reitz <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 0e7b9f06a6cc032be6ca2ac55a27592abd374179
      
https://github.com/qemu/qemu/commit/0e7b9f06a6cc032be6ca2ac55a27592abd374179
  Author: Anthony Liguori <address@hidden>
  Date:   2013-11-27 (Wed, 27 Nov 2013)

  Changed paths:
    M VERSION

  Log Message:
  -----------
  Update version for 1.7.0 release

Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 7dc65c02fe3fb8f3146ce0b9ff5fec5945329f0e
      
https://github.com/qemu/qemu/commit/7dc65c02fe3fb8f3146ce0b9ff5fec5945329f0e
  Author: Anthony Liguori <address@hidden>
  Date:   2013-11-27 (Wed, 27 Nov 2013)

  Changed paths:
    M VERSION

  Log Message:
  -----------
  Open 2.0 development tree

Signed-off-by: Anthony Liguori <address@hidden>


Compare: https://github.com/qemu/qemu/compare/7457fe9541b5...7dc65c02fe3f

reply via email to

[Prev in Thread] Current Thread [Next in Thread]