qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 7ba9ad: char: move backends' io watch tag to


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 7ba9ad: char: move backends' io watch tag to CharDriverSta...
Date: Thu, 10 Oct 2013 14:00:05 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 7ba9addc165b37b764baa08c02518b15b2361707
      
https://github.com/qemu/qemu/commit/7ba9addc165b37b764baa08c02518b15b2361707
  Author: Amit Shah <address@hidden>
  Date:   2013-09-05 (Thu, 05 Sep 2013)

  Changed paths:
    M include/sysemu/char.h
    M qemu-char.c

  Log Message:
  -----------
  char: move backends' io watch tag to CharDriverState

All the backends implement an io watcher tag for callbacks.  Move it to
CharDriverState from each backend's struct to make accessing the tag from
backend-neutral functions easier.

This will be used later to cancel a callback on chardev detach from a
frontend.

CC: <address@hidden>
Reviewed-by: Gerd Hoffmann <address@hidden>
Signed-off-by: Amit Shah <address@hidden>


  Commit: 26da70c72524eb22c946ab19ec98a217b8252f7e
      
https://github.com/qemu/qemu/commit/26da70c72524eb22c946ab19ec98a217b8252f7e
  Author: Amit Shah <address@hidden>
  Date:   2013-09-05 (Thu, 05 Sep 2013)

  Changed paths:
    M qemu-char.c

  Log Message:
  -----------
  char: use common function to disable callbacks on chardev close

This deduplicates code used a lot of times.

CC: <address@hidden>
Reviewed-by: Gerd Hoffmann <address@hidden>
Signed-off-by: Amit Shah <address@hidden>


  Commit: 386a5a1e0057e220f79c48fe3689e3dfb17f1b09
      
https://github.com/qemu/qemu/commit/386a5a1e0057e220f79c48fe3689e3dfb17f1b09
  Author: Amit Shah <address@hidden>
  Date:   2013-09-05 (Thu, 05 Sep 2013)

  Changed paths:
    M qemu-char.c

  Log Message:
  -----------
  char: remove watch callback on chardev detach from frontend

If a frontend device releases the chardev (via unplug), the chr handlers
are set to NULL via qdev's exit callbacks invoking
qemu_chr_add_handlers().  If the chardev had a pending operation, a
callback will be invoked, which will try to access data in the
just-released frontend, causing a segfault.

Ensure the callbacks are disabled when frontends release chardevs.

This was seen when a virtio-serial port was unplugged when heavy
guest->host IO was in progress (causing a callback to be registered).
In the window in which the throttling was active, unplugging ports
caused a qemu segfault.

https://bugzilla.redhat.com/show_bug.cgi?id=985205

CC: <address@hidden>
Reported-by: Sibiao Luo <address@hidden>
Reviewed-by: Gerd Hoffmann <address@hidden>
Signed-off-by: Amit Shah <address@hidden>


  Commit: c236f4519c9838801798f3705c17dce9ab9e3b9d
      
https://github.com/qemu/qemu/commit/c236f4519c9838801798f3705c17dce9ab9e3b9d
  Author: Eduardo Otubo <address@hidden>
  Date:   2013-09-24 (Tue, 24 Sep 2013)

  Changed paths:
    M qemu-seccomp.c

  Log Message:
  -----------
  seccomp: fine tuning whitelist by adding times()

This was causing Qemu process to hang when using -sandbox on as
discribed on RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1004175

Signed-off-by: Eduardo Otubo <address@hidden>
Tested-by: Paul Moore <address@hidden>
Acked-by: Paul Moore <address@hidden>


  Commit: f8e6a11aecc96e9d8a84f17d7c07019471714e20
      
https://github.com/qemu/qemu/commit/f8e6a11aecc96e9d8a84f17d7c07019471714e20
  Author: Eduardo Habkost <address@hidden>
  Date:   2013-10-02 (Wed, 02 Oct 2013)

  Changed paths:
    M include/hw/i386/pc.h
    M target-i386/cpu.c

  Log Message:
  -----------
  target-i386: Set model=6 on qemu64 & qemu32 CPU models

There's no Intel CPU with family=6,model=2, and Linux and Windows guests
disable SEP when seeing that combination due to Pentium Pro erratum #82.

In addition to just having SEP ignored by guests, Skype (and maybe other
applications) runs sysenter directly without passing through ntdll on
Windows, and crashes because Windows ignored the SEP CPUID bit.

So, having model > 2 is a better default on qemu64 and qemu32 for two
reasons: making SEP really available for guests, and avoiding crashing
applications that work on bare metal.

model=3 would fix the problem, but it causes CPU enumeration problems
for Windows guests[1]. So let's set model=6, that matches "Athlon
(PM core)" on AMD and "P2 with on-die L2 cache" on Intel and it allows
Windows to use all CPUs as well as fixing sysenter.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=508623

Cc: Andrea Arcangeli <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: ad98acb9b1d610c4d243f53d9fb380e500d4abbe
      
https://github.com/qemu/qemu/commit/ad98acb9b1d610c4d243f53d9fb380e500d4abbe
  Author: Mark Cave-Ayland <address@hidden>
  Date:   2013-10-02 (Wed, 02 Oct 2013)

  Changed paths:
    M pc-bios/README
    M pc-bios/openbios-ppc
    M pc-bios/openbios-sparc32
    M pc-bios/openbios-sparc64
    M roms/openbios

  Log Message:
  -----------
  Update OpenBIOS images

Update OpenBIOS images to SVN r1229 built from submodule.

Signed-off-by: Mark Cave-Ayland <address@hidden>


  Commit: 6c78f29a2424622bfc9c30dfbbc13404481eacb6
      
https://github.com/qemu/qemu/commit/6c78f29a2424622bfc9c30dfbbc13404481eacb6
  Author: Juergen Lock <address@hidden>
  Date:   2013-10-07 (Mon, 07 Oct 2013)

  Changed paths:
    M cpu-exec.c

  Log Message:
  -----------
  cpu-exec: Also reload CPUClass *cc after longjmp return in cpu_exec()

Local variable CPUClass *cc needs to be reloaded after return from longjmp,
too.  (This fixes a mips-softmmu crash observed on FreeBSD when QEMU is
built with clang.)

Reported-by: Dimitry Andric <address@hidden>
Signed-off-by: Juergen Lock <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 812586405c5d165aae791d3806a9bbb8312ec2ac
      
https://github.com/qemu/qemu/commit/812586405c5d165aae791d3806a9bbb8312ec2ac
  Author: liguang <address@hidden>
  Date:   2013-10-07 (Mon, 07 Oct 2013)

  Changed paths:
    M cputlb.c

  Log Message:
  -----------
  cputlb: Remove dead function tlb_update_dirty()

Signed-off-by: liguang <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>


  Commit: 30ba0ee52d1519b717089782ef1caf0480a01dc3
      
https://github.com/qemu/qemu/commit/30ba0ee52d1519b717089782ef1caf0480a01dc3
  Author: Andreas Färber <address@hidden>
  Date:   2013-10-07 (Mon, 07 Oct 2013)

  Changed paths:
    M exec.c
    M linux-user/main.c

  Log Message:
  -----------
  cpu: Move cpu_copy() into linux-user

It is only used there and is deemed very fragile if not incorrect in its
current memcpy() form. Moving it into linux-user will allow to move
parts into target_cpu.h headers and only copy what the ABI mandates.

Signed-off-by: Andreas Färber <address@hidden>


  Commit: 51fb256ab5ebc3e1879eb1df9c828866a2ef8141
      
https://github.com/qemu/qemu/commit/51fb256ab5ebc3e1879eb1df9c828866a2ef8141
  Author: Andreas Färber <address@hidden>
  Date:   2013-10-07 (Mon, 07 Oct 2013)

  Changed paths:
    M include/exec/cpu-defs.h
    M linux-user/main.c
    M target-alpha/cpu.c
    M target-arm/helper.c
    M target-i386/cpu.c
    M target-m68k/helper.c
    M target-mips/translate.c
    M target-moxie/cpu.c
    M target-openrisc/cpu.c
    M target-ppc/translate_init.c
    M target-s390x/helper.c
    M target-sh4/cpu.c
    M target-sparc/cpu.c
    M target-unicore32/helper.c

  Log Message:
  -----------
  cpu: Drop cpu_model_str from CPU_COMMON

Since this is only read in cpu_copy() and linux-user has a global
cpu_model, drop the field from generic code.

Signed-off-by: Andreas Färber <address@hidden>


  Commit: e572398de14c2173d5701d1f7771689764356b68
      
https://github.com/qemu/qemu/commit/e572398de14c2173d5701d1f7771689764356b68
  Author: Anthony Liguori <address@hidden>
  Date:   2013-10-10 (Thu, 10 Oct 2013)

  Changed paths:
    M pc-bios/README
    M pc-bios/openbios-ppc
    M pc-bios/openbios-sparc32
    M pc-bios/openbios-sparc64
    M roms/openbios

  Log Message:
  -----------
  Merge remote-tracking branch 'mcayland/qemu-openbios' into staging

* mcayland/qemu-openbios:
  Update OpenBIOS images

Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 88b70e56b969142c88f240434f392b9348600ef5
      
https://github.com/qemu/qemu/commit/88b70e56b969142c88f240434f392b9348600ef5
  Author: Anthony Liguori <address@hidden>
  Date:   2013-10-10 (Thu, 10 Oct 2013)

  Changed paths:
    M qemu-seccomp.c

  Log Message:
  -----------
  Merge remote-tracking branch 'otubo/seccomp' into staging

# By Eduardo Otubo
# Via Eduardo Otubo
* otubo/seccomp:
  seccomp: fine tuning whitelist by adding times()

Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: e8f2f59aaf2978641b7e073ba623bd4b4a9e864d
      
https://github.com/qemu/qemu/commit/e8f2f59aaf2978641b7e073ba623bd4b4a9e864d
  Author: Anthony Liguori <address@hidden>
  Date:   2013-10-10 (Thu, 10 Oct 2013)

  Changed paths:
    M include/sysemu/char.h
    M qemu-char.c

  Log Message:
  -----------
  Merge remote-tracking branch 'amit/char-remove-watch-on-unplug' into staging

# By Amit Shah
# Via Amit Shah
* amit/char-remove-watch-on-unplug:
  char: remove watch callback on chardev detach from frontend
  char: use common function to disable callbacks on chardev close
  char: move backends' io watch tag to CharDriverState

Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 39c153b80f890dc5f02465dc59992e195abd5f40
      
https://github.com/qemu/qemu/commit/39c153b80f890dc5f02465dc59992e195abd5f40
  Author: Anthony Liguori <address@hidden>
  Date:   2013-10-10 (Thu, 10 Oct 2013)

  Changed paths:
    M cpu-exec.c
    M cputlb.c
    M exec.c
    M include/exec/cpu-defs.h
    M include/hw/i386/pc.h
    M linux-user/main.c
    M target-alpha/cpu.c
    M target-arm/helper.c
    M target-i386/cpu.c
    M target-m68k/helper.c
    M target-mips/translate.c
    M target-moxie/cpu.c
    M target-openrisc/cpu.c
    M target-ppc/translate_init.c
    M target-s390x/helper.c
    M target-sh4/cpu.c
    M target-sparc/cpu.c
    M target-unicore32/helper.c

  Log Message:
  -----------
  Merge remote-tracking branch 'afaerber/tags/qom-cpu-for-anthony' into staging

QOM CPUState refactorings / X86CPU

* Fix for X86CPU model field of qemu32/qemu64 CPU models
* Bug fix for longjmp on FreeBSD
* Removal of unused function
* Confinement of clone syscall infrastructure to linux-user

# gpg: Signature made Wed 09 Oct 2013 03:40:51 AM PDT using RSA key ID 3E7E013F
# gpg: Can't check signature: public key not found

# By Andreas Färber (2) and others
# Via Andreas Färber
* afaerber/tags/qom-cpu-for-anthony:
  cpu: Drop cpu_model_str from CPU_COMMON
  cpu: Move cpu_copy() into linux-user
  cputlb: Remove dead function tlb_update_dirty()
  cpu-exec: Also reload CPUClass *cc after longjmp return in cpu_exec()
  target-i386: Set model=6 on qemu64 & qemu32 CPU models


Compare: https://github.com/qemu/qemu/compare/f2c6bcfc2e15...39c153b80f89

reply via email to

[Prev in Thread] Current Thread [Next in Thread]