[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-commits] [qemu/qemu] 670599: block: ensure bdrv_drain_all() works
|
From: |
GitHub |
|
Subject: |
[Qemu-commits] [qemu/qemu] 670599: block: ensure bdrv_drain_all() works during bdrv_d... |
|
Date: |
Wed, 09 Oct 2013 12:30:06 -0700 |
Branch: refs/heads/stable-1.6
Home: https://github.com/qemu/qemu
Commit: 670599a08c052f6ef841743731a8f06d4b50ec99
https://github.com/qemu/qemu/commit/670599a08c052f6ef841743731a8f06d4b50ec99
Author: Stefan Hajnoczi <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M block.c
Log Message:
-----------
block: ensure bdrv_drain_all() works during bdrv_delete()
In bdrv_delete() make sure to call bdrv_make_anon() *after* bdrv_close()
so that the device is still seen by bdrv_drain_all() when iterating
bdrv_states.
Cc: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>
(cherry picked from commit e1b5c52e04d04bb93546c6e37e8884889d047cb1)
Signed-off-by: Michael Roth <address@hidden>
Commit: c0c080c5d1ce6c236ba8ab5db3a17043c665d0f6
https://github.com/qemu/qemu/commit/c0c080c5d1ce6c236ba8ab5db3a17043c665d0f6
Author: Andreas Färber <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M gdbstub.c
M include/qom/cpu.h
M qom/cpu.c
Log Message:
-----------
gdbstub: Fix gdb_register_coprocessor() register counting
Commit a0e372f0c49ac01faeaeb73a6e8f50e8ac615f34 reorganized the register
counting for GDB. While it seems correct not to let the total number of
registers skyrocket in an SMP scenario through a static variable, the
distinction between total register count and 'g' packet register count
(last_reg vs. num_g_regs) got lost among the way.
Fix this by introducing CPUState::gdb_num_g_regs and using that in
gdb_handle_packet().
Reported-by: Aneesh Kumar K.V <address@hidden>
Cc: address@hidden (stable-1.6)
Tested-by: Aneesh Kumar K.V <address@hidden>
Tested-by: Max Filippov <address@hidden>
Tested-by: Peter Maydell <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>
(cherry picked from commit 35143f0164e6933a85c7c2b8a89a040d881a9151)
Signed-off-by: Michael Roth <address@hidden>
Commit: 52f99b02e5ff1004fb3b41846d2c34f190127456
https://github.com/qemu/qemu/commit/52f99b02e5ff1004fb3b41846d2c34f190127456
Author: Aurelien Jarno <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M target-ppc/translate.c
Log Message:
-----------
target-ppc: fix bit extraction for FPBF and FPL
Bit extraction for the FP BF and L field of the MTFSFI and MTFSF
instructions is wrong and doesn't match the reference manual (which
explain the bit number in big endian format). It has been broken in
commit 7d08d85645def18eac2a9d672c1868a35e0bcf79.
This patch fixes this, which in turn fixes the problem reported by
Khem Raj about the floor() function of libm.
Reported-by: Khem Raj <address@hidden>
Signed-off-by: Aurelien Jarno <address@hidden>
CC: address@hidden (1.6)
Signed-off-by: Alexander Graf <address@hidden>
(cherry picked from commit 779f659021d1754117bce1aab9370dc22f37ae07)
Signed-off-by: Michael Roth <address@hidden>
Commit: 260790645e95891cb264c2d657648f43401ac915
https://github.com/qemu/qemu/commit/260790645e95891cb264c2d657648f43401ac915
Author: Michael R. Hines <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M migration-rdma.c
Log Message:
-----------
rdma: silly ipv6 bugfix
My bad - but it's very important for us to warn the user that
IPv6 is broken on RoCE in linux right now, until linux releases
a fixed version.
Signed-off-by: Michael R. Hines <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
(cherry picked from commit c89aa2f1851b08c3efa8a1070c0a6b9a36e1227f)
Signed-off-by: Michael Roth <address@hidden>
Commit: d6dcfd69f8b2aa2cad79486bbadef7d51f7f4e7d
https://github.com/qemu/qemu/commit/d6dcfd69f8b2aa2cad79486bbadef7d51f7f4e7d
Author: Peter Maydell <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M scripts/qapi.py
Log Message:
-----------
scripts/qapi.py: Avoid syntax not supported by Python 2.4
The Python "except Foo as x" syntax was only introduced in
Python 2.6, but we aim to support Python 2.4 and later.
Use the old-style "except Foo, x" syntax instead, thus
fixing configure/compile on systems with older Python.
Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>
(cherry picked from commit 21e0043bada1a24ae2ba6cd0051e104c0cbf9634)
Signed-off-by: Michael Roth <address@hidden>
Commit: 11b0ab70a58e3e6c06dc1fd1ea318b1c5806d955
https://github.com/qemu/qemu/commit/11b0ab70a58e3e6c06dc1fd1ea318b1c5806d955
Author: Marcel Apfelbaum <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M hw/usb/dev-hid.c
Log Message:
-----------
usb/dev-hid: Modified usb-tablet category from Misc to Input
usb-tablet device was wrongly assigned to Misc category
Reported-by: Markus Armbruster <address@hidden>
Cc: address@hidden
Signed-off-by: Marcel Apfelbaum <address@hidden>
Reviewed-by: Andreas Färber <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>
(cherry picked from commit 31efd2e883018b4c079ad082105bc161fbb3fef8)
Signed-off-by: Michael Roth <address@hidden>
Commit: 964e0d4ec52ea7400ccc69de69b05ac913bbfff8
https://github.com/qemu/qemu/commit/964e0d4ec52ea7400ccc69de69b05ac913bbfff8
Author: Markus Armbruster <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M hw/scsi/scsi-bus.c
Log Message:
-----------
scsi: Fix scsi_bus_legacy_add_drive() scsi-generic with serial
scsi_bus_legacy_add_drive() creates either a scsi-disk or a
scsi-generic device. It sets property "serial" to argument serial
unless null. Crashes with scsi-generic, because it doesn't have such
the property.
Only usb_msd_initfn_storage() passes non-null serial. Reproducer:
$ qemu-system-x86_64 -nodefaults -display none -S -usb \
-drive if=none,file=/dev/sg1,id=usb-drv0 \
-device usb-storage,id=usb-msd0,drive=usb-drv0,serial=123
qemu-system-x86_64: -device
usb-storage,id=usb-msd0,drive=usb-drv0,serial=123: Property '.serial' not found
Aborted (core dumped)
Fix by handling exactly like "removable": set the property only when
it exists.
Cc: address@hidden
Reviewed-by: Andreas Färber <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
(cherry picked from commit c24e7517ee4a98e90eee5f0f07708a1fa12326b3)
Signed-off-by: Michael Roth <address@hidden>
Commit: a73c74f63aa8f977ece88c97280a03ea9b1ca395
https://github.com/qemu/qemu/commit/a73c74f63aa8f977ece88c97280a03ea9b1ca395
Author: Michael S. Tsirkin <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M hw/pci-host/piix.c
M hw/pci-host/q35.c
M include/hw/i386/pc.h
Log Message:
-----------
pc: fix regression for 64 bit PCI memory
commit 398489018183d613306ab022653552247d93919f
pc: limit 64 bit hole to 2G by default
introduced a way for management to control
the window allocated to the 64 bit PCI hole.
This is useful, but existing management tools do not know how to set
this property. As a result, e.g. specifying a large ivshmem device with
size > 4G is broken by default. For example this configuration no
longer works:
-device ivshmem,size=4294967296,chardev=cfoo
-chardev socket,path=/tmp/sock,id=cfoo,server,nowait
Fix this by detecting that hole size was not specified
and defaulting to the backwards-compatible value of 1 << 62.
Cc: address@hidden
Cc: Igor Mammedov <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
(cherry picked from commit 1466cef32dd5e7ef3c6477e96d85d92302ad02e3)
Signed-off-by: Michael Roth <address@hidden>
Commit: 3fe494efc5eb107c4c90e96df3e6131f9960f4b9
https://github.com/qemu/qemu/commit/3fe494efc5eb107c4c90e96df3e6131f9960f4b9
Author: Anton Blanchard <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M hw/char/spapr_vty.c
Log Message:
-----------
pseries: Fix stalls on hypervisor virtual console
A number of users are reporting stalls when using the pseries
hypervisor virtual console.
A simple test case is to paste 15 or 17 characters at a time
into the console. Pasting 15 characters at a time works fine
but pasting 17 characters hangs for a random amount of time.
Other activity (network, qemu monitor etc) unblocks it.
If qemu-char tries to send more than 16 characters at once,
vty_can_receive returns false. At this point we have to
wait for the guest to consume that output. Everything is good
so far.
The problem occurs when the the guest does consume the output.
We need to signal back to the qemu-char layer that we are
ready for more input. Without this we block until something
else kicks us (eg network activity).
Signed-off-by: Anton Blanchard <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>
(cherry picked from commit 7770b6f78a2d655e03852a5de238f5926c92be6a)
Signed-off-by: Michael Roth <address@hidden>
Commit: 358bb0daa1ce332a18cc996fcd078a3989f77d36
https://github.com/qemu/qemu/commit/358bb0daa1ce332a18cc996fcd078a3989f77d36
Author: yinyin <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M hw/virtio/virtio.c
Log Message:
-----------
virtio: virtqueue_get_avail_bytes: fix desc_pa when loop over the indirect
descriptor table
virtqueue_get_avail_bytes: when found a indirect desc, we need loop over it.
/* loop over the indirect descriptor table */
indirect = 1;
max = vring_desc_len(desc_pa, i) / sizeof(VRingDesc);
num_bufs = i = 0;
desc_pa = vring_desc_addr(desc_pa, i);
But, It init i to 0, then use i to update desc_pa. so we will always get:
desc_pa = vring_desc_addr(desc_pa, 0);
the last two line should swap.
Cc: address@hidden
Signed-off-by: Yin Yin <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
(cherry picked from commit 1ae2757c6c4525c9b42f408c86818f843bad7418)
Signed-off-by: Michael Roth <address@hidden>
Commit: c0a5eb81b43e56569cfdb9c86fd78930b2765b96
https://github.com/qemu/qemu/commit/c0a5eb81b43e56569cfdb9c86fd78930b2765b96
Author: Gerd Hoffmann <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M hw/usb/hcd-xhci.c
Log Message:
-----------
xhci: fix endpoint interval calculation
Cc: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
(cherry picked from commit ca7162782a293f525633e5816470498dd86a51cf)
Signed-off-by: Michael Roth <address@hidden>
Commit: c09a4634d945df5d7e1fbc394646e78d7d713c67
https://github.com/qemu/qemu/commit/c09a4634d945df5d7e1fbc394646e78d7d713c67
Author: Gerd Hoffmann <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M hw/usb/dev-hub.c
Log Message:
-----------
Revert "usb-hub: report status changes only once"
This reverts commit a309ee6e0a256f690760abfba44fceaa52a7c2f3.
This isn't in line with the usb specification and adds regressions,
win7 fails to drive the usb hub for example.
Was added because it "solved" the issue of hubs interacting badly
with the xhci host controller. Now with the root cause being fixed
in xhci (commit <FIXME>) we can revert this one.
Cc: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
(cherry picked from commit bdebd6ee81f4d849aa8541c289203e3992450db0)
Signed-off-by: Michael Roth <address@hidden>
Commit: da4e203efa76f2d2ee0a17670c241881963d033d
https://github.com/qemu/qemu/commit/da4e203efa76f2d2ee0a17670c241881963d033d
Author: Paolo Bonzini <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M block.c
M block/cow.c
M block/qcow2.c
M block/stream.c
M qemu-img.c
M qemu-io-cmds.c
Log Message:
-----------
block: expect errors from bdrv_co_is_allocated
Some bdrv_is_allocated callers do not expect errors, but the fallback
in qcow2.c might make other callers trip on assertion failures or
infinite loops.
Fix the callers to always look for errors.
Cc: address@hidden
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
(cherry picked from commit d663640c04f2aab810915c556390211d75457704)
Conflicts:
block/cow.c
*modified to avoid dependency on upstream's e641c1e8
Signed-off-by: Michael Roth <address@hidden>
Commit: f9fd82ee939d6ee5bff126b125020021e18ce330
https://github.com/qemu/qemu/commit/f9fd82ee939d6ee5bff126b125020021e18ce330
Author: Paolo Bonzini <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M target-i386/helper.c
Log Message:
-----------
target-i386: fix disassembly with PAE=1, PG=0
CR4.PAE=1 will not enable paging if CR0.PG=0, but the "if" chain
in x86_cpu_get_phys_page_debug says otherwise. Check CR0.PG
before everything else.
Fixes "-d in_asm" for a code section at the beginning of OVMF.
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Max Filippov <address@hidden>
(cherry picked from commit f2f8560c7a5303065a2a3207ec475dfb3a622a0e)
Signed-off-by: Michael Roth <address@hidden>
Commit: 2ffbe03e8bc8f330581e31537190949a9aba80c3
https://github.com/qemu/qemu/commit/2ffbe03e8bc8f330581e31537190949a9aba80c3
Author: Hervé Poussineau <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M hw/audio/adlib.c
Log Message:
-----------
adlib: sort offsets in portio registration
This fixes the following assert when -device adlib is used:
ioport.c:240: portio_list_add: Assertion `pio->offset >= off_last' failed.
Signed-off-by: Hervé Poussineau <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
(cherry picked from commit 2b21fb57af305f17841d79e7e2e02ad1aec3f5ca)
Signed-off-by: Michael Roth <address@hidden>
Commit: 9fab8e1fe15014a4bd147eeedd2491bcfbba4e59
https://github.com/qemu/qemu/commit/9fab8e1fe15014a4bd147eeedd2491bcfbba4e59
Author: Paolo Bonzini <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M exec.c
Log Message:
-----------
exec: fix writing to MMIO area with non-power-of-two length
The problem is introduced by commit 2332616 (exec: Support 64-bit
operations in address_space_rw, 2013-07-08). Before that commit,
memory_access_size would only return 1/2/4.
Since alignment is already handled above, reduce l to the largest
power of two that is smaller than l.
Cc: address@hidden
Reported-by: Oleksii Shevchuk <address@hidden>
Tested-by: Oleksii Shevchuk <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
(cherry picked from commit 098178f2749a63fbbb1a626dcc7d939d5cb2bde7)
Signed-off-by: Michael Roth <address@hidden>
Commit: 1cd7138d492304a76f3b8ae89fc61e05b18205a7
https://github.com/qemu/qemu/commit/1cd7138d492304a76f3b8ae89fc61e05b18205a7
Author: Michael S. Tsirkin <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M hw/virtio/virtio-pci.c
Log Message:
-----------
virtio_pci: fix level interrupts with irqfd
commit 62c96360ae7f2c7a8b029277fbb7cb082fdef7fd
virtio-pci: fix level interrupts
only helps systems without irqfd: on systems with irqfd support we
passed in flag requesting irqfd even when msix is disabled.
As a result, for level interrupts we didn't install an fd handler so
unmasking an fd had no effect.
Fix this up.
Cc: address@hidden
Signed-off-by: Michael S. Tsirkin <address@hidden>
(cherry picked from commit 23fe2b3f9e7df8da53ac1bc32c6875254911d7f4)
Signed-off-by: Michael Roth <address@hidden>
Commit: 57ea2d21ae1863fd4002b2aea8ea8db8e206d464
https://github.com/qemu/qemu/commit/57ea2d21ae1863fd4002b2aea8ea8db8e206d464
Author: Andrea Arcangeli <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M exec.c
Log Message:
-----------
exec: always use MADV_DONTFORK
MADV_DONTFORK prevents fork to fail with -ENOMEM if the default
overcommit heuristics decides there's too much anonymous virtual
memory allocated. If the KVM secondary MMU is synchronized with MMU
notifiers or not, doesn't make a difference in that regard.
Secondly it's always more efficient to avoid copying the guest
physical address space in the fork child (so we avoid to mark all the
guest memory readonly in the parent and so we skip the establishment
and teardown of lots of pagetables in the child).
In the common case we can ignore the error if MADV_DONTFORK is not
available. Leave a second invocation that errors out in the KVM path
if MMU notifiers are missing and KVM is enabled, to abort in such
case.
Signed-off-by: Andrea Arcangeli <address@hidden>
Tested-By: Benoit Canet <address@hidden>
Acked-by: Paolo Bonzini <address@hidden>
Signed-off-by: Gleb Natapov <address@hidden>
(cherry picked from commit 3e469dbfe413c25d48321c3a19ddfae0727dc6e5)
Signed-off-by: Michael Roth <address@hidden>
Commit: 9dbfbb89b204e098f283aca310e4d6f6651d88f4
https://github.com/qemu/qemu/commit/9dbfbb89b204e098f283aca310e4d6f6651d88f4
Author: Gerd Hoffmann <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M hw/usb/hcd-xhci.c
Log Message:
-----------
xhci: reset port when disabling slot
Cc: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
(cherry picked from commit 5c67dd7b4884979a2613a4702ac1ab68b0e6a16e)
Signed-off-by: Michael Roth <address@hidden>
Commit: 96b14d0db19b2b80ab3dc35d522671da82101e72
https://github.com/qemu/qemu/commit/96b14d0db19b2b80ab3dc35d522671da82101e72
Author: Gerd Hoffmann <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M hw/usb/core.c
Log Message:
-----------
usb: parallelize usb3 streams
usb3 bulk endpoints with streams are implicitly pipelined now,
so the requests will actually be processed in parallel. Also
allow them to complete out-of-order.
Fixes stalls in the uas driver.
Cc: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
(cherry picked from commit c96c41ed0d38d68a6c8b6f84751afebafeae31be)
Signed-off-by: Michael Roth <address@hidden>
Commit: e8601a4e3102321d054ce3d641c03ebcd0519357
https://github.com/qemu/qemu/commit/e8601a4e3102321d054ce3d641c03ebcd0519357
Author: Stefan Weil <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M block/raw-win32.c
Log Message:
-----------
w32: Fix access to host devices (regression)
QEMU failed to open host devices like \\.\PhysicalDrive0 (first hard disk)
since some time (commit 8a79380b8ef1b02d2abd705dd026a18863b09020?).
Those devices use hdev_open which did not use the latest API for options.
This resulted in a fatal runtime error:
Block protocol 'host_device' doesn't support the option 'filename'
Duplicate code from raw_open to fix this.
Cc: address@hidden
Reported-by: David Brenner <address@hidden>
Signed-off-by: Stefan Weil <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
(cherry picked from commit 68dc036488dfea170627a55e6ee3dfd7f2c2063e)
Signed-off-by: Michael Roth <address@hidden>
Commit: 7ab1044eb1ac2cbc7e65769edf44ced92b85b038
https://github.com/qemu/qemu/commit/7ab1044eb1ac2cbc7e65769edf44ced92b85b038
Author: Jan Kiszka <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M exec.c
M include/exec/ioport.h
M ioport.c
Log Message:
-----------
memory: Provide separate handling of unassigned io ports accesses
Accesses to unassigned io ports shall return -1 on read and be ignored
on write. Ensure these properties via dedicated ops, decoupling us from
the memory core's handling of unassigned accesses.
Cc: address@hidden
Signed-off-by: Jan Kiszka <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
(cherry picked from commit 3bb28b7208b349e7a1b326e3c6ef9efac1d462bf)
Signed-off-by: Michael Roth <address@hidden>
Commit: 2a93d3dd32386c3522cfa2ee60c9e06a298d1f52
https://github.com/qemu/qemu/commit/2a93d3dd32386c3522cfa2ee60c9e06a298d1f52
Author: Jan Kiszka <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M memory.c
Log Message:
-----------
Revert "memory: Return -1 again on reads from unsigned regions"
This reverts commit 9b8c69243585a32d14b9bb9fcd52c37b0b5a1b71.
The commit was wrong: We only return -1 on invalid accesses, not on
valid but unbacked ones. This broke various corner cases.
Cc: address@hidden
Signed-off-by: Jan Kiszka <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
(cherry picked from commit 68a7439a150d6b4da99082ab454b9328b151bc25)
Signed-off-by: Michael Roth <address@hidden>
Commit: 1110014801d368388bca2ed7c28aa695560c4991
https://github.com/qemu/qemu/commit/1110014801d368388bca2ed7c28aa695560c4991
Author: Hu Tao <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M exec.c
Log Message:
-----------
exec: check offset_within_address_space for register subpage
If offset_within_address_space falls in a page, then we register a
subpage. So check offset_within_address_space rather than
offset_within_region.
Cc: address@hidden
Cc: Paolo Bonzini <address@hidden>
Cc: Richard Henderson <address@hidden>
Cc: "Andreas Färber" <address@hidden>
Cc: Peter Maydell <address@hidden>
Cc: Blue Swirl <address@hidden>
Signed-off-by: Hu Tao <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
(cherry picked from commit 88266249701032211c1d7449460d063fbc01bf12)
Signed-off-by: Michael Roth <address@hidden>
Commit: a1991d05d37ac9054d772b32d8fac70bc31be81a
https://github.com/qemu/qemu/commit/a1991d05d37ac9054d772b32d8fac70bc31be81a
Author: Aurelien Jarno <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M hw/net/ne2000.c
Log Message:
-----------
ne2000: mark I/O as LITTLE_ENDIAN
Now that the memory subsystem is propagating the endianness correctly,
the ne2000 device should have its I/O ports marked as LITTLE_ENDIAN, as
PCI devices are little endian.
This makes the ne2000 NIC to work again on PowerPC.
Cc: address@hidden
Cc: Stefan Hajnoczi <address@hidden>
Signed-off-by: Aurelien Jarno <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
(cherry picked from commit 45d883dcf208160e2db308d1b368beb74f37dc7e)
Signed-off-by: Michael Roth <address@hidden>
Commit: b6d163fdd8131285a01fe46e6afdba727e4df9ca
https://github.com/qemu/qemu/commit/b6d163fdd8131285a01fe46e6afdba727e4df9ca
Author: Gerd Hoffmann <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M hw/usb/hcd-ehci.c
M hw/usb/hcd-ehci.h
Log Message:
-----------
ehci: save device pointer in EHCIState
We'll need a pointer to the actual pci/sysbus device,
stick a pointer to it into the EHCIState struct.
https://bugzilla.redhat.com/show_bug.cgi?id=1005495
Signed-off-by: Gerd Hoffmann <address@hidden>
(cherry picked from commit adbecc89731cf3e0ae656d50ea9fa58c589c4bdc)
Signed-off-by: Michael Roth <address@hidden>
Commit: dc0973b5883df7d822b285119691ade8c84dda9c
https://github.com/qemu/qemu/commit/dc0973b5883df7d822b285119691ade8c84dda9c
Author: Gerd Hoffmann <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M hw/display/qxl-render.c
Log Message:
-----------
qxl: fix local renderer
The local spice renderer assumes the primary surface is located at the
start of the "ram" bar. This used to be a requirement in qxl hardware
revision 1. In revision 2+ this is relaxed. Nevertheless guest drivers
continued to use the traditional location, for historical and backward
compatibility reasons. The qxl kms driver doesn't though as it depends
on qxl revision 4+ anyway.
Result is that local rendering is hosed for recent linux guests, you'll
get pixel garbage with non-spice ui (gtk, sdl, vnc) and when doing
screendumps. Fix that by doing a proper mapping of the guest-specified
memory location.
https://bugzilla.redhat.com/show_bug.cgi?id=948717
Signed-off-by: Gerd Hoffmann <address@hidden>
(cherry picked from commit c58c7b959b93b864a27fd6b3646ee1465ab8832b)
Signed-off-by: Michael Roth <address@hidden>
Commit: 755ec4ca0f92188458ad7ca549a75161cbdcf6ff
https://github.com/qemu/qemu/commit/755ec4ca0f92188458ad7ca549a75161cbdcf6ff
Author: Anthony PERARD <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M hw/i386/pc_piix.c
M include/hw/xen/xen.h
M xen-all.c
M xen-stub.c
Log Message:
-----------
pc: Initializing ram_memory under Xen.
Signed-off-by: Anthony PERARD <address@hidden>
Signed-off-by: Stefano Stabellini <address@hidden>
Acked-by: Michael S. Tsirkin <address@hidden>
CC: address@hidden
(cherry picked from commit 04d7bad8a4fb23e6d9af9d06ce3ddc28a251d94d)
Signed-off-by: Michael Roth <address@hidden>
Commit: 41900b0857df9bd33e465a6c72d7a3072dc448f4
https://github.com/qemu/qemu/commit/41900b0857df9bd33e465a6c72d7a3072dc448f4
Author: Anthony PERARD <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M hw/i386/pc_q35.c
Log Message:
-----------
pc_q35: Initialize Xen.
Signed-off-by: Anthony PERARD <address@hidden>
Signed-off-by: Stefano Stabellini <address@hidden>
Acked-by: Michael S. Tsirkin <address@hidden>
(cherry picked from commit 254c12825f93f405658ca3366cd34f8a8ad23511)
Signed-off-by: Michael Roth <address@hidden>
Commit: 8b4b3a71fd35d67c5c30652a120c0a59dfab7182
https://github.com/qemu/qemu/commit/8b4b3a71fd35d67c5c30652a120c0a59dfab7182
Author: Cole Robinson <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M scripts/qapi-types.py
Log Message:
-----------
qapi-types.py: Fix enum struct sizes on i686
Unlike other list types, enum wasn't adding any padding, which caused
a mismatch between the generated struct size and GenericList struct
size. More details in a678e26cbe89f7a27cbce794c2c2784571ee9d21
This crashed qemu if calling qmp query-tpm-types for example, which
upsets libvirt capabilities probing. Reproducer on i686:
(sleep 5; printf
'{"execute":"qmp_capabilities"}\n{"execute":"query-tpm-types"}\n') |
./i386-softmmu/qemu-system-i386 -S -nodefaults -nographic -M none -qmp stdio
https://bugs.launchpad.net/qemu/+bug/1219207
Cc: address@hidden
Signed-off-by: Cole Robinson <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Tested-by: Richard W.M. Jones <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>
(cherry picked from commit 02dc4bf5684d3fb46786fab2ecff98214b1df9fe)
Signed-off-by: Michael Roth <address@hidden>
Commit: 76f698948781a148d336ff9032159f6c7c9eccd2
https://github.com/qemu/qemu/commit/76f698948781a148d336ff9032159f6c7c9eccd2
Author: Aurelien Jarno <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M hw/net/pcnet-pci.c
Log Message:
-----------
pcnet-pci: mark I/O and MMIO as LITTLE_ENDIAN
Now that the memory subsystem is propagating the endianness correctly,
the pcnet-pci device should have its I/O ports and MMIO memory marked
as LITTLE_ENDIAN, as PCI devices are little endian.
This makes the pcnet-pci NIC to work again on big endian MIPS Malta
(default NIC).
Cc: address@hidden
Signed-off-by: Aurelien Jarno <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
(cherry picked from commit a26405b350c0d31d5ef53f3b459aeb6eaaf50db0)
Signed-off-by: Michael Roth <address@hidden>
Commit: 4b5b4721464495fe76fe6e2e033cbb61dce78eef
https://github.com/qemu/qemu/commit/4b5b4721464495fe76fe6e2e033cbb61dce78eef
Author: Gerd Hoffmann <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M qemu-char.c
Log Message:
-----------
chardev: fix pty_chr_timer
pty_chr_timer first calls pty_chr_update_read_handler(), then clears
timer_tag (because it is a one-shot timer). This is the wrong order
though. pty_chr_update_read_handler might re-arm time timer, and the
new timer_tag gets overwitten in that case.
This leads to crashes when unplugging a pty chardev: pty_chr_close
thinks no timer is running -> timer isn't canceled -> pty_chr_timer gets
called with stale CharDevState -> BOOM.
This patch fixes the ordering.
Kill the pointless goto while being at it.
https://bugzilla.redhat.com/show_bug.cgi?id=994414
Cc: address@hidden
Signed-off-by: Gerd Hoffmann <address@hidden>
(cherry picked from commit b0d768c35e08d2057b63e8e77e7a513c447199fa)
Signed-off-by: Michael Roth <address@hidden>
Commit: 50b31e80525d03ef406a8c9f55ff2ae1655a3b66
https://github.com/qemu/qemu/commit/50b31e80525d03ef406a8c9f55ff2ae1655a3b66
Author: Jan Kiszka <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M hw/i386/kvmvapic.c
Log Message:
-----------
kvmvapic: Catch invalid ROM size
If not caught early, a zero-length ROM will cause a NULL-pointer access
later on in patch_hypercalls when allocating a zero-length ROM copy and
trying to read from it.
CC: address@hidden
Signed-off-by: Jan Kiszka <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
(cherry picked from commit 18e5eec4db96a00907eb588a2b803401637c7f67)
Signed-off-by: Michael Roth <address@hidden>
Commit: 7ea8a3c12aa49efc8f503a019dd764f8a0add2cb
https://github.com/qemu/qemu/commit/7ea8a3c12aa49efc8f503a019dd764f8a0add2cb
Author: Jan Kiszka <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M hw/i386/kvmvapic.c
Log Message:
-----------
kvmvapic: Enter inactive state on hardware reset
ROM layout may change after reset of devices are hotplugged, so we have
to pick up the physical address again when the ROM is initialized. This
is best achieved by resetting the state to INACTIVE.
CC: address@hidden
Signed-off-by: Jan Kiszka <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
(cherry picked from commit c056bc3f3464cfae1c94b7dd633d3ec13b13b655)
Signed-off-by: Michael Roth <address@hidden>
Commit: 5d2de77798cacf1dadf6a4211972473e057cc6e5
https://github.com/qemu/qemu/commit/5d2de77798cacf1dadf6a4211972473e057cc6e5
Author: Jan Kiszka <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M hw/i386/kvmvapic.c
Log Message:
-----------
kvmvapic: Clear also physical ROM address when entering INACTIVE state
To avoid misinterpreting INACTIVE after migration as old qemu-kvm's
STANDBY, also clear rom_state_paddr when going back to this state.
CC: address@hidden
Signed-off-by: Jan Kiszka <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
(cherry picked from commit 4357930b8a7d2fcff2d8121ec518117428a781e7)
Signed-off-by: Michael Roth <address@hidden>
Commit: 5c20c1ffe791ca29840fd9607ea034ea24ad7bdd
https://github.com/qemu/qemu/commit/5c20c1ffe791ca29840fd9607ea034ea24ad7bdd
Author: Stefan Weil <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M tci.c
Log Message:
-----------
tci: Fix qemu-alpha on 32 bit hosts (wrong assertions)
Debian busybox-static for alpha has a load address of 0x0000000120000000
which is mapped to 0x0000000020000000 for 32 bit hosts.
qemu-alpha uses the TCG opcodes qemu_ld32, qemu_ld64, qemu_st32 and
qemu_st64 which all raise the assertion (taddr == host_addr).
Remove all assertions of this type because they are either wrong or
unnecessary (when sizeof(tcg_target_ulong) >= sizeof(target_ulong)).
Cc: qemu-stable <address@hidden>
Signed-off-by: Stefan Weil <address@hidden>
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
(cherry picked from commit 07ac4dc5db22a31e47b149abdbc5ea99013cf4de)
Signed-off-by: Michael Roth <address@hidden>
Commit: aeab582580fa057dbe646fc3277570af6a8d5ce8
https://github.com/qemu/qemu/commit/aeab582580fa057dbe646fc3277570af6a8d5ce8
Author: Paolo Bonzini <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M blockdev.c
Log Message:
-----------
blockdev: do not default cache.no-flush to true
That's why all my VMs were so fast lately. :)
This changed in 1.6.0 by mistake in patch 29c4e2b (blockdev: Split up
'cache' option, 2013-07-18).
Cc: address@hidden
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
(cherry picked from commit 1df6fa4bc6754a170cf511a78e2e6fef84eb5228)
Signed-off-by: Michael Roth <address@hidden>
Commit: c8adc0db7e76e804692372a06ca02cc5a80b67d5
https://github.com/qemu/qemu/commit/c8adc0db7e76e804692372a06ca02cc5a80b67d5
Author: Paolo Bonzini <address@hidden>
Date: 2013-09-24 (Tue, 24 Sep 2013)
Changed paths:
M hw/block/virtio-blk.c
M include/hw/virtio/virtio-blk.h
Log Message:
-----------
virtio-blk: do not relay a previous driver's WCE configuration to the current
The following sequence happens:
- the SeaBIOS virtio-blk driver does not support the WCE feature, which
causes QEMU to disable writeback caching
- the Linux virtio-blk driver resets the device, finds WCE is available
but writeback caching is disabled; tells block layer to not send cache
flush commands
- the Linux virtio-blk driver sets the DRIVER_OK bit, which causes
writeback caching to be re-enabled, but the Linux virtio-blk driver does
not know of this side effect and cache flushes remain disabled
The bug is at the third step. If the guest does know about CONFIG_WCE,
QEMU should ignore the WCE feature's state. The guest will control the
cache mode solely using configuration space. This change makes Linux
do flushes correctly, but Linux will keep SeaBIOS's writethrough mode.
Hence, whenever the guest is reset, the cache mode of the disk should
be reset to whatever was specified in the "-drive" option. With this
change, the Linux virtio-blk driver finds that writeback caching is
enabled, and tells the block layer to send cache flush commands
appropriately.
Reported-by: Rusty Russell <address@hidden
Cc: address@hidden
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
(cherry picked from commit ef5bc96268ceec64769617dc53b0ac3a20ff351c)
Signed-off-by: Michael Roth <address@hidden>
Commit: dc6fbaa8322ca53f46d9a6cc7e2f82de5362ea83
https://github.com/qemu/qemu/commit/dc6fbaa8322ca53f46d9a6cc7e2f82de5362ea83
Author: Gerd Hoffmann <address@hidden>
Date: 2013-09-25 (Wed, 25 Sep 2013)
Changed paths:
M hw/usb/hcd-xhci.c
Log Message:
-----------
xhci: emulate intr endpoint intervals correctly
Respect the interval for interrupt endpoints, so we don't finish
transfers as fast as possible but at the rate configured by the guest.
Fixes guest deadlocks triggered by interrupt storms.
Cc:
Signed-off-by: Gerd Hoffmann <address@hidden>
(cherry picked from commit 4d7a81c06f5f17e019a2d3a18300500bd64f6f40)
Signed-off-by: Michael Roth <address@hidden>
Commit: b314120afdbab3d29885f47fc83bc55f43765968
https://github.com/qemu/qemu/commit/b314120afdbab3d29885f47fc83bc55f43765968
Author: Michael Tokarev <address@hidden>
Date: 2013-09-26 (Thu, 26 Sep 2013)
Changed paths:
M util/iov.c
Log Message:
-----------
iov: avoid "orig_len may be used unitialized" warning
Signed-off-by: Wenchao Xia <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
(cherry picked from commit 2be178a475289286db80de5ddd7830e67e112bdd)
Signed-off-by: Michael Roth <address@hidden>
Commit: 6bbb9d8100c90deb4843bfa3cf36e75b843c495b
https://github.com/qemu/qemu/commit/6bbb9d8100c90deb4843bfa3cf36e75b843c495b
Author: Brad Smith <address@hidden>
Date: 2013-09-26 (Thu, 26 Sep 2013)
Changed paths:
M net/tap-bsd.c
Log Message:
-----------
tap: Use numbered tap/tun devices on all *BSD OS's
The following patch simplifies the *BSD tap/tun code and makes use of numbered
tap/tun interfaces on all *BSD OS's. NetBSD has a patch in their pkgsrc tree
to make use of this feature and DragonFly also supports this as well.
Signed-off-by: Brad Smith <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
(cherry picked from commit aa4f082f7526d39dac8e2ca64d192d858014ee10)
Signed-off-by: Michael Roth <address@hidden>
Commit: fc06b430942e84a2a69e2a80a6d5b376a8064020
https://github.com/qemu/qemu/commit/fc06b430942e84a2a69e2a80a6d5b376a8064020
Author: Stefan Hajnoczi <address@hidden>
Date: 2013-09-30 (Mon, 30 Sep 2013)
Changed paths:
M block/rbd.c
Log Message:
-----------
rbd: avoid qemu_rbd_snap_list() memory leaks
When there are no snapshots qemu_rbd_snap_list() returns 0 and the
snapshot table pointer is NULL. Don't forget to free the snaps buffer
we allocated for librbd rbd_snap_list().
When the function succeeds don't forget to free the snaps buffer after
calling rbd_snap_list_end().
Cc: address@hidden
Signed-off-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
(cherry picked from commit 9e6337d0818650362149b734d53edf9489f3acaa)
Signed-off-by: Michael Roth <address@hidden>
Commit: 61fbeb6e81f648d25c2d3ba5f0d663d54abed1c1
https://github.com/qemu/qemu/commit/61fbeb6e81f648d25c2d3ba5f0d663d54abed1c1
Author: Fam Zheng <address@hidden>
Date: 2013-09-30 (Mon, 30 Sep 2013)
Changed paths:
M block/vmdk.c
Log Message:
-----------
vmdk: fix cluster size check for flat extents
We use the extent size as cluster size for flat extents (where no L1/L2
table is allocated so it's safe) reuse sector calculating code with
sparse extents.
Don't pass in the cluster size for adding flat extent, just set it to
sectors later, then the cluster size checking will not fail.
The cluster_sectors is changed to int64_t to allow big flat extent.
Without this, flat extent opening is broken:
# qemu-img create -f vmdk -o subformat=monolithicFlat /tmp/a.vmdk 100G
Formatting '/tmp/a.vmdk', fmt=vmdk size=107374182400 compat6=off
subformat='monolithicFlat' zeroed_grain=off
# qemu-img info /tmp/a.vmdk
image: /tmp/a.vmdk
file format: raw
virtual size: 0 (0 bytes)
disk size: 4.0K
Signed-off-by: Fam Zheng <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
(cherry picked from commit 301c7d38a0c359b91526391d13617386f3d9bb29)
Signed-off-by: Michael Roth <address@hidden>
Commit: ae00a27feab0ca12d2a802cfae9ee65ba3d43602
https://github.com/qemu/qemu/commit/ae00a27feab0ca12d2a802cfae9ee65ba3d43602
Author: Michael S. Tsirkin <address@hidden>
Date: 2013-09-30 (Mon, 30 Sep 2013)
Changed paths:
M hw/acpi/piix4.c
Log Message:
-----------
piix4: disable io on reset
io base register at 0x40 is cleared on reset,
but io is not disabled until some other event
happens to call pm_io_space_update.
Invoke pm_io_space_update directly to make this
consistent.
Cc: address@hidden
Signed-off-by: Michael S. Tsirkin <address@hidden>
(cherry picked from commit c046e8c4a26c902ca1b4f5bdf668a2da6bc75f54)
Signed-off-by: Michael Roth <address@hidden>
Commit: ba20326a937421c50a775907dc9ac726bb9a9b50
https://github.com/qemu/qemu/commit/ba20326a937421c50a775907dc9ac726bb9a9b50
Author: Stefan Hajnoczi <address@hidden>
Date: 2013-09-30 (Mon, 30 Sep 2013)
Changed paths:
M configure
M qemu-coroutine.c
Log Message:
-----------
coroutine: add ./configure --disable-coroutine-pool
The 'gthread' coroutine backend was written before the freelist (aka
pool) existed in qemu-coroutine.c.
This means that every thread is expected to exit when its coroutine
terminates. It is not possible to reuse threads from a pool.
This patch automatically disables the pool when 'gthread' is used. This
allows the 'gthread' backend to work again (for example,
tests/test-coroutine completes successfully instead of hanging).
I considered implementing thread reuse but I don't want quirks like CPU
affinity differences due to coroutine threads being recycled. The
'gthread' backend is a reference backend and it's therefore okay to skip
the pool optimization.
Note this patch also makes it easy to toggle the pool for benchmarking
purposes:
./configure --with-coroutine-backend=ucontext \
--disable-coroutine-pool
Reported-by: Gabriel Kerneis <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Gabriel Kerneis <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
(cherry picked from commit 70c60c089fdc6bf8a79324e492c13e8c08d55942)
Signed-off-by: Michael Roth <address@hidden>
Commit: bc05a488b49f903e404323b76ca9b675318393fc
https://github.com/qemu/qemu/commit/bc05a488b49f903e404323b76ca9b675318393fc
Author: Liu, Jinsong <address@hidden>
Date: 2013-10-01 (Tue, 01 Oct 2013)
Changed paths:
M hw/acpi/core.c
M include/sysemu/sysemu.h
M vl.c
Log Message:
-----------
qemu: Adjust qemu wakeup
Currently Xen hvm s3 has a bug coming from the difference between
qemu-traditioanl and qemu-xen. For qemu-traditional, the way to
resume from hvm s3 is via 'xl trigger' command. However, for
qemu-xen, the way to resume from hvm s3 inherited from standard
qemu, i.e. via QMP, and it doesn't work under Xen.
The root cause is, for qemu-xen, 'xl trigger' command didn't reset
devices, while QMP didn't unpause hvm domain though they did qemu
system reset.
We have two qemu patches and one xl patch to fix Xen hvm s3 bug.
This patch is the qemu patch 1. It adjusts qemu wakeup so that
Xen s3 resume logic (which will be implemented at qemu patch 2)
will be notified after qemu system reset.
Signed-off-by: Liu Jinsong <address@hidden>
Signed-off-by: Stefano Stabellini <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Reviewed-by: Anthony PERARD <address@hidden>
(cherry picked from commit 4bc78a877252d772b983810a7d2c0be00e9be70e)
Signed-off-by: Michael Roth <address@hidden>
Commit: 1b5f7709411a412ec8ce21004a47f51ab6c3f3ad
https://github.com/qemu/qemu/commit/1b5f7709411a412ec8ce21004a47f51ab6c3f3ad
Author: Liu, Jinsong <address@hidden>
Date: 2013-10-01 (Tue, 01 Oct 2013)
Changed paths:
M xen-all.c
Log Message:
-----------
qemu: Add qemu xen logic for Xen HVM S3 resume
This patch is qemu patch 2 to fix Xen HVM S3 bug, adding qemu
xen logic. When qemu wakeup, qemu xen logic is notified and
hypercall to xen hypervisor to unpause domain.
Signed-off-by: Liu Jinsong <address@hidden>
Signed-off-by: Stefano Stabellini <address@hidden>
Reviewed-by: Anthony PERARD <address@hidden>
(cherry picked from commit 11addd0ab9371af2b6ec028c7fe4e4c4992252fc)
Signed-off-by: Michael Roth <address@hidden>
Commit: fdcbe7d587a64dec0db0d3c9a3b230c39efbfeef
https://github.com/qemu/qemu/commit/fdcbe7d587a64dec0db0d3c9a3b230c39efbfeef
Author: Asias He <address@hidden>
Date: 2013-10-04 (Fri, 04 Oct 2013)
Changed paths:
M hw/scsi/scsi-bus.c
M include/hw/scsi/scsi.h
Log Message:
-----------
scsi: Allocate SCSITargetReq r->buf dynamically
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1007330
Brew: https://brewweb.devel.redhat.com/taskinfo?taskID=6282465
This is the backport of the following commit. The patch is not
sent public since it is a embargoed bug.
r->buf is hardcoded to 2056 which is (256 + 1) * 8, allowing 256 luns at
most. If more than 256 luns are specified by user, we have buffer
overflow in scsi_target_emulate_report_luns.
To fix, we allocate the buffer dynamically.
Signed-off-by: Asias He <address@hidden>
Signed-off-by: Asias He <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
*s/&r->buf/r->buf/ due to type change
Signed-off-by: Michael Roth <address@hidden>
Commit: 62ecc3a0e3c77a4944c92a02dd7fae2ab1f2290d
https://github.com/qemu/qemu/commit/62ecc3a0e3c77a4944c92a02dd7fae2ab1f2290d
Author: Michael Roth <address@hidden>
Date: 2013-10-04 (Fri, 04 Oct 2013)
Changed paths:
M VERSION
Log Message:
-----------
Update VERSION for 1.6.1 release
Signed-off-by: Michael Roth <address@hidden>
Compare: https://github.com/qemu/qemu/compare/670599a08c05^...62ecc3a0e3c7
| [Prev in Thread] |
Current Thread |
[Next in Thread] |
- [Qemu-commits] [qemu/qemu] 670599: block: ensure bdrv_drain_all() works during bdrv_d...,
GitHub <=