qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 85711e: tcg/mips: fix invalid op definition e


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 85711e: tcg/mips: fix invalid op definition errors
Date: Thu, 08 Aug 2013 14:30:11 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 85711e6bafb1910b50ff181e8507cb904ef7e84d
      
https://github.com/qemu/qemu/commit/85711e6bafb1910b50ff181e8507cb904ef7e84d
  Author: James Hogan <address@hidden>
  Date:   2013-08-08 (Thu, 08 Aug 2013)

  Changed paths:
    M tcg/mips/tcg-target.c

  Log Message:
  -----------
  tcg/mips: fix invalid op definition errors

tcg/mips/tcg-target.h defines various operations conditionally depending
upon the isa revision, however these operations are included in
mips_op_defs[] unconditionally resulting in the following runtime errors
if CONFIG_DEBUG_TCG is defined:

Invalid op definition for movcond_i32
Invalid op definition for rotl_i32
Invalid op definition for rotr_i32
Invalid op definition for deposit_i32
Invalid op definition for bswap16_i32
Invalid op definition for bswap32_i32
tcg/tcg.c:1196: tcg fatal error

Fix with ifdefs like the i386 backend does for movcond_i32.

Signed-off-by: James Hogan <address@hidden>
Cc: Aurelien Jarno <address@hidden>
Cc: Richard Henderson <address@hidden>
Signed-off-by: Aurelien Jarno <address@hidden>


  Commit: 2e985fe000e73097e325e18b943e8babfa96c35c
      
https://github.com/qemu/qemu/commit/2e985fe000e73097e325e18b943e8babfa96c35c
  Author: Aurelien Jarno <address@hidden>
  Date:   2013-08-08 (Thu, 08 Aug 2013)

  Changed paths:
    M hw/mips/mips_fulong2e.c
    M hw/mips/mips_jazz.c
    M hw/mips/mips_malta.c
    M hw/mips/mips_mipssim.c

  Log Message:
  -----------
  mips: revert commit b332d24a8e1290954029814d09156b06ede358e2

Now that this code path is not triggered anymore during the tests,
revert commit b332d24a8e1290954029814d09156b06ede358e2. Booting a MIPS
target without kernel nor bios doesn't really make sense. At the same
time replace fprintf(stderr, ...) by error_report().

Reviewed-by: Andreas Färber <address@hidden>
Signed-off-by: Aurelien Jarno <address@hidden>


Compare: https://github.com/qemu/qemu/compare/6fdf98f281f8...2e985fe000e7

reply via email to

[Prev in Thread] Current Thread [Next in Thread]