[Qemu-commits] [qemu/qemu] 9220ee: aes: Remove unused code (NDEBUG, u16)

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 9220eeed62e06e115c83e6ffed24907c24c99197
      
https://github.com/qemu/qemu/commit/9220eeed62e06e115c83e6ffed24907c24c99197
  Author: Stefan Weil <address@hidden>
  Date:   2013-07-27 (Sat, 27 Jul 2013)

  Changed paths:
    M util/aes.c

  Log Message:
  -----------
  aes: Remove unused code (NDEBUG, u16)

The current code includes assert.h very early (from qemu-common.h),
so the definition of NDEBUG was without any effect.

In the initial version from 2004, NDEBUG was used to disable the assertions.
Those assertions are not in time critical code, so it is no longer
reasonable to disable them and the definition of NDEBUG can be removed.

Type u16 is also unused and therefore does not need a type definition.

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: d9cd4007d5c7e877a006392eeafb2291f06d6685
      
https://github.com/qemu/qemu/commit/d9cd4007d5c7e877a006392eeafb2291f06d6685
  Author: Liu Ping Fan <address@hidden>
  Date:   2013-07-27 (Sat, 27 Jul 2013)

  Changed paths:
    M cpus.c

  Log Message:
  -----------
  timer: make timers_state static

Signed-off-by: Liu Ping Fan <address@hidden>
Reviewed-by: Jan Kiszka <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 80cba1b71eb9a75404d1effddec8ffa9f0d6d6fb
      
https://github.com/qemu/qemu/commit/80cba1b71eb9a75404d1effddec8ffa9f0d6d6fb
  Author: Stefan Weil <address@hidden>
  Date:   2013-07-27 (Sat, 27 Jul 2013)

  Changed paths:
    M hw/9pfs/virtio-9p-proxy.c

  Log Message:
  -----------
  hw/9pfs: Fix potential memory leak and avoid reuse of freed memory

The leak was reported by cppcheck.

Function proxy_init also calls g_free for ctx->fs_root.
Avoid reuse of this memory by setting ctx->fs_root to NULL.

Signed-off-by: Stefan Weil <address@hidden>
Reviewed-by: M. Mohan Kumar <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 0dd60ae2f4efd2966e8d6cb7db653d5d17a68c62
      
https://github.com/qemu/qemu/commit/0dd60ae2f4efd2966e8d6cb7db653d5d17a68c62
  Author: Stefan Weil <address@hidden>
  Date:   2013-07-27 (Sat, 27 Jul 2013)

  Changed paths:
    M include/exec/poison.h

  Log Message:
  -----------
  exec: Remove env from list of poisoned names

The global variable env was removed some time ago, so this name may be
used without any restriction now.

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: f6019e5fada012f7f396c89968f2c242f92f40df
      
https://github.com/qemu/qemu/commit/f6019e5fada012f7f396c89968f2c242f92f40df
  Author: Stefan Weil <address@hidden>
  Date:   2013-07-27 (Sat, 27 Jul 2013)

  Changed paths:
    M hw/watchdog/watchdog.c

  Log Message:
  -----------
  watchdog: Remove break after exit

This was dead code.

Signed-off-by: Stefan Weil <address@hidden>
Reviewed-by: Andreas Färber <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 04dd125942b11136a8c96d36591ad043b8653a7b
      
https://github.com/qemu/qemu/commit/04dd125942b11136a8c96d36591ad043b8653a7b
  Author: Stefan Weil <address@hidden>
  Date:   2013-07-27 (Sat, 27 Jul 2013)

  Changed paths:
    M hw/ide/macio.c

  Log Message:
  -----------
  PPC: dbdma: macio: Fix format specifiers (build regression)

Fix a number of warnings for 32 bit builds (tested on MingW and Linux):

  CC    hw/ide/macio.o
qemu/hw/ide/macio.c: In function 'pmac_ide_atapi_transfer_cb':
qemu/hw/ide/macio.c:134:9: error: format '%lx' expects argument of type 'long 
unsigned int', but argument 3 has type 'hwaddr' [-Werror=format]
qemu/hw/ide/macio.c: In function 'pmac_ide_transfer_cb':
qemu/hw/ide/macio.c:215:5: error: format '%ld' expects argument of type 'long 
int', but argument 5 has type 'int64_t' [-Werror=format]
qemu/hw/ide/macio.c:222:9: error: format '%lx' expects argument of type 'long 
unsigned int', but argument 3 has type 'hwaddr' [-Werror=format]
qemu/hw/ide/macio.c:264:9: error: format '%lx' expects argument of type 'long 
unsigned int', but argument 3 has type 'hwaddr' [-Werror=format]
cc1: all warnings being treated as errors
make: *** [hw/ide/macio.o] Error 1

Signed-off-by: Stefan Weil <address@hidden>
Acked-by: Alexander Graf <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 6064be7912ab262f0abd85ad042fafd435ad6651
      
https://github.com/qemu/qemu/commit/6064be7912ab262f0abd85ad042fafd435ad6651
  Author: Petar Jovanovic <address@hidden>
  Date:   2013-07-27 (Sat, 27 Jul 2013)

  Changed paths:
    M linux-user/main.c

  Log Message:
  -----------
  linux-user: correct argument number for sys_mremap and sys_splice

sys_mremap missed 5th argument (new_address), which caused examples that
remap to a specific address to fail.
sys_splice missed 5th and 6th argument which caused different examples to
fail.
This change has an effect on MIPS target only.

Signed-off-by: Petar Jovanovic <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 52f350227f737b649f09e56ed32eaf1265605611
      
https://github.com/qemu/qemu/commit/52f350227f737b649f09e56ed32eaf1265605611
  Author: Stefan Weil <address@hidden>
  Date:   2013-07-27 (Sat, 27 Jul 2013)

  Changed paths:
    M block/vhdx.h
    M docs/rdma.txt
    M hw/virtio/virtio-balloon.c
    M hw/xen/xen_pt.c
    M migration-rdma.c

  Log Message:
  -----------
  misc: Fix new typos in comments and strings

All these typos were found by codespell.

sould -> should
emperical -> empirical
intialization -> initialization
successfuly -> successfully
gaurantee -> guarantee

Fix also another error (before before) in the same context.

Signed-off-by: Stefan Weil <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: b031f413b9e68899032f04fc05fd0a6b62039b2b
      
https://github.com/qemu/qemu/commit/b031f413b9e68899032f04fc05fd0a6b62039b2b
  Author: Ramkumar Ramachandra <address@hidden>
  Date:   2013-07-27 (Sat, 27 Jul 2013)

  Changed paths:
    M qemu-options.hx

  Log Message:
  -----------
  qemu-options: mention C-a h in the -nographic doc

Otherwise, a new user will be wondering how to switch between the
console and monitor.

Cc: Anthony Liguori <address@hidden>
Cc: Stefan Hajnoczi <address@hidden>
Cc: Markus Armbruster <address@hidden>
Cc: Marcelo Tosatti <address@hidden>
Cc: Peter Maydell <address@hidden>
Signed-off-by: Ramkumar Ramachandra <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: dfc6f86567c58bc4dd02f4db098fc4c2221e85b5
      
https://github.com/qemu/qemu/commit/dfc6f86567c58bc4dd02f4db098fc4c2221e85b5
  Author: Stefan Weil <address@hidden>
  Date:   2013-07-27 (Sat, 27 Jul 2013)

  Changed paths:
    M blockdev.c
    M hw/net/vmxnet3.c
    M hw/net/vmxnet_tx_pkt.c
    M hw/usb/hcd-ehci.c
    M net/eth.c
    M qdev-monitor.c
    M target-arm/helper.c
    M tests/test-qmp-input-visitor.c
    M tests/test-qmp-output-visitor.c
    M tests/test-visitor-serialization.c

  Log Message:
  -----------
  misc: Use g_assert_not_reached for code which is expected to be unreachable

The macro g_assert_not_reached is a better self documenting replacement
for assert(0) or assert(false).

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: 6c86f405efd6532b58ad1b607cc9f11e856ef5ca
      
https://github.com/qemu/qemu/commit/6c86f405efd6532b58ad1b607cc9f11e856ef5ca
  Author: Stefan Weil <address@hidden>
  Date:   2013-07-27 (Sat, 27 Jul 2013)

  Changed paths:
    M target-mips/op_helper.c

  Log Message:
  -----------
  target-mips: Remove assignment to a variable which is never used

This assignment causes a compiler warning for compilations with the compiler
option -Wunused-but-set-variable (which is included with -Wextra).

Removing it allows using -Wextra for QEMU code without suppressing too many
extra warnings.

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>


  Commit: f05d4d94d6bb0e240e6cfda65972fd86601f9f0d
      
https://github.com/qemu/qemu/commit/f05d4d94d6bb0e240e6cfda65972fd86601f9f0d
  Author: Aurelien Jarno <address@hidden>
  Date:   2013-07-28 (Sun, 28 Jul 2013)

  Changed paths:
    M hw/mips/mips_malta.c

  Log Message:
  -----------
  mips_malta: fix copy of the 0x1fc00000 region

Copy the whole 0x1fe000000 region into 0x1fc00000, independently of the
loaded BIOS size. This fix the MIPS make check tests.

Reported-by: Andreas Färber <address@hidden>
Tested-by: Andreas Färber <address@hidden>
Cc: Paul Burton <address@hidden>
Cc: Leon Alrae <address@hidden>
Signed-off-by: Aurelien Jarno <address@hidden>


  Commit: b6a9f4682e62c686995cc1a1fe2ef4a57a92020b
      
https://github.com/qemu/qemu/commit/b6a9f4682e62c686995cc1a1fe2ef4a57a92020b
  Author: Petar Jovanovic <address@hidden>
  Date:   2013-07-28 (Sun, 28 Jul 2013)

  Changed paths:
    M target-mips/dsp_helper.c
    M tests/tcg/mips/mips32-dsp/dpaq_sa_l_w.c
    M tests/tcg/mips/mips32-dsp/dpsq_sa_l_w.c

  Log Message:
  -----------
  target-mips: fix mipsdsp_mul_q31_q31

Multiplication of two fractional word elements is not correct when sign
extension/promotion is needed. This change fixes it by adding correct
casts from unsigned to signed values.
In addition, the tests (dpaq_sa_l_w.c and dpsq_sa_l_w.c) have been extended
to trigger the current issue.

Signed-off-by: Petar Jovanovic <address@hidden>
Signed-off-by: Aurelien Jarno <address@hidden>


  Commit: 461bdb3414c40d6806194bf68c91521496b1042d
      
https://github.com/qemu/qemu/commit/461bdb3414c40d6806194bf68c91521496b1042d
  Author: Aurelien Jarno <address@hidden>
  Date:   2013-07-29 (Mon, 29 Jul 2013)

  Changed paths:
    M block/vhdx.h
    M blockdev.c
    M cpus.c
    M docs/rdma.txt
    M hw/9pfs/virtio-9p-proxy.c
    M hw/ide/macio.c
    M hw/net/vmxnet3.c
    M hw/net/vmxnet_tx_pkt.c
    M hw/usb/hcd-ehci.c
    M hw/virtio/virtio-balloon.c
    M hw/watchdog/watchdog.c
    M hw/xen/xen_pt.c
    M include/exec/poison.h
    M migration-rdma.c
    M net/eth.c
    M qdev-monitor.c
    M qemu-options.hx
    M target-arm/helper.c
    M tests/test-qmp-input-visitor.c
    M tests/test-qmp-output-visitor.c
    M tests/test-visitor-serialization.c
    M util/aes.c

  Log Message:
  -----------
  Merge branch 'trivial-patches' of git://git.corpit.ru/qemu

* 'trivial-patches' of git://git.corpit.ru/qemu:
  target-mips: Remove assignment to a variable which is never used
  misc: Use g_assert_not_reached for code which is expected to be unreachable
  qemu-options: mention C-a h in the -nographic doc
  misc: Fix new typos in comments and strings
  linux-user: correct argument number for sys_mremap and sys_splice
  PPC: dbdma: macio: Fix format specifiers (build regression)
  watchdog: Remove break after exit
  exec: Remove env from list of poisoned names
  hw/9pfs: Fix potential memory leak and avoid reuse of freed memory
  timer: make timers_state static
  aes: Remove unused code (NDEBUG, u16)


Compare: https://github.com/qemu/qemu/compare/b0932e0617c6...461bdb3414c4