[Qemu-commits] [qemu/qemu] 0d185e: configure: Provide more helpful message if libvte ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 0d185e638861bd9b05b2abb43774a368cadabd38
      
https://github.com/qemu/qemu/commit/0d185e638861bd9b05b2abb43774a368cadabd38
  Author: Peter Maydell <address@hidden>
  Date:   2013-07-18 (Thu, 18 Jul 2013)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Provide more helpful message if libvte not present

If the system has GTK but not libvte, it's more helpful to
tell the user that libvte is missing than to simply say that
GTK is not present.

Signed-off-by: Peter Maydell <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: ac8c26f633b01bb32cdf347f9dbd5a80c6712925
      
https://github.com/qemu/qemu/commit/ac8c26f633b01bb32cdf347f9dbd5a80c6712925
  Author: Laszlo Ersek <address@hidden>
  Date:   2013-07-18 (Thu, 18 Jul 2013)

  Changed paths:
    M qemu-char.c

  Log Message:
  -----------
  char: io_channel_send: don't lose written bytes

The g_io_channel_write_chars() documentation states,

  bytes_written: The number of bytes written. This can be nonzero even if
           the return value is not G_IO_STATUS_NORMAL. [...]

io_channel_send() could lose such bytes before.

Furthermore, the (status == G_IO_STATUS_EOF) condition used to evaluate to
constant false whenever it was reached. When that condition actually held,
it always led to -1 / EINVAL. This patch (almost) distinguishes
G_IO_STATUS_EOF only when no bytes have been written, and then treats it
as an error.

Signed-off-by: Laszlo Ersek <address@hidden>
Reviewed-by: Amit Shah <address@hidden>
Reviewed-by: Anthony Liguori <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 293d2a0014a0e849477413f55aaa05f2743b2e04
      
https://github.com/qemu/qemu/commit/293d2a0014a0e849477413f55aaa05f2743b2e04
  Author: Laszlo Ersek <address@hidden>
  Date:   2013-07-18 (Thu, 18 Jul 2013)

  Changed paths:
    M monitor.c

  Log Message:
  -----------
  monitor: maintain at most one G_IO_OUT watch

When monitor_flush() is invoked repeatedly outside the monitor_unblocked()
callback, for example from tlb_info() -> ... -> print_pte(), several
watches may be added for the same event.

This is no problem per se because the extra monitor_unblocked() callbacks
are harmless if mon->outbuf is empty, the watches will be removed
gradually. However a big number of watches can grow "gpollfds" without
limit in glib_pollfds_fill(), triggering a -1/EINVAL condition in
g_poll().

Keep at most one such watch, by following the pattern observable in eg.
commits c874ea97 and c3d6b96e. The change has no effect when
monitor_unblocked() calls monitor_flush() (when the watch can either be
removed or renewed 1-for-1), but non-callback contexts won't create an
additional watch when the monitor already has one.

Related RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=970047

Signed-off-by: Laszlo Ersek <address@hidden>
Reviewed-by: Amit Shah <address@hidden>
Reviewed-by: Anthony Liguori <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: fdd26fca3ce66863e547560fbde1a444fc5d71b7
      
https://github.com/qemu/qemu/commit/fdd26fca3ce66863e547560fbde1a444fc5d71b7
  Author: Markus Armbruster <address@hidden>
  Date:   2013-07-18 (Thu, 18 Jul 2013)

  Changed paths:
    M tests/libqtest.c

  Log Message:
  -----------
  libqtest: Plug fd and memory leaks in qtest_quit()

Reviewed-by: Anthony Liguori <address@hidden>
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Andreas Färber <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 1d9358e686125c125b52529fa68baf36aa2d0d09
      
https://github.com/qemu/qemu/commit/1d9358e686125c125b52529fa68baf36aa2d0d09
  Author: Markus Armbruster <address@hidden>
  Date:   2013-07-18 (Thu, 18 Jul 2013)

  Changed paths:
    M tests/fdc-test.c
    M tests/hd-geo-test.c
    M tests/ide-test.c
    M tests/libqtest.h

  Log Message:
  -----------
  libqtest: New qtest_end() to go with qtest_start()

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Andreas Färber <address@hidden>
Reviewed-by: Anthony Liguori <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


Compare: https://github.com/qemu/qemu/compare/28199c48ed44...1d9358e68612