[Qemu-commits] [qemu/qemu] c3cb8e: ioport: remove LITTLE_ENDIAN mark for portio

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: c3cb8e77804313e1be99b5f28a34a346736707a5
      
https://github.com/qemu/qemu/commit/c3cb8e77804313e1be99b5f28a34a346736707a5
  Author: Anthony Liguori <address@hidden>
  Date:   2013-07-12 (Fri, 12 Jul 2013)

  Changed paths:
    M ioport.c

  Log Message:
  -----------
  ioport: remove LITTLE_ENDIAN mark for portio

Setting it to LE forces a byte swap when host != guest endian but
this makes no sense at all.

Herve made the suggestion upon observing that word writes/reads
were broken into byte writes/reads in such a way as to assume
devices are interpret registers as LE.

However, even if this were a problem, marking the region as LE is
not useful because what's essentially happening here is that LE is
open coded.  So by marking it LE in MemoryRegionOps, we're doing a
superflous swap.

Now, the portio code is suspicious to begin with.  The dispatch
layer really has no purpose in splitting I/O requests in the first
place...

Cc: Hervé Poussineau <address@hidden>
Cc: Alex Graf <address@hidden>
Cc: Benjamin Herrenschmidt <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>