[Qemu-commits] [qemu/qemu] 0f9530: qemu-char: Fix ringbuf option size

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 0f953051178f2e3df36efa5158a71f33d35fa812
      
https://github.com/qemu/qemu/commit/0f953051178f2e3df36efa5158a71f33d35fa812
  Author: Markus Armbruster <address@hidden>
  Date:   2013-07-10 (Wed, 10 Jul 2013)

  Changed paths:
    M qemu-char.c

  Log Message:
  -----------
  qemu-char: Fix ringbuf option size

Any attempt to use it trips an "opt->desc->type == QEMU_OPT_NUMBER"
assertion.  Broken in commit 1da48c65.

Cc: address@hidden
Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: bd9927fee4e63b451b4ef67a4c49729070d8b05d
      
https://github.com/qemu/qemu/commit/bd9927fee4e63b451b4ef67a4c49729070d8b05d
  Author: Kevin Wolf <address@hidden>
  Date:   2013-07-10 (Wed, 10 Jul 2013)

  Changed paths:
    M scripts/qapi.py

  Log Message:
  -----------
  qapi.py: Avoid code duplication

The code that interprets the read JSON expression and appends types to
the respective global variables was duplicated. We can avoid that by
splitting off the part that reads from the file.

Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Michael Roth <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: b35284ea207a0ae1c0b162344cdef2a83304befc
      
https://github.com/qemu/qemu/commit/b35284ea207a0ae1c0b162344cdef2a83304befc
  Author: Kevin Wolf <address@hidden>
  Date:   2013-07-10 (Wed, 10 Jul 2013)

  Changed paths:
    M scripts/qapi.py

  Log Message:
  -----------
  qapi.py: Allow top-level type reference for command definitions

If 'data' for a command definition isn't a dict, but a string, it is
taken as a (struct) type name and the fields of this struct are directly
used as parameters.

This is useful for transactionable commands that can use the same type
definition for both the transaction action and the arguments of the
standalone command.

Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Michael Roth <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 852ad1a900a4ae23514e1a53c86632543592c31b
      
https://github.com/qemu/qemu/commit/852ad1a900a4ae23514e1a53c86632543592c31b
  Author: Kevin Wolf <address@hidden>
  Date:   2013-07-10 (Wed, 10 Jul 2013)

  Changed paths:
    M qapi-schema.json

  Log Message:
  -----------
  qapi-schema: Use BlockdevSnapshot type for blockdev-snapshot-sync

We don't have to duplicate the definition any more now that we may refer
to a type instead.

Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Michael Roth <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: f53cae50f81449596e55159cfe61efbef9246b2e
      
https://github.com/qemu/qemu/commit/f53cae50f81449596e55159cfe61efbef9246b2e
  Author: Kevin Wolf <address@hidden>
  Date:   2013-07-10 (Wed, 10 Jul 2013)

  Changed paths:
    M qapi-schema.json

  Log Message:
  -----------
  qapi-schema: Use existing type for drive-backup arguments

This removes duplicated definitions and documentation by reusing the
existing data type.

Signed-off-by: Kevin Wolf <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 5e2ac5191772dea782ff78e95edd395985273019
      
https://github.com/qemu/qemu/commit/5e2ac5191772dea782ff78e95edd395985273019
  Author: Seiji Aguchi <address@hidden>
  Date:   2013-07-10 (Wed, 10 Jul 2013)

  Changed paths:
    M include/qemu/error-report.h
    M qemu-options.hx
    M util/qemu-error.c
    M vl.c

  Log Message:
  -----------
  add timestamp to error_report()

[Issue]
When we offer a customer support service and a problem happens
in a customer's system, we try to understand the problem by
comparing what the customer reports with message logs of the
customer's system.

In this case, we often need to know when the problem happens.

But, currently, there is no timestamp in qemu's error messages.
Therefore, we may not be able to understand the problem based on
error messages.

[Solution]
Add a timestamp to qemu's error message logged by
error_report() with g_time_val_to_iso8601().

Signed-off-by: Seiji Aguchi <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: c170a23ca0097a95b44fc7cc604018cd3c3b7d44
      
https://github.com/qemu/qemu/commit/c170a23ca0097a95b44fc7cc604018cd3c3b7d44
  Author: Anthony Liguori <address@hidden>
  Date:   2013-07-10 (Wed, 10 Jul 2013)

  Changed paths:
    M include/qemu/error-report.h
    M qapi-schema.json
    M qemu-char.c
    M qemu-options.hx
    M scripts/qapi.py
    M util/qemu-error.c
    M vl.c

  Log Message:
  -----------
  Merge remote-tracking branch 'luiz/queue/qmp' into staging

# By Kevin Wolf (4) and others
# Via Luiz Capitulino
* luiz/queue/qmp:
  add timestamp to error_report()
  qapi-schema: Use existing type for drive-backup arguments
  qapi-schema: Use BlockdevSnapshot type for blockdev-snapshot-sync
  qapi.py: Allow top-level type reference for command definitions
  qapi.py: Avoid code duplication
  qemu-char: Fix ringbuf option size

Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


Compare: https://github.com/qemu/qemu/compare/51455c59ddc3...c170a23ca009