[Qemu-commits] [qemu/qemu] c0afa9: qapi: qapi-types.py, native list support

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: c0afa9c5f717d0ebf10c70c305974ebbffe4c71f
      
https://github.com/qemu/qemu/commit/c0afa9c5f717d0ebf10c70c305974ebbffe4c71f
  Author: Michael Roth <address@hidden>
  Date:   2013-05-23 (Thu, 23 May 2013)

  Changed paths:
    M scripts/qapi-types.py
    M scripts/qapi.py

  Log Message:
  -----------
  qapi: qapi-types.py, native list support

Teach type generators about native types so they can generate the
appropriate linked list types.

Signed-off-by: Michael Roth <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Reviewed-by: Amos Kong <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: c664aef551714e91b7d83a28617b6e767db30d11
      
https://github.com/qemu/qemu/commit/c664aef551714e91b7d83a28617b6e767db30d11
  Author: Michael Roth <address@hidden>
  Date:   2013-05-23 (Thu, 23 May 2013)

  Changed paths:
    M scripts/qapi-visit.py

  Log Message:
  -----------
  qapi: qapi-visit.py, fix list handling for union types

Currently we assume non-list types when generating visitor routines for
union types. This is broken, since values like ['Type'] need to mapped
to 'TypeList'.

We already have a type_name() function to handle this that we use for
generating struct visitors, so use that here as well.

Signed-off-by: Michael Roth <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Reviewed-by: Amos Kong <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 7c946bc418db6b2a11f89b3465424fef48f714eb
      
https://github.com/qemu/qemu/commit/7c946bc418db6b2a11f89b3465424fef48f714eb
  Author: Michael Roth <address@hidden>
  Date:   2013-05-23 (Thu, 23 May 2013)

  Changed paths:
    M scripts/qapi-visit.py

  Log Message:
  -----------
  qapi: qapi-visit.py, native list support

Teach visitor generators about native types so they can generate the
appropriate visitor routines.

Signed-off-by: Michael Roth <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Reviewed-by: Amos Kong <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 0b400e792718f59275d5d54c21de9a589b35a81f
      
https://github.com/qemu/qemu/commit/0b400e792718f59275d5d54c21de9a589b35a81f
  Author: Michael Roth <address@hidden>
  Date:   2013-05-23 (Thu, 23 May 2013)

  Changed paths:
    M Makefile

  Log Message:
  -----------
  qapi: enable generation of native list code

Also, fix a dependency issue with libqemuutil: qemu-sockets.c needs
qapi-types.c/qapi-visit.c

Signed-off-by: Michael Roth <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Reviewed-by: Amos Kong <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 3d5b3ec6d460a92245215aaf7b349b0b9e5ffa25
      
https://github.com/qemu/qemu/commit/3d5b3ec6d460a92245215aaf7b349b0b9e5ffa25
  Author: Michael Roth <address@hidden>
  Date:   2013-05-23 (Thu, 23 May 2013)

  Changed paths:
    M qobject/json-parser.c

  Log Message:
  -----------
  json-parser: fix handling of large whole number values

Currently our JSON parser assumes that numbers lacking a fractional
value are integers and attempts to store them as QInt/int64 values. This
breaks in the case where the number overflows/underflows int64 values (which
is still valid JSON)

Fix this by detecting such cases and using a QFloat to store the value
instead.

Signed-off-by: Michael Roth <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Reviewed-by: Amos Kong <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: e92cfa0d90c618ff1f131c60ef1b27aa6fe69a0a
      
https://github.com/qemu/qemu/commit/e92cfa0d90c618ff1f131c60ef1b27aa6fe69a0a
  Author: Michael Roth <address@hidden>
  Date:   2013-05-23 (Thu, 23 May 2013)

  Changed paths:
    M tests/test-qmp-input-visitor.c

  Log Message:
  -----------
  qapi: add QMP input test for large integers

Large integers previously got capped to LLONG_MAX/LLONG_MIN so we could
store them as int64_t. This could lead to silent errors occuring.

Now, we use a double to handle these cases.

Add a test to confirm that QMPInputVisitor handles this as expected if
we're expected an integer value: errors for out of range integer values
that got promoted to doubles in this fashion.

Signed-off-by: Michael Roth <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Reviewed-by: Amos Kong <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 089f26bb735fb414b79f5fa3753910d5339d2a1d
      
https://github.com/qemu/qemu/commit/089f26bb735fb414b79f5fa3753910d5339d2a1d
  Author: Michael Roth <address@hidden>
  Date:   2013-05-23 (Thu, 23 May 2013)

  Changed paths:
    M tests/test-visitor-serialization.c

  Log Message:
  -----------
  qapi: fix visitor serialization tests for numbers/doubles

We never actually stored the stringified double values into the strings
before we did the comparisons. This left number/double values completely
uncovered in test-visitor-serialization tests.

Fixing this exposed a bug in our handling of large whole number values
in QEMU's JSON parser which is now fixed.

Simplify the code while we're at it by dropping the
calc_float_string_storage() craziness in favor of GStrings.

Signed-off-by: Michael Roth <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Reviewed-by: Amos Kong <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 8addacddfece619f1795fcf6cb9a3c49f800e7b9
      
https://github.com/qemu/qemu/commit/8addacddfece619f1795fcf6cb9a3c49f800e7b9
  Author: Michael Roth <address@hidden>
  Date:   2013-05-23 (Thu, 23 May 2013)

  Changed paths:
    M tests/test-visitor-serialization.c

  Log Message:
  -----------
  qapi: add native list coverage for visitor serialization tests

Signed-off-by: Michael Roth <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Reviewed-by: Amos Kong <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 83c84667f57637fe5a7a6fc9905d6a9e9589d3e5
      
https://github.com/qemu/qemu/commit/83c84667f57637fe5a7a6fc9905d6a9e9589d3e5
  Author: Michael Roth <address@hidden>
  Date:   2013-05-23 (Thu, 23 May 2013)

  Changed paths:
    M qapi-schema-test.json
    M tests/test-qmp-output-visitor.c

  Log Message:
  -----------
  qapi: add native list coverage for QMP output visitor tests

This exercises schema-generated visitors for native list types and does
some sanity checking on validity of serialized data.

Signed-off-by: Michael Roth <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Reviewed-by: Amos Kong <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 199e0f17f23a68c8d619e9e623d970324ed5efc1
      
https://github.com/qemu/qemu/commit/199e0f17f23a68c8d619e9e623d970324ed5efc1
  Author: Michael Roth <address@hidden>
  Date:   2013-05-23 (Thu, 23 May 2013)

  Changed paths:
    M tests/test-qmp-input-visitor.c

  Log Message:
  -----------
  qapi: add native list coverage for QMP input visitor tests

This exercises schema-generated visitors for native list types and does
some sanity checking on validity of deserialized data.

Signed-off-by: Michael Roth <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Reviewed-by: Amos Kong <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: b2d1674b75563326515cf2178cc1d0a002797a12
      
https://github.com/qemu/qemu/commit/b2d1674b75563326515cf2178cc1d0a002797a12
  Author: Amos Kong <address@hidden>
  Date:   2013-05-23 (Thu, 23 May 2013)

  Changed paths:
    M ui/input.c

  Log Message:
  -----------
  ui/input.c: replace magic numbers with macros

It's clearer to use defined macros than magic numbers.

Signed-off-by: Amos Kong <address@hidden>
Reviewed-by: Lei Li <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 70e098af88f79340d420992af526254866a42ddd
      
https://github.com/qemu/qemu/commit/70e098af88f79340d420992af526254866a42ddd
  Author: Luiz Capitulino <address@hidden>
  Date:   2013-05-23 (Thu, 23 May 2013)

  Changed paths:
    M qemu-options.hx
    M vl.c

  Log Message:
  -----------
  monitor: allow to disable the default monitor

Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 64afc2b4d48fb21e085517c38a59a3f61a11283c
      
https://github.com/qemu/qemu/commit/64afc2b4d48fb21e085517c38a59a3f61a11283c
  Author: Anthony Liguori <address@hidden>
  Date:   2013-05-23 (Thu, 23 May 2013)

  Changed paths:
    M Makefile
    M qapi-schema-test.json
    M qemu-options.hx
    M qobject/json-parser.c
    M scripts/qapi-types.py
    M scripts/qapi-visit.py
    M scripts/qapi.py
    M tests/test-qmp-input-visitor.c
    M tests/test-qmp-output-visitor.c
    M tests/test-visitor-serialization.c
    M ui/input.c
    M vl.c

  Log Message:
  -----------
  Merge remote-tracking branch 'luiz/queue/qmp' into staging

# By Michael Roth (10) and others
# Via Luiz Capitulino
* luiz/queue/qmp:
  monitor: allow to disable the default monitor
  ui/input.c: replace magic numbers with macros
  qapi: add native list coverage for QMP input visitor tests
  qapi: add native list coverage for QMP output visitor tests
  qapi: add native list coverage for visitor serialization tests
  qapi: fix visitor serialization tests for numbers/doubles
  qapi: add QMP input test for large integers
  json-parser: fix handling of large whole number values
  qapi: enable generation of native list code
  qapi: qapi-visit.py, native list support
  qapi: qapi-visit.py, fix list handling for union types
  qapi: qapi-types.py, native list support

Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


Compare: https://github.com/qemu/qemu/compare/95de21a430f7...64afc2b4d48f