qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 74bc90: qmp: fix handling of cmd with Equals


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 74bc90: qmp: fix handling of cmd with Equals in qmp-shell
Date: Wed, 15 May 2013 14:00:10 -0700

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 74bc9066bc2cf61dd12994ea3b73401d33112656
      
https://github.com/qemu/qemu/commit/74bc9066bc2cf61dd12994ea3b73401d33112656
  Author: Zhangleiqiang <address@hidden>
  Date:   2013-05-15 (Wed, 15 May 2013)

  Changed paths:
    M QMP/qmp-shell

  Log Message:
  -----------
  qmp: fix handling of cmd with Equals in qmp-shell

        qmp: fix handling of cmd with equal mark in qmp-shell

    qmp-shell splits the argument and value of input command
        by equal mark("="). But there are commands whose values
        include equal mark themselves, and the json built by
        qmp-shell will not correct. For example, when using NBD as
        the target of block-backup command, the input
        "block-backup target=nbd+unix:///drive0?socket=/tmp/nbd.sock"
        will fail, because the json built will be as follows:

    {
                "execute":"block-backup",
                "arguments":{"target":"nbd+unix:///drive0?socket"}
        }

    Fix it by joining the sections split by equal mark excluding the
        first section in __build_cmd function when the length of sections
        is larger than two.

Signed-off-by: zhangleiqiang <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: ad7f375df681503baa6ebef065818868e1216976
      
https://github.com/qemu/qemu/commit/ad7f375df681503baa6ebef065818868e1216976
  Author: Michael Roth <address@hidden>
  Date:   2013-05-15 (Wed, 15 May 2013)

  Changed paths:
    M tests/test-visitor-serialization.c

  Log Message:
  -----------
  qapi: fix leak in unit tests

qmp_output_get_qobject() increments the qobject's reference count. Since
we currently pass this straight into qobject_to_json() so we can feed
the data into a QMP input visitor, we never actually free the underlying
qobject when qmp_output_visitor_cleanup() is called. This causes leaks
on all of the QMP serialization tests.

Fix this by holding a pointer to the qobject and decref'ing it before
returning from qmp_deserialize().

Signed-off-by: Michael Roth <address@hidden>
Signed-off-by: Luiz Capitulino <address@hidden>


  Commit: 262f27b93f459ec1dee4100015c109f5e1242091
      
https://github.com/qemu/qemu/commit/262f27b93f459ec1dee4100015c109f5e1242091
  Author: Kevin Wolf <address@hidden>
  Date:   2013-05-15 (Wed, 15 May 2013)

  Changed paths:
    M tests/ide-test.c

  Log Message:
  -----------
  ide-test: Fix endianness problems

The test case passes on big endian hosts now (tested on ppc64)

Signed-off-by: Kevin Wolf <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 8593e050871c632e245190725b11f1e10c629ff2
      
https://github.com/qemu/qemu/commit/8593e050871c632e245190725b11f1e10c629ff2
  Author: Paolo Bonzini <address@hidden>
  Date:   2013-05-15 (Wed, 15 May 2013)

  Changed paths:
    M include/qemu-common.h

  Log Message:
  -----------
  qemu-common: Resolve vector build breakes for AltiVec

On Mac OS X ppc, altivec.h defines "vector", leading to build breakage
when used as variable name, e.g. in tracing code.
Fix this by undefining identifiers after altivec.h inclusion.

Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 6b41659f4eaf1daefd232a7eea6d96885eb52ee7
      
https://github.com/qemu/qemu/commit/6b41659f4eaf1daefd232a7eea6d96885eb52ee7
  Author: Anthony Liguori <address@hidden>
  Date:   2013-05-15 (Wed, 15 May 2013)

  Changed paths:
    M QMP/qmp-shell
    M tests/test-visitor-serialization.c

  Log Message:
  -----------
  Merge remote-tracking branch 'luiz/queue/qmp' into staging

# By Michael Roth (1) and Zhangleiqiang (1)
# Via Luiz Capitulino
* luiz/queue/qmp:
  qapi: fix leak in unit tests
  qmp: fix handling of cmd with Equals in qmp-shell

Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


Compare: https://github.com/qemu/qemu/compare/913b4b6bf39c...6b41659f4eaf

reply via email to

[Prev in Thread] Current Thread [Next in Thread]