[Qemu-commits] [qemu/qemu] 7dda5d: migration: initialize RAM to zero

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 7dda5dc82a776a39a7996020c188eb2a29187117
      
https://github.com/qemu/qemu/commit/7dda5dc82a776a39a7996020c188eb2a29187117
  Author: Paolo Bonzini <address@hidden>
  Date:   2013-04-16 (Tue, 16 Apr 2013)

  Changed paths:
    M util/oslib-posix.c

  Log Message:
  -----------
  migration: initialize RAM to zero

Using qemu_memalign only leaves the RAM zero by chance, because libc
will usually use mmap to satisfy our huge requests.  But memory will
not be zero when using MALLOC_PERTURB_ with a nonzero value.  In the
case of incoming migration, this breaks a recently-introduced
invariant (commit f1c7279, migration: do not sent zero pages in
bulk stage, 2013-03-26).

To fix this, use mmap ourselves to get a well-aligned, always zero
block for the RAM.  Mmap-ed memory is easy to "trim" at the sides.

This also removes the need to do something special on valgrind
(see commit c2a8238a, Support running QEMU on Valgrind, 2011-10-31),
thus effectively reverts that patch.

Reviewed-by: Juan Quintela <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Markus Armbruster <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: acbbc036619092fcd2c882222e1be168bd972b3e
      
https://github.com/qemu/qemu/commit/acbbc036619092fcd2c882222e1be168bd972b3e
  Author: Amit Shah <address@hidden>
  Date:   2013-04-16 (Tue, 16 Apr 2013)

  Changed paths:
    M backends/rng-random.c

  Log Message:
  -----------
  rng random backend: check for -EAGAIN errors on read

Not handling EAGAIN triggers the assert

qemu/backends/rng-random.c:44:entropy_available: assertion failed: (len != -1)
Aborted (core dumped)

This happens when starting a guest with '-device virtio-rng-pci',
issuing a 'cat /dev/hwrng' in the guest, while also doing 'cat
/dev/random' on the host.

Reported-by: yunpingzheng <address@hidden>
Signed-off-by: Amit Shah <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 2f7bd829dbaf39eb14706c3e889f28b795e050ca
      
https://github.com/qemu/qemu/commit/2f7bd829dbaf39eb14706c3e889f28b795e050ca
  Author: Andreas Färber <address@hidden>
  Date:   2013-04-16 (Tue, 16 Apr 2013)

  Changed paths:
    M qdev-monitor.c

  Log Message:
  -----------
  qdev: Fix device_add bus assumptions

Drop an unreachable fallback bus assignment to SysBus.

If no ,bus= is specified, only search busses recursively for bus type if
the DeviceClass has a bus_type specified. Handle resulting NULL cases.

Signed-off-by: Andreas Färber <address@hidden>
Signed-off-by: Andreas Färber <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: e0a83fc2c1582dc8d4453849852ebe6c258b7c3a
      
https://github.com/qemu/qemu/commit/e0a83fc2c1582dc8d4453849852ebe6c258b7c3a
  Author: Paolo Bonzini <address@hidden>
  Date:   2013-04-16 (Tue, 16 Apr 2013)

  Changed paths:
    M qom/object.c

  Log Message:
  -----------
  qom: do nothing on unparent of object without parent

Otherwise, device_unparent will fail to get a canonical path of
the object.

Signed-off-by: Paolo Bonzini <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


Compare: https://github.com/qemu/qemu/compare/86c7dba0d0ed...e0a83fc2c158