[Qemu-commits] [qemu/qemu] 44c473: qemu-char: Add qemu_chr_fe_claim / _release helper...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 44c473decd4de5559487430f876de53c607b1e9d
      
https://github.com/qemu/qemu/commit/44c473decd4de5559487430f876de53c607b1e9d
  Author: Hans de Goede <address@hidden>
  Date:   2013-04-04 (Thu, 04 Apr 2013)

  Changed paths:
    M hw/qdev-properties-system.c
    M include/char/char.h
    M qemu-char.c

  Log Message:
  -----------
  qemu-char: Add qemu_chr_fe_claim / _release helper functions

Add qemu_chr_fe_claim / _release helper functions for properly dealing with
avail_connections.

Signed-off-by: Hans de Goede <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 456d60692310e7ac25cf822cc1e98192ad636ece
      
https://github.com/qemu/qemu/commit/456d60692310e7ac25cf822cc1e98192ad636ece
  Author: Hans de Goede <address@hidden>
  Date:   2013-04-04 (Thu, 04 Apr 2013)

  Changed paths:
    M backends/rng-egd.c
    M gdbstub.c
    M hw/arm/pxa2xx.c
    M hw/bt-hci-csr.c
    M hw/ipoctal232.c
    M hw/ivshmem.c
    M hw/mcf_uart.c
    M hw/sh_serial.c
    M hw/xen_console.c
    M net/slirp.c
    M qemu-char.c
    M vl.c

  Log Message:
  -----------
  qemu-char: Call fe_claim / fe_release when not using qdev chr properties

chardev-frontends need to explictly check, increase and decrement the
avail_connections "property" of the chardev when they are not using a
qdev-chardev-property for the chardev.

This fixes things like:
qemu-kvm -chardev stdio,id=foo -device isa-serial,chardev=foo \
  -mon chardev=foo

Working, where they should fail. Most of the changes here are due to
old hardware emulation code which is using serial_hds directly rather then
a qdev-chardev-property.

Signed-off-by: Hans de Goede <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: b9936159ff601562a7bb16b5b9c7713e6cec9559
      
https://github.com/qemu/qemu/commit/b9936159ff601562a7bb16b5b9c7713e6cec9559
  Author: Hans de Goede <address@hidden>
  Date:   2013-04-04 (Thu, 04 Apr 2013)

  Changed paths:
    M hw/ipoctal232.c

  Log Message:
  -----------
  ipoctal232: Convert to use chardev properties directly

Signed-off-by: Hans de Goede <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>
Signed-off-by: Alberto Garcia <address@hidden>
Message-id: address@hidden
Cc: Alberto Garcia <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 4d8b3c6302fe50e9192854d8affda883e078fd4d
      
https://github.com/qemu/qemu/commit/4d8b3c6302fe50e9192854d8affda883e078fd4d
  Author: Laszlo Ersek <address@hidden>
  Date:   2013-04-04 (Thu, 04 Apr 2013)

  Changed paths:
    M arch_init.c
    M target-i386/cpu.h
    M vl.c

  Log Message:
  -----------
  strip some whitespace

Signed-off-by: Laszlo Ersek <address@hidden>
Reviewed-by: Anthony Liguori <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: cb88a4ea79193cdbfb9b27bf9deb36c88ec9b6dc
      
https://github.com/qemu/qemu/commit/cb88a4ea79193cdbfb9b27bf9deb36c88ec9b6dc
  Author: Laszlo Ersek <address@hidden>
  Date:   2013-04-04 (Thu, 04 Apr 2013)

  Changed paths:
    M hw/acpi.c
    M hw/pc.h

  Log Message:
  -----------
  change element type from "char" to "unsigned char" in ACPI table data

The data is binary, not textual.

Also, acpi_table_add() abuses the "char *f" pointer -- which normally
points to file names to load -- to poke into the table. Introduce "char
unsigned *table_start" for that purpose.

Signed-off-by: Laszlo Ersek <address@hidden>
Reviewed-by: Anthony Liguori <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 445d9cae371960671c1d762330d0d498c352dd3c
      
https://github.com/qemu/qemu/commit/445d9cae371960671c1d762330d0d498c352dd3c
  Author: Laszlo Ersek <address@hidden>
  Date:   2013-04-04 (Thu, 04 Apr 2013)

  Changed paths:
    M hw/acpi.c

  Log Message:
  -----------
  acpi_table_add(): report fatal errors through an internal Error object

The upcoming changes will need a cleanup section at the end of the
function, plus OptsVisitor reports errors via Error. For now keep
channeling any Errors to stderr.

Signed-off-by: Laszlo Ersek <address@hidden>
Reviewed-by: Anthony Liguori <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 8ccbad5c7b61c46c1b69b8089b8965cd69c0a8de
      
https://github.com/qemu/qemu/commit/8ccbad5c7b61c46c1b69b8089b8965cd69c0a8de
  Author: Laszlo Ersek <address@hidden>
  Date:   2013-04-04 (Thu, 04 Apr 2013)

  Changed paths:
    M qapi-schema.json

  Log Message:
  -----------
  qapi schema: add AcpiTableOptions

Signed-off-by: Laszlo Ersek <address@hidden>
Reviewed-by: Anthony Liguori <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 0c764a9dfc0d480c21f325480aa2e69581841858
      
https://github.com/qemu/qemu/commit/0c764a9dfc0d480c21f325480aa2e69581841858
  Author: Laszlo Ersek <address@hidden>
  Date:   2013-04-04 (Thu, 04 Apr 2013)

  Changed paths:
    M arch_init.c
    M hw/acpi.c
    M hw/i386/pc.c
    M hw/pc.h
    M include/sysemu/arch_init.h
    M vl.c

  Log Message:
  -----------
  acpi_table_add(): accept QemuOpts and parse it with OptsVisitor

As one consequence, strtok() -- which modifies its argument -- is replaced
with g_strsplit().

Signed-off-by: Laszlo Ersek <address@hidden>
Reviewed-by: Anthony Liguori <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: e980f2bf0a39cb524259bb70084e0f75b92c8f39
      
https://github.com/qemu/qemu/commit/e980f2bf0a39cb524259bb70084e0f75b92c8f39
  Author: Laszlo Ersek <address@hidden>
  Date:   2013-04-04 (Thu, 04 Apr 2013)

  Changed paths:
    M hw/acpi.c

  Log Message:
  -----------
  acpi_table_add(): extract and reimplement internals

The new function acpi_table_install() installs any blob the caller passes
in. In the next patches this function will be promoted from helper role to
extern.

Reimplementing the logic should make it easier to understand. It also
removes a buffer overflow when

    has_header &&
    cumulative_file_size < ACPI_TABLE_HDR_SIZE - ACPI_TABLE_PFX_SIZE

(In that case the g_realloc() call in the read() loop used to shrink the
"acpi_tables" array, causing an out-of-bounds read access when copying the
header out of "acpi_tables".)

The new code isn't more daring alignment-wise than its predecessor:
"acpi_table_header" is packed, and the uint32_t fields are at offsets 6,
26, and 34.

Signed-off-by: Laszlo Ersek <address@hidden>
Reviewed-by: Anthony Liguori <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 23084327dc5c2f42e8a1c3e39ec565e344c7f52e
      
https://github.com/qemu/qemu/commit/23084327dc5c2f42e8a1c3e39ec565e344c7f52e
  Author: Laszlo Ersek <address@hidden>
  Date:   2013-04-04 (Thu, 04 Apr 2013)

  Changed paths:
    M arch_init.c
    M hw/acpi.c
    M hw/i386/pc.c
    M hw/pc.h

  Log Message:
  -----------
  like acpi_table_install(), acpi_table_add() should propagate Errors

Signed-off-by: Laszlo Ersek <address@hidden>
Reviewed-by: Anthony Liguori <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: dab8623430926a8c55a149c22b2b8e2edb786ae3
      
https://github.com/qemu/qemu/commit/dab8623430926a8c55a149c22b2b8e2edb786ae3
  Author: Laszlo Ersek <address@hidden>
  Date:   2013-04-04 (Thu, 04 Apr 2013)

  Changed paths:
    M hw/apic_common.c
    M hw/i386/kvmvapic.c
    M target-i386/cpu.c
    M target-i386/cpu.h

  Log Message:
  -----------
  extract/unify the constant 0xfee00000 as APIC_DEFAULT_ADDRESS

A common dependency of the constant's current users:
- hw/apic_common.c
- hw/i386/kvmvapic.c
- target-i386/cpu.c
is "target-i386/cpu.h".

Signed-off-by: Laszlo Ersek <address@hidden>
Reviewed-by: Anthony Liguori <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 3a4a4697aacdd58b77f8bca6f2c0ce307b213506
      
https://github.com/qemu/qemu/commit/3a4a4697aacdd58b77f8bca6f2c0ce307b213506
  Author: Laszlo Ersek <address@hidden>
  Date:   2013-04-04 (Thu, 04 Apr 2013)

  Changed paths:
    M hw/i386/pc.c

  Log Message:
  -----------
  Introduce IO_APIC_DEFAULT_ADDRESS for 0xfec00000

Signed-off-by: Laszlo Ersek <address@hidden>
Reviewed-by: Anthony Liguori <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: c5a98cf333997616147a161ef4e4cf71bb9bd00a
      
https://github.com/qemu/qemu/commit/c5a98cf333997616147a161ef4e4cf71bb9bd00a
  Author: Laszlo Ersek <address@hidden>
  Date:   2013-04-04 (Thu, 04 Apr 2013)

  Changed paths:
    M hw/i386/pc.c

  Log Message:
  -----------
  pc_acpi_init(): don't bail as soon as failing to find default DSDT

Signed-off-by: Laszlo Ersek <address@hidden>
Reviewed-by: Anthony Liguori <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: d05ef160453e98546a4197496dc8a3cb2defac53
      
https://github.com/qemu/qemu/commit/d05ef160453e98546a4197496dc8a3cb2defac53
  Author: Brad Smith <address@hidden>
  Date:   2013-04-04 (Thu, 04 Apr 2013)

  Changed paths:
    M include/qemu/timer.h
    M util/qemu-timer-common.c

  Log Message:
  -----------
  Allow clock_gettime() monotonic clock to be utilized on more OS's

Allow the clock_gettime() code using monotonic clock to be utilized on
more POSIX compliannt OS's. This started as a fix for OpenBSD which was
listed in one function as part of the previous hard coded list of OS's
for the functions to support but not in the other.

Signed-off-by: Brad Smith <address@hidden>
Reviewed-by: Paolo Bonzini <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


Compare: https://github.com/qemu/qemu/compare/4dbb9ed3263e...d05ef160453e