qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] baca6f: char-socket: fix error reporting


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] baca6f: char-socket: fix error reporting
Date: Fri, 08 Mar 2013 13:00:25 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: baca6f183d78a0c864a5ccc0ec64e26ba960e604
      
https://github.com/qemu/qemu/commit/baca6f183d78a0c864a5ccc0ec64e26ba960e604
  Author: Anthony Liguori <address@hidden>
  Date:   2013-03-08 (Fri, 08 Mar 2013)

  Changed paths:
    M util/qemu-sockets.c

  Log Message:
  -----------
  char-socket: fix error reporting

Right now the inet connect code tries all available addresses but until one
doesn't fail.  It passes local_err each time without clearing it from the
previous failure.  This can trigger an assert since the inet connect code
tries to set an error on an object != NULL.

Signed-off-by: Anthony Liguori <address@hidden>
Signed-off-by: Amit Shah <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: ed7a154063266a30a31752d3b18d484ddc7f5aa9
      
https://github.com/qemu/qemu/commit/ed7a154063266a30a31752d3b18d484ddc7f5aa9
  Author: Anthony Liguori <address@hidden>
  Date:   2013-03-08 (Fri, 08 Mar 2013)

  Changed paths:
    M qemu-char.c

  Log Message:
  -----------
  qemu-char: remove dead/confusing logic with nb_stdio_clients

This code is very old dating back to 2007.  What is puzzling is that
STDIO_MAX_CLIENTS was always #define to 1 meaning that all of the code to deal
with more than one client was unreachable.

Just remove the whole mess of it.

Signed-off-by: Anthony Liguori <address@hidden>
Signed-off-by: Amit Shah <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 96c6384776d631839a9c8fe02bf135f9ba22586c
      
https://github.com/qemu/qemu/commit/96c6384776d631839a9c8fe02bf135f9ba22586c
  Author: Anthony Liguori <address@hidden>
  Date:   2013-03-08 (Fri, 08 Mar 2013)

  Changed paths:
    M qemu-char.c

  Log Message:
  -----------
  char: add IOWatchPoll support

This is a special GSource that supports CharDriverState style
poll callbacks.

For reviewability and bisectability, this code is #if 0'd out in this
patch to avoid unused warnings since all of the functions are static.

Signed-off-by: Anthony Liguori <address@hidden>
Signed-off-by: Amit Shah <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: a29753f8aa79a34a324afebe340182a51a5aef11
      
https://github.com/qemu/qemu/commit/a29753f8aa79a34a324afebe340182a51a5aef11
  Author: Anthony Liguori <address@hidden>
  Date:   2013-03-08 (Fri, 08 Mar 2013)

  Changed paths:
    M qemu-char.c

  Log Message:
  -----------
  qemu-char: convert fd_chr to use a GIOChannel

This uses the newly introduced IOWatchPoll source.

Signed-off-by: Anthony Liguori <address@hidden>
Signed-off-by: Amit Shah <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 093d3a20055282e282ba056addbe59b79e13a32f
      
https://github.com/qemu/qemu/commit/093d3a20055282e282ba056addbe59b79e13a32f
  Author: Anthony Liguori <address@hidden>
  Date:   2013-03-08 (Fri, 08 Mar 2013)

  Changed paths:
    M qemu-char.c

  Log Message:
  -----------
  qemu-char: convert pty to GIOChannel

Signed-off-by: Anthony Liguori <address@hidden>
Signed-off-by: Amit Shah <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 76a9644b711541472d9fb3a9b418acd55d9464a1
      
https://github.com/qemu/qemu/commit/76a9644b711541472d9fb3a9b418acd55d9464a1
  Author: Anthony Liguori <address@hidden>
  Date:   2013-03-08 (Fri, 08 Mar 2013)

  Changed paths:
    M qemu-char.c

  Log Message:
  -----------
  qemu-char: convert UDP to GIOChannel

Signed-off-by: Anthony Liguori <address@hidden>
Signed-off-by: Amit Shah <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 2ea5a7af7bfa576a5936400ccca4144caca9640b
      
https://github.com/qemu/qemu/commit/2ea5a7af7bfa576a5936400ccca4144caca9640b
  Author: Anthony Liguori <address@hidden>
  Date:   2013-03-08 (Fri, 08 Mar 2013)

  Changed paths:
    M qemu-char.c

  Log Message:
  -----------
  qemu-char: tcp: make use GIOChannel

I didn't bother switching to g_io_channel_read/write because we need to use
sendmsg on Unix.  No problem though since we're using an unbuffered channel.

Signed-off-by: Anthony Liguori <address@hidden>
Signed-off-by: Amit Shah <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 23673ca740e0eda66901ca801a5a901df378b063
      
https://github.com/qemu/qemu/commit/23673ca740e0eda66901ca801a5a901df378b063
  Author: Anthony Liguori <address@hidden>
  Date:   2013-03-08 (Fri, 08 Mar 2013)

  Changed paths:
    M include/char/char.h
    M qemu-char.c

  Log Message:
  -----------
  qemu-char: add watch support

This allows a front-end to request for a callback when the backend
is writable again.

Signed-off-by: Anthony Liguori <address@hidden>
Signed-off-by: Amit Shah <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: e6a87ed837b52aea903c25693b1e3703824b9ef7
      
https://github.com/qemu/qemu/commit/e6a87ed837b52aea903c25693b1e3703824b9ef7
  Author: Anthony Liguori <address@hidden>
  Date:   2013-03-08 (Fri, 08 Mar 2013)

  Changed paths:
    M qemu-char.c

  Log Message:
  -----------
  qemu-char: add pty watch

This lets ptys support adding front end watchs.

Signed-off-by: Anthony Liguori <address@hidden>
Signed-off-by: Amit Shah <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: d3cc5bc416cdf25bae0f3f6de58830be8ac5b648
      
https://github.com/qemu/qemu/commit/d3cc5bc416cdf25bae0f3f6de58830be8ac5b648
  Author: Amit Shah <address@hidden>
  Date:   2013-03-08 (Fri, 08 Mar 2013)

  Changed paths:
    M qemu-char.c

  Log Message:
  -----------
  char: add gio watch fn for tcp backends

Signed-off-by: Amit Shah <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 8aa33cafc41a0fe8549d1dbcc65b75c31112dea8
      
https://github.com/qemu/qemu/commit/8aa33cafc41a0fe8549d1dbcc65b75c31112dea8
  Author: Anthony Liguori <address@hidden>
  Date:   2013-03-08 (Fri, 08 Mar 2013)

  Changed paths:
    M qemu-char.c

  Log Message:
  -----------
  qemu-char: use a glib timeout instead of qemu-timer

Signed-off-by: Anthony Liguori <address@hidden>
Signed-off-by: Amit Shah <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 9f939df955a4152aad69a19a77e0898631bb2c18
      
https://github.com/qemu/qemu/commit/9f939df955a4152aad69a19a77e0898631bb2c18
  Author: Anthony Liguori <address@hidden>
  Date:   2013-03-08 (Fri, 08 Mar 2013)

  Changed paths:
    M include/char/char.h
    M qemu-char.c

  Log Message:
  -----------
  qemu-char: remove use of QEMUTimer in favor of glib idle function

qemu-char is now independent of the QEMU main loop.

Signed-off-by: Anthony Liguori <address@hidden>
Signed-off-by: Amit Shah <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: d654f34ec8bf006f9b57a067e0f272ab94ee8e06
      
https://github.com/qemu/qemu/commit/d654f34ec8bf006f9b57a067e0f272ab94ee8e06
  Author: Anthony Liguori <address@hidden>
  Date:   2013-03-08 (Fri, 08 Mar 2013)

  Changed paths:
    M include/char/char.h
    M qemu-char.c

  Log Message:
  -----------
  qemu-char: make char drivers dynamically registerable

Signed-off-by: Anthony Liguori <address@hidden>
Signed-off-by: Amit Shah <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 26c60614524f41bc9016cbe27eaefe59473d3461
      
https://github.com/qemu/qemu/commit/26c60614524f41bc9016cbe27eaefe59473d3461
  Author: Anthony Liguori <address@hidden>
  Date:   2013-03-08 (Fri, 08 Mar 2013)

  Changed paths:
    M qemu-char.c
    M spice-qemu-char.c

  Log Message:
  -----------
  qemu-char: move spice registration to spice-qemu-char.c

Signed-off-by: Anthony Liguori <address@hidden>
Signed-off-by: Amit Shah <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 08744c98115cfa144ed3493556024e400b2e2573
      
https://github.com/qemu/qemu/commit/08744c98115cfa144ed3493556024e400b2e2573
  Author: Anthony Liguori <address@hidden>
  Date:   2013-03-08 (Fri, 08 Mar 2013)

  Changed paths:
    M hw/baum.c
    R hw/baum.h
    M qemu-char.c
    M vl.c

  Log Message:
  -----------
  qemu-char: move baum registration to baum.c

Signed-off-by: Anthony Liguori <address@hidden>
Signed-off-by: Amit Shah <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 5ab8211b9e1215ed136164c6d9622f2c928f7a8d
      
https://github.com/qemu/qemu/commit/5ab8211b9e1215ed136164c6d9622f2c928f7a8d
  Author: Anthony Liguori <address@hidden>
  Date:   2013-03-08 (Fri, 08 Mar 2013)

  Changed paths:
    M hw/msmouse.c
    R hw/msmouse.h
    M qemu-char.c

  Log Message:
  -----------
  qemu-char: move msmouse registeration to msmouse.c

Signed-off-by: Anthony Liguori <address@hidden>
Signed-off-by: Amit Shah <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 01f45d986fb0b7c2d4f0466efe3cde9708f325be
      
https://github.com/qemu/qemu/commit/01f45d986fb0b7c2d4f0466efe3cde9708f325be
  Author: Anthony Liguori <address@hidden>
  Date:   2013-03-08 (Fri, 08 Mar 2013)

  Changed paths:
    M qemu-char.c
    M ui/console.c

  Log Message:
  -----------
  qemu-char: move text console init to console.c

Signed-off-by: Anthony Liguori <address@hidden>
Signed-off-by: Amit Shah <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: fcfb4d6aae611d1f804d486d3c998000912c4c81
      
https://github.com/qemu/qemu/commit/fcfb4d6aae611d1f804d486d3c998000912c4c81
  Author: Anthony Liguori <address@hidden>
  Date:   2013-03-08 (Fri, 08 Mar 2013)

  Changed paths:
    M hw/serial.c
    M hw/serial.h

  Log Message:
  -----------
  serial: add flow control to transmit

Signed-off-by: Anthony Liguori <address@hidden>
Signed-off-by: Amit Shah <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 7df4d4578f70b565870f353ba0b72f2f23781a09
      
https://github.com/qemu/qemu/commit/7df4d4578f70b565870f353ba0b72f2f23781a09
  Author: Amit Shah <address@hidden>
  Date:   2013-03-08 (Fri, 08 Mar 2013)

  Changed paths:
    M hw/virtio-console.c

  Log Message:
  -----------
  virtio: console: add flow control

The virtio-serial-bus already has the logic to make flow control work
properly.  Hook into the char layer's new ability to signal a backend is
writable again.

Signed-off-by: Amit Shah <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: d6258c93a7133bb2bf2ab4e91476bc0b631ba7f1
      
https://github.com/qemu/qemu/commit/d6258c93a7133bb2bf2ab4e91476bc0b631ba7f1
  Author: Amit Shah <address@hidden>
  Date:   2013-03-08 (Fri, 08 Mar 2013)

  Changed paths:
    M hw/virtio-console.c
    M hw/virtio-serial-bus.c

  Log Message:
  -----------
  virtio-serial: make flow control explicit in virtio-console

virtio-console.c used to return a value less than the number of bytes
asked to be written out to a chardev backend in case the backend is not
writable.  virtio-serial-bus.c then implicitly enabled flow control for
that port.

Make this explicit instead.

Signed-off-by: Amit Shah <address@hidden>
Message-id: address@hidden
Signed-off-by: Anthony Liguori <address@hidden>


Compare: https://github.com/qemu/qemu/compare/0bc472a9d6b8...d6258c93a713

reply via email to

[Prev in Thread] Current Thread [Next in Thread]