[Qemu-commits] [qemu/qemu] 26135e: target-mips: Fix accumulator selection for MIPS16 ...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 26135ead80fa1fd13e95c162dacfd06f2ba82981
      
https://github.com/qemu/qemu/commit/26135ead80fa1fd13e95c162dacfd06f2ba82981
  Author: Richard Sandiford <address@hidden>
  Date:   2013-03-04 (Mon, 04 Mar 2013)

  Changed paths:
    M target-mips/translate.c

  Log Message:
  -----------
  target-mips: Fix accumulator selection for MIPS16 and microMIPS

Add accumulator arguments to gen_HILO and gen_muldiv, rather than
extracting the accumulator directly from ctx->opcode.  The extraction
was only right for the standard encoding: MIPS16 doesn't have access
to the DSP registers, while microMIPS encodes the accumulator register
in a different field (bits 14 and 15).

Passing the accumulator register is probably an over-generalisation
for division and 64-bit multiplication, which never access anything
other than HI and LO, and which always pass 0 as the new argument.
Separating them felt a bit fussy though.

Signed-off-by: Richard Sandiford <address@hidden>
Signed-off-by: Aurelien Jarno <address@hidden>