qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] baec19: ppc: Move Mac machines to hw/ppc/


From: GitHub
Subject: [Qemu-commits] [qemu/qemu] baec19: ppc: Move Mac machines to hw/ppc/
Date: Sat, 26 Jan 2013 07:30:12 -0800

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: baec19105bb9824593bf6f37556302da2f67e583
      
https://github.com/qemu/qemu/commit/baec19105bb9824593bf6f37556302da2f67e583
  Author: Andreas Färber <address@hidden>
  Date:   2013-01-25 (Fri, 25 Jan 2013)

  Changed paths:
    M MAINTAINERS
    M hw/cuda.c
    M hw/grackle_pci.c
    M hw/heathrow_pic.c
    M hw/ide/macio.c
    M hw/mac_nvram.c
    M hw/macio.c
    M hw/openpic.c
    M hw/ppc/Makefile.objs
    A hw/ppc/mac.h
    A hw/ppc/mac_newworld.c
    A hw/ppc/mac_oldworld.c
    R hw/ppc_mac.h
    R hw/ppc_newworld.c
    R hw/ppc_oldworld.c
    M hw/unin_pci.c

  Log Message:
  -----------
  ppc: Move Mac machines to hw/ppc/

Signed-off-by: Andreas Färber <address@hidden>
[agraf: squash in MAINTAINERS fix]
Signed-off-by: Alexander Graf <address@hidden>


  Commit: fcf1bbabf4de3bc125c4dff18ea1cb76d76f042a
      
https://github.com/qemu/qemu/commit/fcf1bbabf4de3bc125c4dff18ea1cb76d76f042a
  Author: Andreas Färber <address@hidden>
  Date:   2013-01-25 (Fri, 25 Jan 2013)

  Changed paths:
    M hw/macio.c

  Log Message:
  -----------
  macio: QOM'ify some more

Move bar MemoryRegion initialization to an instance_init.

Signed-off-by: Andreas Färber <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: 7b925079e36cf26ca2e1f8db84b771ddc3d6340c
      
https://github.com/qemu/qemu/commit/7b925079e36cf26ca2e1f8db84b771ddc3d6340c
  Author: Andreas Färber <address@hidden>
  Date:   2013-01-25 (Fri, 25 Jan 2013)

  Changed paths:
    M hw/macio.c

  Log Message:
  -----------
  macio: Delay qdev init until all fields are initialized

This turns macio_bar_setup() into an implementation detail of the qdev
initfn, to be removed step by step.

Signed-off-by: Andreas Färber <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: d037834a9d3847499e8a146bd1893a5c856411be
      
https://github.com/qemu/qemu/commit/d037834a9d3847499e8a146bd1893a5c856411be
  Author: Andreas Färber <address@hidden>
  Date:   2013-01-25 (Fri, 25 Jan 2013)

  Changed paths:
    M hw/macio.c
    M hw/ppc/mac.h
    M hw/ppc/mac_newworld.c
    M hw/ppc/mac_oldworld.c

  Log Message:
  -----------
  macio: Split MacIO in two

Let the machines create two different types. This prepares to move
knowledge about sub-devices from the machines into the devices.

Signed-off-by: Andreas Färber <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: 3743cca7d55c700e727e958d4a0b0b5d6c15e2e8
      
https://github.com/qemu/qemu/commit/3743cca7d55c700e727e958d4a0b0b5d6c15e2e8
  Author: Andreas Färber <address@hidden>
  Date:   2013-01-25 (Fri, 25 Jan 2013)

  Changed paths:
    M hw/mac_nvram.c
    M hw/ppc/mac.h

  Log Message:
  -----------
  mac_nvram: Clean up public API

The state data field is accessed in uint8_t quantities, so switch from
uint32_t argument and return value to uint8_t.

Fix debug format specifiers while at it.

Signed-off-by: Andreas Färber <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: d8c6d07fdff2523ca78f95c7d8a7fe90ee7ea5a7
      
https://github.com/qemu/qemu/commit/d8c6d07fdff2523ca78f95c7d8a7fe90ee7ea5a7
  Author: Andreas Färber <address@hidden>
  Date:   2013-01-25 (Fri, 25 Jan 2013)

  Changed paths:
    M hw/mac_nvram.c

  Log Message:
  -----------
  mac_nvram: Mark as Big Endian

Signed-off-by: Andreas Färber <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: 95ed3b7cf1677dc9f995a6e1fcc7bf377cf94a0e
      
https://github.com/qemu/qemu/commit/95ed3b7cf1677dc9f995a6e1fcc7bf377cf94a0e
  Author: Andreas Färber <address@hidden>
  Date:   2013-01-25 (Fri, 25 Jan 2013)

  Changed paths:
    M hw/mac_nvram.c
    M hw/macio.c
    M hw/ppc/mac.h
    M hw/ppc/mac_newworld.c
    M hw/ppc/mac_oldworld.c

  Log Message:
  -----------
  mac_nvram: QOM'ify MacIO NVRAM

It was not qdev'ified before. Turn it into a SysBusDevice and
initialize it via static properties.

Prepare Old World specific MacIO state and embed the NVRAM state there.

Drop macio_nvram_setup_bar() in favor of sysbus_mmio_map() or
direct use of Memory API.

Signed-off-by: Andreas Färber <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: 07a7484e5d713f1eb7c1c37b18a8ab0d56d88875
      
https://github.com/qemu/qemu/commit/07a7484e5d713f1eb7c1c37b18a8ab0d56d88875
  Author: Andreas Färber <address@hidden>
  Date:   2013-01-25 (Fri, 25 Jan 2013)

  Changed paths:
    M hw/ide.h
    M hw/ide/macio.c
    M hw/macio.c
    M hw/ppc/mac.h
    M hw/ppc/mac_newworld.c
    M hw/ppc/mac_oldworld.c

  Log Message:
  -----------
  ide/macio: QOM'ify MacIO IDE

It was not qdev'ified before. Turn it into a SysBusDevice.
Embed them into the MacIO devices.

Signed-off-by: Andreas Färber <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: 45fa67fb68e73b395cd93ec97e45785944d4ee6a
      
https://github.com/qemu/qemu/commit/45fa67fb68e73b395cd93ec97e45785944d4ee6a
  Author: Andreas Färber <address@hidden>
  Date:   2013-01-25 (Fri, 25 Jan 2013)

  Changed paths:
    M hw/cuda.c
    M hw/macio.c
    M hw/ppc/mac.h
    M hw/ppc/mac_newworld.c
    M hw/ppc/mac_oldworld.c

  Log Message:
  -----------
  cuda: QOM'ify CUDA

It was not qdev'ified before. Turn it into a SysBusDevice and embed it
in MacIO.

Signed-off-by: Andreas Färber <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: 84ede329083b649c54f078276e7e06d48e910b9d
      
https://github.com/qemu/qemu/commit/84ede329083b649c54f078276e7e06d48e910b9d
  Author: Andreas Färber <address@hidden>
  Date:   2013-01-25 (Fri, 25 Jan 2013)

  Changed paths:
    M hw/adb.c
    M hw/adb.h
    M hw/cuda.c

  Log Message:
  -----------
  adb: QOM'ify Apple Desktop Bus

It was not a qbus before, turn it into a first-class bus and initialize
it properly from CUDA. Leave it a global variable as long as devices are
not QOM'ified yet.

Signed-off-by: Andreas Färber <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: 2e4a7c9c5df442d4223e738f7e8f73192b8b2a65
      
https://github.com/qemu/qemu/commit/2e4a7c9c5df442d4223e738f7e8f73192b8b2a65
  Author: Andreas Färber <address@hidden>
  Date:   2013-01-25 (Fri, 25 Jan 2013)

  Changed paths:
    M hw/adb.c
    M hw/adb.h
    M hw/ppc/mac_newworld.c
    M hw/ppc/mac_oldworld.c

  Log Message:
  -----------
  adb: QOM'ify ADB devices

They were not qdev'ified before. Derive ADBDevice from DeviceState and
convert reset callbacks to DeviceClass::reset, ADBDevice::opaque pointer
to ADBDevice subtypes for mouse and keyboard and adb_{kbd,mouse}_init()
to regular qdev functions.

Fixing Coding Style issues and splitting keyboard and mouse off into
their own files is left for a later point in time.

Signed-off-by: Andreas Färber <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: 293c867d8c7399d17e6b593053411a6515171f38
      
https://github.com/qemu/qemu/commit/293c867d8c7399d17e6b593053411a6515171f38
  Author: Andreas Färber <address@hidden>
  Date:   2013-01-25 (Fri, 25 Jan 2013)

  Changed paths:
    M hw/adb.h
    M hw/cuda.c
    M hw/ppc/mac.h
    M hw/ppc/mac_newworld.c
    M hw/ppc/mac_oldworld.c

  Log Message:
  -----------
  cuda: Move ADB bus into CUDA state

Replace the global adb_bus with a CUDA-internal one, accessed using
regular qdev child bus accessor.

Signed-off-by: Andreas Färber <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: fe828a4d4b7a5617cda7b24e95e327bfb71d790e
      
https://github.com/qemu/qemu/commit/fe828a4d4b7a5617cda7b24e95e327bfb71d790e
  Author: Mike Qiu <address@hidden>
  Date:   2013-01-25 (Fri, 25 Jan 2013)

  Changed paths:
    M target-ppc/translate_init.c

  Log Message:
  -----------
  target-ppc: Give a meaningful error if too many threads are specified

Currently the target-ppc tcg code only supports a single thread.  You can
specify more, but they're treated identically to multiple cores.  On KVM
we obviously can't support more threads than the hardware; if more are
specified it will cause strange and cryptic errors.

This patch clarifies the situation by giving a simple meaningful error if
more threads are specified than we can support.

Signed-off-by: Mike Qiu <address@hidden>
Signed-off-by: David Gibson <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: caae58cba07efec5f0616f568531c9dfaf1e9179
      
https://github.com/qemu/qemu/commit/caae58cba07efec5f0616f568531c9dfaf1e9179
  Author: David Gibson <address@hidden>
  Date:   2013-01-25 (Fri, 25 Jan 2013)

  Changed paths:
    M hw/spapr.c
    M hw/spapr_pci.c
    M hw/spapr_pci.h

  Log Message:
  -----------
  pseries: Improve handling of multiple PCI host bridges

Multiple - even many - PCI host bridges (i.e. PCI domains) are very
common on real PAPR compliant hardware.  For reasons related to the
PAPR specified IOMMU interfaces, PCI device assignment with VFIO will
generally require at least two (virtual) PHBs and possibly more
depending on which devices are assigned.

At the moment the qemu PAPR PCI code will not deal with this well,
leaving several crucial parameters of PHBs other than the default one
uninitialized.  This patch reworks the code to allow this.

Every PHB needs a unique BUID (Bus Unit Identifier, the id used for
the PAPR PCI related interfaces) and a unique LIOBN (Logical IO Bus
Number, the id used for the PAPR IOMMU related interfaces).  In
addition they need windows in CPU real address space to access PCI
memory space, PCI IO space and MSIs.  Properties are added to the PCI
host bridge qdevice to allow configuration of all these.

To simplify configuration of multiple PHBs for common cases, a
convenience "index" property is also added.  This can be set instead
of the low-level properties, and will generate suitable values for the
other parameters, different for each index value.

Signed-off-by: David Gibson <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: 1ea1ce8ac305d9e006bc8b0f5f3554793fd2fa43
      
https://github.com/qemu/qemu/commit/1ea1ce8ac305d9e006bc8b0f5f3554793fd2fa43
  Author: David Gibson <address@hidden>
  Date:   2013-01-25 (Fri, 25 Jan 2013)

  Changed paths:
    M hw/spapr_vio.c

  Log Message:
  -----------
  pseries: Adjust default VIO address allocations to play better with libvirt

Currently, if VIO devices for pseries don't have addresses explicitly
allocated, they get automatically numbered from 0x1000.  This is in the
same general range that libvirt will typically assign VIO device addresses.

That means that if there is a device libvirt doesn't know about, and it
gets an address assigned before the libvirt assigned devices are processed,
we can end up with an address conflict (qemu will abort with an error).

While the real solution is to teach libvirt about the other devices, so it
can correctly manage the whole allocation, this patch reduces the interim
inconvenience by moving qemu allocations to a range that libvirt is less
likely to conflict with.

Because the guest gets the device addresses through the device tree, these
addresses are truly arbitrary and can be changed without breaking guests.

Signed-off-by: David Gibson <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: f40c360c0da020a1a478f8e60dd205d7412bc315
      
https://github.com/qemu/qemu/commit/f40c360c0da020a1a478f8e60dd205d7412bc315
  Author: Scott Wood <address@hidden>
  Date:   2013-01-25 (Fri, 25 Jan 2013)

  Changed paths:
    M hw/openpic.c

  Log Message:
  -----------
  openpic: fix remaining issues from idr-to-destmask conversion

openpic_update_irq() was checking idr rather than destmask, treating
it as if it were a simple bitmap of cpus.  Changed to use destmask.

IPI delivery was removing bits directly from .idr, without calling
write_IRQreg_idr so that the change could be conveyed to destmask.
Changed to use destmask directly.

Save/restore destmask when serializing, as due to the IPI change it
cannot be reproduced from idr.

Signed-off-by: Scott Wood <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: 03274d44f655f7b822e845e79fa32b261cdb0774
      
https://github.com/qemu/qemu/commit/03274d44f655f7b822e845e79fa32b261cdb0774
  Author: Scott Wood <address@hidden>
  Date:   2013-01-25 (Fri, 25 Jan 2013)

  Changed paths:
    M hw/openpic.c

  Log Message:
  -----------
  openpic: fix timer address decoding

The timer memory range begins at 0x10f0, so that address 0x1120 shows
up as 0x30, 0x1130 shows up as 0x40, etc.  However, the address
decoding (other than TFRR) is not adjusted for this, causing the
wrong registers to be accessed.

Signed-off-by: Scott Wood <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: e0dfe5b18919a6a4deb841dcf3212e3e998c95e5
      
https://github.com/qemu/qemu/commit/e0dfe5b18919a6a4deb841dcf3212e3e998c95e5
  Author: Scott Wood <address@hidden>
  Date:   2013-01-25 (Fri, 25 Jan 2013)

  Changed paths:
    M hw/openpic.c
    M hw/openpic.h

  Log Message:
  -----------
  openpic: add basic support for MPIC v4.2

Besides the new value in the version register, this provides:
- ILR support, which includes:
  - IDR becoming a pure CPU bitmap, allowing 32 CPUs
  - machine check output support (though other parts of QEMU need to
    be fixed for it to do something other than immediately reboot the
    guest)
- dummy error interrupt support (EISR0/EIMR0 read as zero)
  - actually all FSL MPICs get all summary registers returning zero for now,
    which includes EISR0/EIMR0

Various refactoring is done to support these changes and to ease
new functionality (e.g. a more flexible way of declaring regions).

Just as the code was already not a full implementation of MPIC v2.0,
this is not a full implementation of MPIC v4.2 -- e.g. it still has only
one bank of MSIs.

Signed-off-by: Scott Wood <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: bd25922e737a2c90668a7bdd1e1319413a7a51f3
      
https://github.com/qemu/qemu/commit/bd25922e737a2c90668a7bdd1e1319413a7a51f3
  Author: Scott Wood <address@hidden>
  Date:   2013-01-25 (Fri, 25 Jan 2013)

  Changed paths:
    M hw/ppc/e500.c

  Log Message:
  -----------
  PPC: e500: fix mpic_iack address

MPIC+0xa0 is IACK for the current CPU.  MPIC+0x200a0 is IACK for CPU 0.
This fix allows EPR to work with an SMP target.

Signed-off-by: Scott Wood <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: f5fba9d27f14603dc7f85779e7b7362fb1cfcbd8
      
https://github.com/qemu/qemu/commit/f5fba9d27f14603dc7f85779e7b7362fb1cfcbd8
  Author: Scott Wood <address@hidden>
  Date:   2013-01-25 (Fri, 25 Jan 2013)

  Changed paths:
    M hw/ppc/e500.c
    M hw/ppc/e500.h
    M hw/ppc/e500plat.c
    M hw/ppc/mpc8544ds.c

  Log Message:
  -----------
  PPC: e500: Select MPIC v4.2 on ppce500 platform

The compatible string is changed to fsl,mpic on all e500 platforms, to
advertise the existence of BRR1.  This matches what the device tree will
have on real hardware.

With MPIC v4.2 max_cpu can be increased from 15 to 32.

Signed-off-by: Scott Wood <address@hidden>
Signed-off-by: Alexander Graf <address@hidden>


  Commit: 5f7a74a1a605d2065c3d74e42b563d69241089ec
      
https://github.com/qemu/qemu/commit/5f7a74a1a605d2065c3d74e42b563d69241089ec
  Author: Paolo Bonzini <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M tests/Makefile

  Log Message:
  -----------
  tests: adjust gcov variables for directory movement

I had missed the introduction of the gcov-files-* variables.

Cc: Blue Swirl <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: 659800159092333593084593abed2d85c51c5a16
      
https://github.com/qemu/qemu/commit/659800159092333593084593abed2d85c51c5a16
  Author: Paolo Bonzini <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M Makefile.objs

  Log Message:
  -----------
  build: move around libcacard-y definition

It is also needed if !CONFIG_SOFTMMU, unlike everything that surrounds it.
Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: 737f351892e271fb3080c3c26e6453d939dd1d68
      
https://github.com/qemu/qemu/commit/737f351892e271fb3080c3c26e6453d939dd1d68
  Author: Paolo Bonzini <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M Makefile.objs

  Log Message:
  -----------
  build: use -$(CONFIG_SECCOMP) instead of ifeq

Signed-off-by: Paolo Bonzini <address@hidden>
Acked-by: Andreas Färber <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: 000823449ca07e50086413338f907d7a817db2ce
      
https://github.com/qemu/qemu/commit/000823449ca07e50086413338f907d7a817db2ce
  Author: Paolo Bonzini <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M Makefile
    M Makefile.objs
    M Makefile.target
    M disas/Makefile.objs
    M hw/Makefile.objs
    M qom/Makefile.objs

  Log Message:
  -----------
  build: remove universal-obj-y

All of universal-obj-y, user-obj-y (right now unused) and common-obj-y can
be unified into common-obj-y if we take care of defining CONFIG_SOFTMMU
and CONFIG_USER_ONLY in the toplevel makefile.  This is similar to how
we define symbols for hardware components.

Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: 82cb6b041c307bd96c067147af69cd98be91a682
      
https://github.com/qemu/qemu/commit/82cb6b041c307bd96c067147af69cd98be91a682
  Author: Paolo Bonzini <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M Makefile
    M Makefile.objs
    M fsdev/Makefile.objs
    M hw/Makefile.objs
    M hw/pci/Makefile.objs

  Log Message:
  -----------
  build: remove extra-obj-y

extra-obj-y is somewhat complicated to understand.  Replace it with a
special CONFIG_ALL symbol that is defined only at toplevel.
This limits the case of directories defining more than one
*-obj-y target.

Signed-off-by: Paolo Bonzini <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: 0360ccffbe41bd732b42a90cd04de63335933bea
      
https://github.com/qemu/qemu/commit/0360ccffbe41bd732b42a90cd04de63335933bea
  Author: Blue Swirl <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M bsd-user/mmap.c
    M util/oslib-posix.c

  Log Message:
  -----------
  bsd-user: avoid conflict with qemu_vmalloc

Rename qemu_vmalloc() to bsd_vmalloc(), adjust the only user.

Remove #ifdeffery in oslib-posix.c.

Tested-by: Andreas Färber <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: b4451996e712653f9ef4d53d975a158572b8574d
      
https://github.com/qemu/qemu/commit/b4451996e712653f9ef4d53d975a158572b8574d
  Author: Michael Tokarev <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M configure

  Log Message:
  -----------
  link seccomp only with softmmu targets

Now, if seccomp is detected, it is linked into every executable,
but is used only by softmmu targets (from vl.c).  So link it
only where it is actually needed.

Signed-off-by: Michael Tokarev <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: bf4229d3cb09be2efc0add569feba33834fc5d93
      
https://github.com/qemu/qemu/commit/bf4229d3cb09be2efc0add569feba33834fc5d93
  Author: Peter Maydell <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M hw/arm_sysctl.c

  Log Message:
  -----------
  hw/arm_sysctl.c: Add missing 'break' statements

Add some break statements that were accidentally omitted
from some cases of arm_sysctl_write(). The omission was
harmless because in both cases the following case did
an immediate break, but adding the breaks explicitly
placates static analysers and avoids weird behaviour if
the following register is ever implemented as something
other than a no-op.

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: 139bd956eaf1675209009b22764a46bd220e287c
      
https://github.com/qemu/qemu/commit/139bd956eaf1675209009b22764a46bd220e287c
  Author: Peter Maydell <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M hw/omap1.c

  Log Message:
  -----------
  hw/omap1.c: Add fallthrough markers and breaks

Explicitly mark cases where we are deliberately falling
through to the following code. In one case we insert a
'break' instead of falling through to a 'break', as this
seems slightly clearer.

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: be688dfb8ddf7841fb277800977a0a878b68ae42
      
https://github.com/qemu/qemu/commit/be688dfb8ddf7841fb277800977a0a878b68ae42
  Author: Peter Maydell <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M hw/omap_dma.c
    M hw/omap_spi.c

  Log Message:
  -----------
  hw/omap_dma, hw/omap_spi: Explicitly mark fallthroughs

Explicitly mark the fallthroughs as intentional in the code
pattern where we gradually increment an index before falling
into the code to read/write that array entry:
  case THINGY_3: idx++;
  case THINGY_2: idx++;
  case THINGY_1: idx++;
  case THINGY_0: return s->thingy[idx];

This makes static analysers happy.

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: 3095485029ddbd061aa4f8e26c0437f200975d18
      
https://github.com/qemu/qemu/commit/3095485029ddbd061aa4f8e26c0437f200975d18
  Author: Peter Maydell <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M hw/pflash_cfi02.c

  Log Message:
  -----------
  hw/pflash_cfi02.c: Mark deliberate fallthrough

Mark the deliberate fallthrough where we treat the case of
an attempt to read flash when it is an unknown command
state as if it were a normal read.

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: 89556d1725d7c10a54ec66087e940727873f38a3
      
https://github.com/qemu/qemu/commit/89556d1725d7c10a54ec66087e940727873f38a3
  Author: Peter Maydell <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M hw/smc91c111.c

  Log Message:
  -----------
  hw/smc91c111: Add explicit 'return' rather than relying on fallthrough

Add an explicit 'return' statement to a case in smc91c111_readb
rather than relying on fallthrough to the following case's
return statement, for code clarity and to placate static analysers.

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: de16017dc8f2c33c73bd3faebf3c626c400af5e4
      
https://github.com/qemu/qemu/commit/de16017dc8f2c33c73bd3faebf3c626c400af5e4
  Author: Peter Maydell <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M hw/pxa2xx_timer.c

  Log Message:
  -----------
  hw/pxa2xx_timer: Explicitly mark fallthroughs

Explicitly mark the fallthroughs as intentional in the code
pattern where we gradually increment an index before falling
into the code to read/write that array entry:
    case THINGY_3: idx++;
    case THINGY_2: idx++;
    case THINGY_1: idx++;
    case THINGY_0: return s->thingy[idx];

This makes static analysers happy.

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: a6e7c18476f5383720b3f57ef4f467b2e7c2565e
      
https://github.com/qemu/qemu/commit/a6e7c18476f5383720b3f57ef4f467b2e7c2565e
  Author: Richard Sandiford <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M fpu/softfloat.c

  Log Message:
  -----------
  softfloat: Handle float_muladd_negate_c when product is zero

Honour float_muladd_negate_c in the case where the product is zero and
c is nonzero.  Previously we would fail to negate c.

Seen in (and tested against) the gfortran testsuite on MIPS.

Signed-off-by: Richard Sandiford <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: d09acb9b5ef0bb4fa94d3d459919a6ebaf8804bc
      
https://github.com/qemu/qemu/commit/d09acb9b5ef0bb4fa94d3d459919a6ebaf8804bc
  Author: Markus Armbruster <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M hw/fw_cfg.c
    M include/sysemu/sysemu.h
    M vl.c

  Log Message:
  -----------
  fw_cfg: Splash image loader can overrun a stack variable, fix

read_splashfile() passes the address of an int variable as size_t *
parameter to g_file_get_contents(), with a cast to gag the compiler.

No problem on machines where sizeof(size_t) == sizeof(int).

Happens to work on my x86_64 box (64 bit little endian): the least
significant 32 bits of the file size end up in the right place
(caller's variable file_size), and the most significant 32 bits
clobber a place that gets assigned to before its next use (caller's
variable file_type).

I'd expect it to break on a 64 bit big-endian box.

Fix up the variable types and drop the problematic cast.

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: 9f8863ebd7f584762a906881a62a04ac05ce4898
      
https://github.com/qemu/qemu/commit/9f8863ebd7f584762a906881a62a04ac05ce4898
  Author: Markus Armbruster <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M hw/fw_cfg.c

  Log Message:
  -----------
  fw_cfg: Drop a few superfluous initializers

Signed-off-by: Markus Armbruster <address@hidden>
Reviewed-by: Laszlo Ersek <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: 23bf49b5eca716aaad073f2b47613434e1515cb5
      
https://github.com/qemu/qemu/commit/23bf49b5eca716aaad073f2b47613434e1515cb5
  Author: Andreas Färber <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M scripts/make_device_config.sh

  Log Message:
  -----------
  make_device_config.sh: Fix target path in generated dependency file

config-devices.mak.d is included from Makefile.target, i.e. from inside
the *-softmmu/ directory. It included the directory path, so never
applied to the actual ./config-devices.mak. Symptoms were spurious
build failures due to missing dependency on default-configs/pci.mak.

Fix this by using `basename` to strip the directory path.

Reported-by: Gerhard Wiesinger <address@hidden>
Cc: address@hidden
Signed-off-by: Andreas Färber <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: 390999910bf1b1be59e04a0314867f4dea7a28f3
      
https://github.com/qemu/qemu/commit/390999910bf1b1be59e04a0314867f4dea7a28f3
  Author: Peter Maydell <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M qemu-char.c

  Log Message:
  -----------
  qemu-char: Avoid unused variable warning in some configs

Avoid unused variable warnings:
qemu-char.c: In function 'qmp_chardev_open_port':
qemu-char.c:3132: warning: unused variable 'fd'
qemu-char.c:3132: warning: unused variable 'flags'

in configurations with neither HAVE_CHARDEV_TTY nor
HAVE_CHARDEV_PARPORT set.

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: 98ed805c388baaf4ce7d9acbbbc04bbf185f30fc
      
https://github.com/qemu/qemu/commit/98ed805c388baaf4ce7d9acbbbc04bbf185f30fc
  Author: Peter Maydell <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M hw/arm_boot.c

  Log Message:
  -----------
  hw/arm_boot: Align device tree to 4KB boundary, not page

Align the device tree blob to a 4KB boundary, not to QEMU's
idea of a page boundary -- the latter is the smallest possible
page size for the architecture, which on ARM is 1KB.
The documentation for Linux does not impose separation
or alignment requirements on the device tree blob, but
in practice some kernels will happily trash the entire
page the initrd ends in after they have finished uncompressing
the initrd. So 4KB-align the DTB to ensure it does not get
trampled by these kernels.

Signed-off-by: Peter Maydell <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: 0c3c89d649d029b29bf245f739c82339fcf2e699
      
https://github.com/qemu/qemu/commit/0c3c89d649d029b29bf245f739c82339fcf2e699
  Author: Paolo Bonzini <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M Makefile

  Log Message:
  -----------
  build: remove *.lo, *.a, *.la files from all subdirectories on make clean

.lo files in stubs/, util/ and libcacard/ were not cleaned.
Fix this.

Cc: Blue Swirl <address@hidden>
Reported-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Michal Privoznik <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: 3f0f31a0f1c9a89314e9f9ed423371f4d925d5a6
      
https://github.com/qemu/qemu/commit/3f0f31a0f1c9a89314e9f9ed423371f4d925d5a6
  Author: Blue Swirl <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M tests/test-string-input-visitor.c

  Log Message:
  -----------
  tests: add fuzzing to visitor tests

Perform input tests on random data.

Improvement to code coverage for qapi/string-input-visitor.c
is about 3 percentage points.

Signed-off-by: Blue Swirl <address@hidden>


  Commit: 8cb6bfb54e91b1a31a6ae704def595c2099efde1
      
https://github.com/qemu/qemu/commit/8cb6bfb54e91b1a31a6ae704def595c2099efde1
  Author: Michael Tokarev <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M hw/vmware_vga.c

  Log Message:
  -----------
  vmware_vga: fix out of bounds and invalid rects updating

This is a follow up for several attempts to fix this issue.

Previous incarnations:

1. http://thread.gmane.org/gmane.linux.ubuntu.bugs.general/3156089
https://bugs.launchpad.net/bugs/918791
"qemu-kvm dies when using vmvga driver and unity in the guest" bug.
Fix by Serge Hallyn:
 https://launchpadlibrarian.net/94916786/qemu-vmware.debdiff
This fix is incomplete, since it does not check width and height
for being negative.  Serge weren't sure if that's the right place
to fix it, maybe the fix should be up the stack somewhere.

2. http://thread.gmane.org/gmane.comp.emulators.qemu/166064
by Marek Vasut: "vmware_vga: Redraw only visible area"

This one adds the (incomplete) check to vmsvga_update_rect_delayed(),
the routine just queues the rect updating but does no interesting
stuff.  It is also incomplete in the same way as patch by Serge,
but also does not touch width&height at all after adjusting x&y,
which is wrong.

As far as I can see, when processing guest requests, the device
places them into a queue (vmsvga_update_rect_delayed()) and
processes this queue in different place/time, namely, in
vmsvga_update_rect().  Sometimes, vmsvga_update_rect() is
called directly, without placing the request to the gueue.
This is the place this patch changes, which is the last
(deepest) in the stack.  I'm not sure if this is the right
place still, since it is possible we have some queue optimization
(or may have in the future) which will be upset by negative/wrong
values here, so maybe we should check for validity of input
right when receiving request from the guest (and maybe even
use unsigned types there).  But I don't know the protocol
and implementation enough to have a definitive answer.

But since vmsvga_update_rect() has other sanity checks already,
I'm adding the missing ones there as well.

Cc'ing BALATON Zoltan and Andrzej Zaborowski who shows in `git blame'
output and may know something in this area.

If this patch is accepted, it should be applied to all active
stable branches (at least since 1.1, maybe even before), with
minor context change (ds_get_*(s->vga.ds) => s->*).  I'm not
Cc'ing -stable yet, will do it explicitly once the patch is
accepted.

BTW, these checks use fprintf(stderr) -- it should be converted
to something more appropriate, since stderr will most likely
disappear somewhere.

Cc: Marek Vasut <address@hidden>
CC: Serge Hallyn <address@hidden>
Cc: BALATON Zoltan <address@hidden>
Cc: Andrzej Zaborowski <address@hidden>
Signed-off-by: Michael Tokarev <address@hidden>
Reviewed-by: Marek Vasut <address@hidden>
Signed-off-by: Serge Hallyn <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: 6a6944957801f5b981e09d6bff4f1bd5529f7019
      
https://github.com/qemu/qemu/commit/6a6944957801f5b981e09d6bff4f1bd5529f7019
  Author: Andreas Färber <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M tests/Makefile

  Log Message:
  -----------
  tests: Fix gcov typo for tmp105-test

Commit 6e9989034b176a8e4cfdccd85892abfa73977ba7 introduced a new qtest
test case but misspelled gcov, leading to no coverage analysis. Fix it.

Signed-off-by: Andreas Färber <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: cba040c2b19f584bb33ae83af8517ecc9796e328
      
https://github.com/qemu/qemu/commit/cba040c2b19f584bb33ae83af8517ecc9796e328
  Author: Andreas Färber <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M tests/Makefile

  Log Message:
  -----------
  tests: Add gcov support for sparc64 qtest

m48t59-test is individually being executed for sparc and sparc64, so add
the gcov source file for sparc64 as well.

Signed-off-by: Andreas Färber <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: c5cd02ba16e784699d04456c8e406445db997121
      
https://github.com/qemu/qemu/commit/c5cd02ba16e784699d04456c8e406445db997121
  Author: Andreas Färber <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M tests/Makefile

  Log Message:
  -----------
  tests: Add gcov support for x86_64 qtest

Since x86_64 is a superset of i386 and reuses all its test cases, adopt
all the i386 gcov source files as well, substituting their paths
appropriately.

Signed-off-by: Andreas Färber <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: 13144781d4e9e6100b398213f9000576a3dc88f9
      
https://github.com/qemu/qemu/commit/13144781d4e9e6100b398213f9000576a3dc88f9
  Author: Blue Swirl <address@hidden>
  Date:   2013-01-26 (Sat, 26 Jan 2013)

  Changed paths:
    M MAINTAINERS
    M hw/adb.c
    M hw/adb.h
    M hw/cuda.c
    M hw/grackle_pci.c
    M hw/heathrow_pic.c
    M hw/ide.h
    M hw/ide/macio.c
    M hw/mac_nvram.c
    M hw/macio.c
    M hw/openpic.c
    M hw/openpic.h
    M hw/ppc/Makefile.objs
    M hw/ppc/e500.c
    M hw/ppc/e500.h
    M hw/ppc/e500plat.c
    A hw/ppc/mac.h
    A hw/ppc/mac_newworld.c
    A hw/ppc/mac_oldworld.c
    M hw/ppc/mpc8544ds.c
    R hw/ppc_mac.h
    R hw/ppc_newworld.c
    R hw/ppc_oldworld.c
    M hw/spapr.c
    M hw/spapr_pci.c
    M hw/spapr_pci.h
    M hw/spapr_vio.c
    M hw/unin_pci.c
    M target-ppc/translate_init.c

  Log Message:
  -----------
  Merge branch 'ppc-for-upstream' of git://repo.or.cz/qemu/agraf

* 'ppc-for-upstream' of git://repo.or.cz/qemu/agraf:
  PPC: e500: Select MPIC v4.2 on ppce500 platform
  PPC: e500: fix mpic_iack address
  openpic: add basic support for MPIC v4.2
  openpic: fix timer address decoding
  openpic: fix remaining issues from idr-to-destmask conversion
  pseries: Adjust default VIO address allocations to play better with libvirt
  pseries: Improve handling of multiple PCI host bridges
  target-ppc: Give a meaningful error if too many threads are specified
  cuda: Move ADB bus into CUDA state
  adb: QOM'ify ADB devices
  adb: QOM'ify Apple Desktop Bus
  cuda: QOM'ify CUDA
  ide/macio: QOM'ify MacIO IDE
  mac_nvram: QOM'ify MacIO NVRAM
  mac_nvram: Mark as Big Endian
  mac_nvram: Clean up public API
  macio: Split MacIO in two
  macio: Delay qdev init until all fields are initialized
  macio: QOM'ify some more
  ppc: Move Mac machines to hw/ppc/


Compare: https://github.com/qemu/qemu/compare/11c29918be32...13144781d4e9

reply via email to

[Prev in Thread] Current Thread [Next in Thread]