[Qemu-commits] [qemu/qemu] ab51b1: disallow -daemonize usage of stdio (curses display...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: ab51b1d568e02c80b1abf9016bda3a86dc1db389
      
https://github.com/qemu/qemu/commit/ab51b1d568e02c80b1abf9016bda3a86dc1db389
  Author: Michael Tokarev <address@hidden>
  Date:   2013-01-02 (Wed, 02 Jan 2013)

  Changed paths:
    M qemu-char.c
    M vl.c

  Log Message:
  -----------
  disallow -daemonize usage of stdio (curses display, -nographic, -serial stdio 
etc)

Curses display requires stdin/out to stay on the terminal,
so -daemonize makes no sense in this case.  Instead of
leaving display uninitialized like is done since 995ee2bf469de6bb,
explicitly detect this case earlier and error out.

-nographic can actually be used with -daemonize, by redirecting
everything to a null device, but the problem is that according
to documentation and historical behavour, -nographic redirects
guest ports to stdin/out, which, again, makes no sense in case
of -daemonize.  Since -nographic is a legacy option, don't bother
fixing this case (to allow -nographic and -daemonize by redirecting
guest ports to null instead of stdin/out in this case), but disallow
it completely instead, to stop garbling host terminal.

If no display display needed and user wants to use -nographic,
the right way to go is to use
  -serial null -parallel null -monitor none -display none -vga none
instead of -nographic.

Also prevent the same issue -- it was possible to get garbled
host tty after

  -nographic -daemonize

and it is still possible to have it by using

  -serial stdio -daemonize

Fix this by disallowing opening stdio chardev when -daemonize
is specified.

Signed-off-by: Michael Tokarev <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 74e91370beb3fabda515623b4491a8b7a024304a
      
https://github.com/qemu/qemu/commit/74e91370beb3fabda515623b4491a8b7a024304a
  Author: Michael Tokarev <address@hidden>
  Date:   2013-01-02 (Wed, 02 Jan 2013)

  Changed paths:
    M savevm.c

  Log Message:
  -----------
  savevm.c: cleanup system includes

savevm.c suffers from the same problem as some other files.
Some years ago savevm.c was created from vl.c, moving some
code from there into a separate file.  At that time, all
includes were just copied from vl.c to savevm.c, without
checking which ones are needed and which are not.

But actually most of that stuff is _not_ needed.  More, some
stuff is wrong, for example, *BSD #ifdef'ery around <util.h>
vs <libutil.h> - for one, it fails to build on Debian/kFreebsd.

Just remove all this.  Maybe there's a possibility to clean
it up further - like removing <windows.h> (and maybe including
winsock.h for htons etc), and maybe it's possible to remove
some internal #includes too, but I didn't check this.

While at it, remove duplicate #include of qemu/timer.h.

Signed-off-by: Michael Tokarev <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: 503483336039a8b2b182535f87f4820d259fca82
      
https://github.com/qemu/qemu/commit/503483336039a8b2b182535f87f4820d259fca82
  Author: Stefan Weil <address@hidden>
  Date:   2013-01-02 (Wed, 02 Jan 2013)

  Changed paths:
    M Makefile.target
    M disas/Makefile.objs

  Log Message:
  -----------
  tci: Fix broken builds with TCG interpreter

TCI no longer compiled after commit 76cad71136b7eb371cf2a2a4e1621cfe8d9c769a.

The TCI disassembler depends on data structures which are different for
each QEMU target, so it cannot be compiled as a universal-obj today.

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>


  Commit: dbd99ae302be8f51b547fb6283c91d0c9859b7d5
      
https://github.com/qemu/qemu/commit/dbd99ae302be8f51b547fb6283c91d0c9859b7d5
  Author: Stefan Weil <address@hidden>
  Date:   2013-01-02 (Wed, 02 Jan 2013)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: Write new file "config-all-disas.mak" when running configure

Incremental builds added new lines to that file each time when configure
was run.

Now a new file with a comment line is written.

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Anthony Liguori <address@hidden>


Compare: https://github.com/qemu/qemu/compare/217da7fdeb2a...dbd99ae302be