[Qemu-commits] [qemu/qemu] eec897: target-mips: Fix incorrect reads and writes to DSP...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: eec8972a5bc744eda695a86a984d746c240dff90
      
https://github.com/qemu/qemu/commit/eec8972a5bc744eda695a86a984d746c240dff90
  Author: Petar Jovanovic <address@hidden>
  Date:   2013-01-01 (Tue, 01 Jan 2013)

  Changed paths:
    M target-mips/dsp_helper.c
    M tests/tcg/mips/mips32-dsp/rddsp.c
    M tests/tcg/mips/mips32-dsp/wrdsp.c

  Log Message:
  -----------
  target-mips: Fix incorrect reads and writes to DSPControl register

Upper 4 bits of ccond (bits 31..28 ) of DSPControl register are not used in
the MIPS32 architecture. They are used in the MIPS64 architecture. For MIPS32
these bits must be written as zero, and return zero on read.

The change fixes writes (WRDSP) and reads (RDDSP) to the register. It also fixes
the tests that use these instructions, and makes them smaller and simpler.

Signed-off-by: Petar Jovanovic <address@hidden>
Signed-off-by: Aurelien Jarno <address@hidden>


  Commit: b8abbbe8df5e04085f4b85fc4f7cf85efbcd492c
      
https://github.com/qemu/qemu/commit/b8abbbe8df5e04085f4b85fc4f7cf85efbcd492c
  Author: Petar Jovanovic <address@hidden>
  Date:   2013-01-01 (Tue, 01 Jan 2013)

  Changed paths:
    M target-mips/dsp_helper.c
    M tests/tcg/mips/mips32-dsp/extr_r_w.c
    M tests/tcg/mips/mips32-dsp/extr_rs_w.c
    M tests/tcg/mips/mips32-dsp/extr_s_h.c
    M tests/tcg/mips/mips32-dsp/extr_w.c
    M tests/tcg/mips/mips32-dsp/extrv_r_w.c
    M tests/tcg/mips/mips32-dsp/extrv_rs_w.c
    M tests/tcg/mips/mips32-dsp/extrv_s_h.c
    M tests/tcg/mips/mips32-dsp/extrv_w.c

  Log Message:
  -----------
  target-mips: Fix for helpers for EXTR_* instructions

The change removes some unnecessary and incorrect code for EXTR_S.H.
Further, it corrects the mask for shift value in the EXTR_ instructions. It also
extends the existing tests so they trigger the issues corrected with the change.

Signed-off-by: Petar Jovanovic <address@hidden>
Signed-off-by: Aurelien Jarno <address@hidden>


  Commit: 79eb8392db19a916f6a3277f7cd36fb22c2bdbaf
      
https://github.com/qemu/qemu/commit/79eb8392db19a916f6a3277f7cd36fb22c2bdbaf
  Author: Stefan Weil <address@hidden>
  Date:   2013-01-01 (Tue, 01 Jan 2013)

  Changed paths:
    M target-mips/op_helper.c

  Log Message:
  -----------
  target-mips: Remove semicolon from macro definition

Macro RESTORE_FLUSH_MODE is similar to RESTORE_ROUNDING_MODE
but included a semicolon.

The code which uses that macro also includes a semicolon,
so the result was an empty statement.

Remove the superfluous semicolon from the macro definition.

Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Aurelien Jarno <address@hidden>


Compare: https://github.com/qemu/qemu/compare/a795ef8dcb8c...79eb8392db19