[Qemu-commits] [qemu/qemu] b6348f: target-arm/translate: Fix RRX operands

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: b6348f29d033d5a8a26f633d2ee94362595f32a4
      
https://github.com/qemu/qemu/commit/b6348f29d033d5a8a26f633d2ee94362595f32a4
  Author: Peter Crosthwaite <address@hidden>
  Date:   2012-10-17 (Wed, 17 Oct 2012)

  Changed paths:
    M target-arm/translate.c

  Log Message:
  -----------
  target-arm/translate: Fix RRX operands

Instructions that both use the RRX second operand and update CS were
incorrect, as the Carry flag was updated too early. An example of such an
instruction would be:

ands r12,r13,RRX

Ands, because of the "s" flag will update the carry flag. But the RRX second
operand rotates through the C flag which should happen before the update.
Fixed the ordering of the two, the old carry is read by "r13,RRX" before being
updated.

Signed-off-by: Peter Crosthwaite <address@hidden>
Reported-by: Vinesh Peringat <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Aurelien Jarno <address@hidden>