[Qemu-commits] [qemu/qemu] b1f467: i386: kvm: bit 10 of CPUID[8000_0001].EDX is reser...

[GitHub]

  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: b1f4679392a03f2b26a37bfa52e95d6cc4f73d82
      
https://github.com/qemu/qemu/commit/b1f4679392a03f2b26a37bfa52e95d6cc4f73d82
  Author: Eduardo Habkost <address@hidden>
  Date:   2012-09-30 (Sun, 30 Sep 2012)

  Changed paths:
    M target-i386/kvm.c

  Log Message:
  -----------
  i386: kvm: bit 10 of CPUID[8000_0001].EDX is reserved

Bit 10 of CPUID[8000_0001].EDX is not defined as an alias of
CPUID[1].EDX[10], so do not duplicate it on
kvm_arch_get_supported_cpuid().

Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-By: Igor Mammedov <address@hidden>
Reviewed-by: Don Slutz <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: 8fad4b44a0f71cd404f95f109657c0ccbf11f8f9
      
https://github.com/qemu/qemu/commit/8fad4b44a0f71cd404f95f109657c0ccbf11f8f9
  Author: Eduardo Habkost <address@hidden>
  Date:   2012-09-30 (Sun, 30 Sep 2012)

  Changed paths:
    M target-i386/cpu.h
    M target-i386/kvm.c

  Log Message:
  -----------
  i386: kvm: use a #define for the set of alias feature bits

Instea of using a hardcoded hex constant, define CPUID_EXT2_AMD_ALIASES
as the set of CPUID[8000_0001].EDX bits that on AMD are the same as the
bits of CPUID[1].EDX.

Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-By: Igor Mammedov <address@hidden>
Reviewed-by: Don Slutz <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: 60032ac04c675cf8950497f9d06e681b2dc7085c
      
https://github.com/qemu/qemu/commit/60032ac04c675cf8950497f9d06e681b2dc7085c
  Author: Eduardo Habkost <address@hidden>
  Date:   2012-09-30 (Sun, 30 Sep 2012)

  Changed paths:
    M target-i386/cpu.c

  Log Message:
  -----------
  i386: cpu: replace EXT2_FEATURE_MASK with CPUID_EXT2_AMD_ALIASES

Both constants have the same value, but CPUID_EXT2_AMD_ALIASES is
defined without using magic numbers.

Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Don Slutz <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: 3b671a40cab2404bc63e57db8cd3afa4ec70bfab
      
https://github.com/qemu/qemu/commit/3b671a40cab2404bc63e57db8cd3afa4ec70bfab
  Author: Eduardo Habkost <address@hidden>
  Date:   2012-09-30 (Sun, 30 Sep 2012)

  Changed paths:
    M target-i386/cpu.c

  Log Message:
  -----------
  i386: cpu: eliminate duplicate feature names

Instead of having duplicate feature names on the ext2_feature array for
the AMD feature bit aliases, we keep the feature names only on the
feature_name[] array, and copy the corresponding bits to
cpuid_ext2_features in case the CPU vendor is AMD.

This will:

- Make sure we don't set the feature bit aliases on Intel CPUs;
- Make it easier to convert feature bits to CPU properties, as now we
  have a single bit on the x86_def_t struct for each CPU feature.

Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Don Slutz <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


  Commit: 4a19e505df659dd25a77fb790399744f3e1f971c
      
https://github.com/qemu/qemu/commit/4a19e505df659dd25a77fb790399744f3e1f971c
  Author: Eduardo Habkost <address@hidden>
  Date:   2012-09-30 (Sun, 30 Sep 2012)

  Changed paths:
    M target-i386/cpu.c

  Log Message:
  -----------
  i386: -cpu help: remove reference to specific CPUID leaves/registers

The -cpu configuration interface is based on a list of feature names or
properties, on a single namespace, so there's no need to mention on
which CPUID leaf/register each flag is located.

Signed-off-by: Eduardo Habkost <address@hidden>
Reviewed-by: Don Slutz <address@hidden>
Signed-off-by: Blue Swirl <address@hidden>


Compare: https://github.com/qemu/qemu/compare/6f8fd2530e9a...4a19e505df65