qemu-commits
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-commits] [qemu/qemu] 835cab: spice: abort on invalid streaming cmd

From: GitHub
Subject: [Qemu-commits] [qemu/qemu] 835cab: spice: abort on invalid streaming cmdline params
Date: Mon, 10 Sep 2012 07:00:13 -0700 
  Branch: refs/heads/master
  Home:   https://github.com/qemu/qemu
  Commit: 835cab85ad83ed8dfe1c13243aeda5959b153e3e
      
https://github.com/qemu/qemu/commit/835cab85ad83ed8dfe1c13243aeda5959b153e3e
  Author: Christophe Fergeau <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M ui/spice-core.c

  Log Message:
  -----------
  spice: abort on invalid streaming cmdline params

When parsing its command line parameters, spice aborts when it
finds unexpected values, except for the 'streaming-video' option.
This happens because the parsing of the parameters for this option
is done using the 'name2enum' helper, which does not error out
on unknown values. Using the 'parse_name' helper makes sure we
error out in this case. Looking at git history, the use of
'name2enum' instead of 'parse_name' seems to have been an oversight,
so let's change to that now.

Fixes rhbz#831708

Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: f5bb039c6d97ef3e664094eab3c9a4dc1824ed73
      
https://github.com/qemu/qemu/commit/f5bb039c6d97ef3e664094eab3c9a4dc1824ed73
  Author: Yonit Halperin <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M ui/spice-core.c

  Log Message:
  -----------
  spice: notify spice server on vm start/stop

Spice server needs to know about the vm state in order to prevent
attempts to write to devices when they are stopped, mainly during
the non-live stage of migration.
Instead, spice will take care of restoring this writes, on the migration
target side, after migration completes.

Signed-off-by: Yonit Halperin <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 71d388d420e68ac77cd42f15f7e68cf5a6fb01b2
      
https://github.com/qemu/qemu/commit/71d388d420e68ac77cd42f15f7e68cf5a6fb01b2
  Author: Yonit Halperin <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M hw/qxl.c
    M ui/spice-core.c
    M ui/spice-display.c
    M ui/spice-display.h

  Log Message:
  -----------
  spice: notify on vm state change only via spice_server_vm_start/stop

QXLWorker->start/stop are deprecated since spice-server 0.11.2

Signed-off-by: Yonit Halperin <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 2fdd16e239c2a2763aa3266e637718123328688c
      
https://github.com/qemu/qemu/commit/2fdd16e239c2a2763aa3266e637718123328688c
  Author: Yonit Halperin <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M monitor.c
    M monitor.h
    M ui/spice-core.c

  Log Message:
  -----------
  spice migration: add QEVENT_SPICE_MIGRATE_COMPLETED

When migrating, libvirt queries the migration status, and upon migration
completions, it closes the migration src. On the other hand, when
migration is completed, spice transfers data from the src to destination
via the client. This data is required for keeping the spice session
after migration, without suffering from data loss and inconsistencies.
In order to allow this data transfer, we add QEVENT for signaling
libvirt that spice migration has completed, and libvirt needs to wait
for this event before quitting the src process.

Signed-off-by: Yonit Halperin <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 61c4efe2cb85b0a9c6bc68f6a2dd107c8d7ec080
      
https://github.com/qemu/qemu/commit/61c4efe2cb85b0a9c6bc68f6a2dd107c8d7ec080
  Author: Yonit Halperin <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M hmp.c
    M qapi-schema.json
    M ui/spice-core.c

  Log Message:
  -----------
  spice: add 'migrated' flag to spice info

The flag is 'true' when spice migration has completed on the src side.
It is needed for a case where libvirt dies before migration completes
and it misses the event QEVENT_SPICE_MIGRATE_COMPLETED.
When libvirt is restored and queries the migration status, it also needs
to query spice and check if its migration has completed.

Signed-off-by: Yonit Halperin <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 8c9570530c819821b9b5cc3113d2b2966afe7621
      
https://github.com/qemu/qemu/commit/8c9570530c819821b9b5cc3113d2b2966afe7621
  Author: Yonit Halperin <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M qemu-config.c
    M qemu-options.hx
    M ui/spice-core.c

  Log Message:
  -----------
  spice: adding seamless-migration option to the command line

The seamless-migration flag is required in order to identify
whether libvirt supports the new QEVENT_SPICE_MIGRATE_COMPLETED or not
(by default the flag is off).
New libvirt versions that wait for QEVENT_SPICE_MIGRATE_COMPLETED should turn 
on this flag.
When this flag is off, spice fallbacks to its old migration method, which
can result in data loss.

Signed-off-by: Yonit Halperin <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 27af778828db9aa893fa1de928744141e5de20e5
      
https://github.com/qemu/qemu/commit/27af778828db9aa893fa1de928744141e5de20e5
  Author: Yonit Halperin <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M qemu-options.hx

  Log Message:
  -----------
  spice: increase the verbosity of spice section in "qemu --help"

Added all spice options to the help string. This can be used by libvirt
to determine which spice related features are supported by qemu.

Signed-off-by: Yonit Halperin <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 511b13e2c9b426b3c56060909693de5097f0b496
      
https://github.com/qemu/qemu/commit/511b13e2c9b426b3c56060909693de5097f0b496
  Author: Alon Levy <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M hw/qxl.c

  Log Message:
  -----------
  qxl/update_area_io: guest_bug on invalid parameters

Signed-off-by: Alon Levy <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 36839d355e4ffc77d8f937caa6bb4c5530b9237e
      
https://github.com/qemu/qemu/commit/36839d355e4ffc77d8f937caa6bb4c5530b9237e
  Author: Alon Levy <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M hw/qxl.c

  Log Message:
  -----------
  qxl: disallow unknown revisions

Signed-off-by: Alon Levy <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 020af1c45fec664d5d4cf3b8e5117f8bc1d691f2
      
https://github.com/qemu/qemu/commit/020af1c45fec664d5d4cf3b8e5117f8bc1d691f2
  Author: Alon Levy <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M configure
    M hw/qxl.c
    M hw/qxl.h
    M trace-events
    M ui/spice-display.h

  Log Message:
  -----------
  qxl: add QXL_IO_MONITORS_CONFIG_ASYNC

Revision bumped to 4 for new IO support, enabled for spice-server >=
0.11.1. New io enabled if revision is 4. Revision can be set to 4.

[ kraxel: 3 continues to be the default revision.  Once we have a new
    stable spice-server release and the qemu patches to enable
    the new bits merged we'll go flip the switch and make rev4
    the default ]

This io calls the corresponding new spice api
spice_qxl_monitors_config_async to let spice-server read a new guest set
monitors config and notify the client.

On migration reissue spice_qxl_monitors_config_async.

RHBZ: 770842

Signed-off-by: Alon Levy <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>

fixup

Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 2e0e3c399aa8067148055b9ea0edb822c5b584d2
      
https://github.com/qemu/qemu/commit/2e0e3c399aa8067148055b9ea0edb822c5b584d2
  Author: Alon Levy <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M configure

  Log Message:
  -----------
  configure: print spice-protocol and spice-server versions

Signed-off-by: Alon Levy <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: ddd8fdc78ee30fc445e3d1f5bd2056acfcdefe47
      
https://github.com/qemu/qemu/commit/ddd8fdc78ee30fc445e3d1f5bd2056acfcdefe47
  Author: Gerd Hoffmann <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M hw/qxl.c
    M hw/qxl.h
    M ui/spice-display.c
    M ui/spice-display.h

  Log Message:
  -----------
  spice: make number of surfaces runtime-configurable.

Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: c10018d6c77c94a8c703b9e4f026da74cad73d9e
      
https://github.com/qemu/qemu/commit/c10018d6c77c94a8c703b9e4f026da74cad73d9e
  Author: Søren Sandmann Pedersen <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M hw/qxl.c

  Log Message:
  -----------
  qxl: Add set_client_capabilities() interface to QXLInterface

This new interface lets spice server inform the guest whether

(a) a client is connected
(b) what capabilities the client has

There is a fixed number (464) of bits reserved for capabilities, and
when the capabilities bits change, the QXL_INTERRUPT_CLIENT interrupt
is generated.

Signed-off-by: Soren Sandmann <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 265db734901df7d8f24796ad7c43923249651289
      
https://github.com/qemu/qemu/commit/265db734901df7d8f24796ad7c43923249651289
  Author: Søren Sandmann Pedersen <address@hidden>
  Date:   2012-09-05 (Wed, 05 Sep 2012)

  Changed paths:
    M hw/qxl.c

  Log Message:
  -----------
  Remove #ifdef QXL_COMMAND_FLAG_COMPAT_16BPP

We require spice >= 0.8 now, so this flag is always present.

Signed-off-by: Soren Sandmann <address@hidden>
Signed-off-by: Gerd Hoffmann <address@hidden>


  Commit: 69fc255350af9e8e39e29b4d6a84d44f0a55ebf2
      
https://github.com/qemu/qemu/commit/69fc255350af9e8e39e29b4d6a84d44f0a55ebf2
  Author: Aurelien Jarno <address@hidden>
  Date:   2012-09-10 (Mon, 10 Sep 2012)

  Changed paths:
    M configure
    M hmp.c
    M hw/qxl.c
    M hw/qxl.h
    M monitor.c
    M monitor.h
    M qapi-schema.json
    M qemu-config.c
    M qemu-options.hx
    M trace-events
    M ui/spice-core.c
    M ui/spice-display.c
    M ui/spice-display.h

  Log Message:
  -----------
  Merge branch 'spice.v59' of git://anongit.freedesktop.org/spice/qemu

* 'spice.v59' of git://anongit.freedesktop.org/spice/qemu:
  Remove #ifdef QXL_COMMAND_FLAG_COMPAT_16BPP
  qxl: Add set_client_capabilities() interface to QXLInterface
  spice: make number of surfaces runtime-configurable.
  configure: print spice-protocol and spice-server versions
  qxl: add QXL_IO_MONITORS_CONFIG_ASYNC
  qxl: disallow unknown revisions
  qxl/update_area_io: guest_bug on invalid parameters
  spice: increase the verbosity of spice section in "qemu --help"
  spice: adding seamless-migration option to the command line
  spice: add 'migrated' flag to spice info
  spice migration: add QEVENT_SPICE_MIGRATE_COMPLETED
  spice: notify on vm state change only via spice_server_vm_start/stop
  spice: notify spice server on vm start/stop
  spice: abort on invalid streaming cmdline params


Compare: https://github.com/qemu/qemu/compare/e22b1e990783...69fc255350af
reply via email to
[Prev in Thread] Current Thread [Next in Thread]