qemu-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-commits] [COMMIT 850810d] Improve error reporting on file acce


From: Gerd Hoffmann
Subject: Re: [Qemu-commits] [COMMIT 850810d] Improve error reporting on file access
Date: Mon, 05 Oct 2009 23:14:51 +0200
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.4pre) Gecko/20090922 Fedora/3.0-2.7.b4.fc11 Lightning/1.0pre Thunderbird/3.0b4

On 10/05/09 22:46, Anthony Liguori wrote:

The neat being that some of the conditions under which this code runs
do set errno while others have nothing to do with it..

Yeah but I figured that a bad errmsg is more useful than nothing.

You mean those funny things like "open $file failed: Success"?
Not so funny in case the errno string is plausible but wrong.

Getting errno to be reliable is tough because in these paths, there are
various function calls that can throw off errno.

IMO errno should not be used if it isn't reliable.

cheers,
  Gerd




reply via email to

[Prev in Thread] Current Thread [Next in Thread]